From owner-svn-src-all@FreeBSD.ORG Mon May 25 14:58:07 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 53D4553C; Mon, 25 May 2015 14:58:07 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2D761698; Mon, 25 May 2015 14:58:07 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (pool-173-54-116-245.nwrknj.fios.verizon.net [173.54.116.245]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 8D3DAB93B; Mon, 25 May 2015 10:58:05 -0400 (EDT) From: John Baldwin To: "Alexander V. Chernikov" Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r283364 - head/sys/sys Date: Mon, 25 May 2015 10:32:40 -0400 Message-ID: <3116734.QKYigSPBbf@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.1-STABLE; KDE/4.14.3; amd64; ; ) In-Reply-To: <2823711432562229@web7h.yandex.ru> References: <201505241124.t4OBOFe6030452@svn.freebsd.org> <1698551.fhQlKrx2sg@ralph.baldwin.cx> <2823711432562229@web7h.yandex.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Mon, 25 May 2015 10:58:05 -0400 (EDT) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 May 2015 14:58:07 -0000 On Monday, May 25, 2015 04:57:09 PM Alexander V. Chernikov wrote: > 25.05.2015, 14:45, "John Baldwin" : > > On Sunday, May 24, 2015 11:24:15 AM Alexander V. Chernikov wrote: > >> Author: melifaro > >> Date: Sun May 24 11:24:14 2015 > >> New Revision: 283364 > >> URL: https://svnweb.freebsd.org/changeset/base/283364 > >> > >> Log: > >> Fix SIOCGI2C structure requirement. > >> > >> In reality, SIOCGI2C ioctl requires struct ifreq as many other > >> ioctls. Doing copyin() on (significantly) larger struct ifstat = sometimes > >> triggered EFAULT. > >> > >> Reported by: Olivier Cochard-Labb=E9 > >> MFC after: 1 week > > > > Note that this breaks the ABI. You may wish to add a SIOCGI2C_OLD = that > In general, yes. Since this was not merged to -stable and I'm mostly = sure that ifconfig > is the only user - this is most likely OK. Oh, the MFC after threw me off, I didn't realize it was never merged to= stable. In that case compat is certainly not needed. > > still uses the larger struct so that old programs continue to work.= OTOH, > > they were only working by accident before. If we expect that no co= de > Well, yes. I'm wondering why this worked at all (copyout tried to get= 8XX bytes instead of 32). Well, if the ifreq was on the stack there was probably space beyond it,= so it was just a buffer overrun (in effect). --=20 John Baldwin