From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Jul 13 18:30:09 2011 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 52B2E106566C for ; Wed, 13 Jul 2011 18:30:09 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 15CC78FC14 for ; Wed, 13 Jul 2011 18:30:09 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p6DIU8hQ009271 for ; Wed, 13 Jul 2011 18:30:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p6DIU8Gm009270; Wed, 13 Jul 2011 18:30:08 GMT (envelope-from gnats) Resent-Date: Wed, 13 Jul 2011 18:30:08 GMT Resent-Message-Id: <201107131830.p6DIU8Gm009270@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Leon Meßner Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 86D78106566B for ; Wed, 13 Jul 2011 18:23:06 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 76B148FC18 for ; Wed, 13 Jul 2011 18:23:06 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p6DIN5Hf000561 for ; Wed, 13 Jul 2011 18:23:05 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id p6DIN503000551; Wed, 13 Jul 2011 18:23:05 GMT (envelope-from nobody) Message-Id: <201107131823.p6DIN503000551@red.freebsd.org> Date: Wed, 13 Jul 2011 18:23:05 GMT From: Leon Meßner To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/158876: [PATCH] zfs-stats devides by zero if $demand_data_total = 0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jul 2011 18:30:09 -0000 >Number: 158876 >Category: ports >Synopsis: [PATCH] zfs-stats devides by zero if $demand_data_total = 0 >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Jul 13 18:30:08 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Leon Meßner >Release: 8-STABLE >Organization: >Environment: FreeBSD siloneu.physik-pool.tu-berlin.de 8.2-STABLE FreeBSD 8.2-STABLE #0: Mon Jun 20 00:49:56 CEST 2011 master@siloneu.physik-pool.tu-berlin.de:/usr/obj/usr/src/sys/DEBUG amd64 >Description: Running zfs-stats version 1.0 20:02_root@siloneu:/usr/local/bin# zfs-stats -V zfs-stats version 1.0 i get the following output 20:01_root@siloneu:/usr/local/bin# zfs-stats -A [...] Illegal division by zero at /usr/local/bin/zfs-stats line 385. This is easily fixed by the attached patch, which employs the same catch as has been for $prefetch_data_perc. Although i don't know if this logic is right in this place. >How-To-Repeat: Install sysutils/zfs-stat, invoke with "-A" flag and have no load? thus $demand_data_total be zero. >Fix: --- zfs-stats.orig 2011-07-13 19:46:41.000000000 +0200 +++ zfs-stats 2011-07-13 20:11:45.000000000 +0200 @@ -382,7 +382,10 @@ if ($showarc != 0) { } my $demand_data_total = ($demand_data_hits + $demand_data_misses); - my $demand_data_perc = 100*($demand_data_hits / $demand_data_total); + my $demand_data_perc = "00"; + if ($demand_data_total > 0) { + $demand_data_perc = 100*($demand_data_hits / $demand_data_total); + } print "ARC Efficiency:\n"; printf("\tCache Access Total:\t\t\t%d\n", >Release-Note: >Audit-Trail: >Unformatted: