From owner-freebsd-geom@FreeBSD.ORG  Fri Mar 26 03:35:28 2004
Return-Path: <owner-freebsd-geom@FreeBSD.ORG>
Delivered-To: freebsd-geom@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8555F16A4CE; Fri, 26 Mar 2004 03:35:28 -0800 (PST)
Received: from darkness.comp.waw.pl (unknown [195.117.238.236])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 31AE543D49; Fri, 26 Mar 2004 03:35:28 -0800 (PST)
	(envelope-from pjd@darkness.comp.waw.pl)
Received: by darkness.comp.waw.pl (Postfix, from userid 1009)
	id 69E17ACADB; Fri, 26 Mar 2004 12:35:27 +0100 (CET)
Date: Fri, 26 Mar 2004 12:35:27 +0100
From: Pawel Jakub Dawidek <pjd@FreeBSD.org>
To: Poul-Henning Kamp <phk@phk.freebsd.dk>
Message-ID: <20040326113527.GF8930@darkness.comp.waw.pl>
References: <20040326110046.GD8930@darkness.comp.waw.pl>
	<1621.1080299892@critter.freebsd.dk>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="zMXjX+MeVRpM4hLZ"
Content-Disposition: inline
In-Reply-To: <1621.1080299892@critter.freebsd.dk>
User-Agent: Mutt/1.4.2i
X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc
X-OS: FreeBSD 5.2.1-RC2 i386
cc: geom@FreeBSD.org
cc: Lukas Ertl <le@FreeBSD.org>
Subject: Re: Problem with g_unload_class()
X-BeenThere: freebsd-geom@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: GEOM-specific discussions and implementations
	<freebsd-geom.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-geom>
List-Post: <mailto:freebsd-geom@freebsd.org>
List-Help: <mailto:freebsd-geom-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Mar 2004 11:35:28 -0000


--zMXjX+MeVRpM4hLZ
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 26, 2004 at 12:18:12PM +0100, Poul-Henning Kamp wrote:
+> But that is exactly the "silly" scenario I would like to avoid: Now
+> you have removed some of the geom instances an you have nuked the
+> taste and config function and then you give up and leave the class
+> still loaded.

BTW. Why can't we nuke config and taste here:

	if (error =3D=3D 0) {
		mp->taste =3D NULL;
		mp->config =3D NULL;
		if (mp->fini !=3D NULL)
			mp->fini(mp);
		LIST_REMOVE(mp, class);
	}

Those events are called from the event queue, aren't they?
So this should be safe.

--=20
Pawel Jakub Dawidek                       http://www.FreeBSD.org
pjd@FreeBSD.org                           http://garage.freebsd.pl
FreeBSD committer                         Am I Evil? Yes, I Am!

--zMXjX+MeVRpM4hLZ
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQFAZBV/ForvXbEpPzQRApwmAJ9OGTANOGqa1kNIy+IuvuE/50AmSACg3NTM
bhsWHc74p1aHUPgOCLqou3E=
=n0NP
-----END PGP SIGNATURE-----

--zMXjX+MeVRpM4hLZ--