From owner-freebsd-net@FreeBSD.ORG  Wed Jun 17 19:17:52 2015
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 1712416D
 for <freebsd-net@hub.freebsd.org>; Wed, 17 Jun 2015 19:17:52 +0000 (UTC)
 (envelope-from rysto32@gmail.com)
Received: from mail-ie0-x22c.google.com (mail-ie0-x22c.google.com
 [IPv6:2607:f8b0:4001:c03::22c])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id CFFA4E57
 for <freebsd-net@freebsd.org>; Wed, 17 Jun 2015 19:17:51 +0000 (UTC)
 (envelope-from rysto32@gmail.com)
Received: by iebmu5 with SMTP id mu5so40562609ieb.1
 for <freebsd-net@freebsd.org>; Wed, 17 Jun 2015 12:17:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=z69sUwPH3nVCHsNurhEioEE1rQDhIYYT1J3j+teKWRQ=;
 b=G9yIjbiPEGPGHP9vxP/xfc6NwkEGgigsBBmQ9/15ntLlsWxbj2n+anAjZF6q+5yT8U
 W+jOh5Q0SL1lE/N6cP+6UkhiBjU0mSSU8MeGQdn+D7n64WP4+5zqPh7629/xC+gHh3Rp
 F8opoYxOmnzz58kBnEzRyzVKieIT4A5mD1v+/lZJxXkQWe93ReyaISTrWCv5cW4ELzan
 9lASWM9AnLRbDEzSx1KiufZ4Q6IaXbfgho8PF7S7OMIIJwuTQ865ZSZ72hAaUIuKWWn/
 o0jUTo/M/nxyyXxCkuMkIwOM8XPHrciriPFxEqOqVlICRo1uIE74w8I4WVHh66k1/mH2
 VP5A==
MIME-Version: 1.0
X-Received: by 10.42.119.83 with SMTP id a19mr1919731icr.83.1434568671115;
 Wed, 17 Jun 2015 12:17:51 -0700 (PDT)
Received: by 10.107.165.16 with HTTP; Wed, 17 Jun 2015 12:17:51 -0700 (PDT)
In-Reply-To: <CA+NkpghE=Y2aWJ3pJorR7+C75wVL=SMdiCx_ufmKRUx7_cvwHw@mail.gmail.com>
References: <CA+NkpghE=Y2aWJ3pJorR7+C75wVL=SMdiCx_ufmKRUx7_cvwHw@mail.gmail.com>
Date: Wed, 17 Jun 2015 15:17:51 -0400
Message-ID: <CAFMmRNwF+gcGNDw47JO06EBAr_DAgS7oLUp4h6=o88pZO9QW2A@mail.gmail.com>
Subject: Re: Reg Intel Fortville IXL driver on 11-CURRENT
From: Ryan Stone <rysto32@gmail.com>
To: Lakshmi Narasimhan Sundararajan <lakshmi.n@msystechnologies.com>
Cc: freebsd-net <freebsd-net@freebsd.org>, "Tallam, Sreen" <sreen@panasas.com>,
 "Kloss, Joe" <jkloss@panasas.com>, "Pokala, Ravi" <rpokala@panasas.com>, 
 "Lewis, Fred" <flewis@panasas.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.20
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Jun 2015 19:17:52 -0000

On Wed, Jun 17, 2015 at 7:00 AM, Lakshmi Narasimhan Sundararajan <
lakshmi.n@msystechnologies.com> wrote:

> [lakshmis@mau-bsd-10a ~/fortville/hol/sys/dev/ixl]$ diff -c5pt ixl_txrx.c
> ixl_txrx.c.mod
> *** ixl_txrx.c Fri Jun 12 06:56:51 2015
> --- ixl_txrx.c.mod Fri Jun 12 06:56:33 2015
> *************** ixl_mq_start(struct ifnet *ifp, struct m
> *** 96,112 ****
> --- 96,115 ----
>                   } else
>   #endif
>                           i = m->m_pkthdr.flowid % vsi->num_queues;
>           } else
>                   i = curcpu % vsi->num_queues;
> +
> + #if 0
>           /*
>           ** This may not be perfect, but until something
>           ** better comes along it will keep from scheduling
>           ** on stalled queues.
>           */
>           if (((1 << i) & vsi->active_queues) == 0)
>                   i = ffsl(vsi->active_queues);
> + #endif
>
>           que = &vsi->queues[i];
>           txr = &que->txr;
>
>           err = drbr_enqueue(ifp, txr->br, m);
> [lakshmis@mau-bsd-10a ~/fortville/hol/sys/dev/ixl]$
>

My understanding is that this code is intended to be triggered as a last
resort.  If that code is firing regularly then the driver is not correctly
tracking which queues are alive in the "active_queues" bitmask.