From owner-svn-ports-head@freebsd.org Thu Dec 7 12:04:06 2017 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E3420E84E6C; Thu, 7 Dec 2017 12:04:06 +0000 (UTC) (envelope-from gahr@FreeBSD.org) Received: from mail.ptrcrt.ch (gahr.cloud.tilaa.com [IPv6:2a02:2770:8:0:21a:4aff:fe7e:c6be]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0E644282C; Thu, 7 Dec 2017 12:04:05 +0000 (UTC) (envelope-from gahr@FreeBSD.org) Received: from ptrcrt.ch (mail.ptrcrt.ch [192.168.1.1]) by mail.ptrcrt.ch (OpenSMTPD) with ESMTPS id 8250ea2e TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Thu, 7 Dec 2017 12:04:03 +0000 (UTC) Date: Thu, 7 Dec 2017 12:04:03 +0000 From: Pietro Cerutti To: Joe Marcus Clarke Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r447981 - in head/ports-mgmt/portlint: . src Message-ID: <20171207120403.7wafl635xclviqsr@ptrcrt.ch> Reply-To: Pietro Cerutti References: <201708151243.v7FChEAF043279@repo.freebsd.org> <20171207080421.qijzbigqkbfbezqe@ptrcrt.ch> <20171207081055.xtssqrp5okethfeu@ptrcrt.ch> <20171207081308.5bxt5mp2o5wr33un@ptrcrt.ch> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tqowif75f5g2v4d3" Content-Disposition: inline In-Reply-To: X-PGP-Key: fp="DA6D E106 A5B8 54B8 5DD8 6D49 ADD0 D38E A192 089E"; id="0xA192089E"; get=; get=; get=; get= OpenPGP: id=A192089E; url=https://gahr.ch/pgp/0xADD0D38EA192089E.txt; url=https://keybase.io/gahr/key.asc User-Agent: NeoMutt/20171027-245-1d0c7d X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 12:04:07 -0000 --tqowif75f5g2v4d3 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Dec 7 17 06:22, Joe Marcus Clarke wrote: > On 12/7/17 03:13, Pietro Cerutti wrote: > > On Dec 7 17 08:10, Pietro Cerutti wrote: > >> On Dec 7 17 08:04, Pietro Cerutti wrote: > >>> On Aug 15 17 12:43, Joe Marcus Clarke wrote: > >>>> Author: marcus > >>>> Date: Tue Aug 15 12:43:14 2017 > >>>> New Revision: 447981 > >>>> URL: https://svnweb.freebsd.org/changeset/ports/447981 > >>>> > >>>> Log: > >>>> Update to 2.17.12. > >>> > >>>> @@ -3400,6 +3437,11 @@ sub abspathname { > >>>> =20 > >>>> if ($pre =3D~ /MASTER_SITE_SUBDIR/) { > >>>> # MASTER_SITE_SUBDIR lines are ok. > >>>> + $i =3D ''; > >>>> + } > >>>> + if ($s =3D~ /\$\{[^}]*?$i/) { > >>>> + # If we're inside a make variable, we probably do not have > >>>> + # an absolute path. > >>>> $i =3D ''; > >>>> } > >>>> } > >>>> > >>> > >>> Unmatched ) in regex; marked by <-- HERE in m/\$\{[^}]*?/dev/null 2>&= 1 )=20 > >>> <-- HERE / at /usr/local/bin/portlint line 3443. > >>> > >>> I think the ? doesn't belong there. > >> > >> No, my analysis was wrong. It's about the contents of the $i variable.= =20 > >> Here's why. You can reproduce by portlint -AC in net-im/openfire. > >> > >> i is /var/log/openfire > >> WARN: Makefile: possible use of absolute pathname "/var/log/openfire". > >> > >> i is /var/db/openfire > >> WARN: Makefile: possible use of absolute pathname "/var/db/openfire". > >> > >> i is /dev/null 2>&1 ) > >> Unmatched ) in regex; marked by <-- HERE in m/\$\{[^}]*?/dev/null 2>&1= )=20 > >> <-- HERE / at /usr/local/bin/portlint line 3444. > >=20 > > Surrounding $i with \Q and \E in the regex solves the problem. > >=20 > >=20 >=20 > Thanks. I'll commit a quick fix ahead of the next release. Thanks. I still don't understand why you have both * and ? as=20 quantifiers, though. --=20 Pietro Cerutti The FreeBSD Project gahr@FreeBSD.org --tqowif75f5g2v4d3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJiBAABCgBMFiEE2m3hBqW4VLhd2G1JrdDTjqGSCJ4FAlopLi4uFIAAAAAAFQAQ cGthLWFkZHJlc3NAZ251cGcub3JnZ2FockBGcmVlQlNELm9yZwAKCRCt0NOOoZII ngxTD/9Cugb4xyMyD2EY4hHrdC9v2OGwCWckMl2/SJXQnyYBqIqJpQslRYH/8f25 UN3AxIhn6ciVESqG2kDagIZckHFSBXh5neJWnngZXbydUmsGI2w1bN4a9yFbirSH XjbDd2GFiQFm2xrSFxuDEVleLgB8PMQ7LtEhyQ4B9m0Q/mAf7Fmz3F8jv1r8yccI MViB38ZlUKWrWoKLS0vSstDOD/tZYibW0Bq8VzTfyRqLbAlQnyreXaPngxzZmFYn CZxSvj5yNBOXwPelf8fxw/97o34+/+qA+0m68W8LFbk5QvA0rGt+/i8zx27nLfDN kEm/kSfS8snr+pIjAvTsF8zmOga/xxUchBaQd/GIOffKyGl1Y/o0Iq0PN1UO1q/u oYbonOVM1Yz8NaTxWuE6XBIkvWqQnjpUdKCT/PEn22DQV1EUuimMlbSNySvIWpRO xNf28n3MbBJPvh57v445dh30MO2RX/ceUUDwN5xotFdeBNZZkfH3BaqDBGQvt1x3 jPKl10wsCEvmr69+VUdhlDAiVMBmQcC91moXr6j94SMKgunOQ9rxPSt0AOb9rRn0 XukSD22KsCdtdg1zdPmPPe4pS2nl1McJs26aMSzrUM+ZiwkSgsvBBBlyMaQXtStk UB6LzmkeWHEMf70puLyKgyKhZsaPUwg56EsdyM4k16PfcvZGzg== =vW8C -----END PGP SIGNATURE----- --tqowif75f5g2v4d3--