From owner-cvs-all Sat Jul 28 11:14:56 2001 Delivered-To: cvs-all@freebsd.org Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.208.78.105]) by hub.freebsd.org (Postfix) with ESMTP id 38D7B37B401; Sat, 28 Jul 2001 11:14:52 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.11.4/8.11.4) id f6SIEpH11537; Sat, 28 Jul 2001 11:14:51 -0700 (PDT) (envelope-from sgk) Date: Sat, 28 Jul 2001 11:14:51 -0700 From: Steve Kargl To: "David O'Brien" Cc: Kris Kennaway , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.sbin/pkg_install/add main.c src/usr.sbin/pkg_install/lib str.c Message-ID: <20010728111451.A11416@troutmask.apl.washington.edu> References: <200107280159.f6S1xw810069@freefall.freebsd.org> <20010727204037.A58795@xor.obsecurity.org> <20010727214454.A96927@dragon.nuxi.com> <20010727222312.A3093@troutmask.apl.washington.edu> <20010728104814.A11239@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010728104814.A11239@dragon.nuxi.com>; from obrien@FreeBSD.ORG on Sat, Jul 28, 2001 at 10:48:14AM -0700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, Jul 28, 2001 at 10:48:14AM -0700, David O'Brien wrote: > On Fri, Jul 27, 2001 at 10:23:12PM -0700, Steve Kargl wrote: > > > And, this commit seems to be a slap in the face of Kris. > > Why?? I saw inefficient coding done in the name of efficiency. The last > time I made such a commit I was asked to justify it. So this time, I > justified it in the commit message. Would you prefer I didn't give a > shit? Read the commit log! It is dripping with sarcasm. Your code may be better than what it replaced. But, I'm sure you could have written a more *professional* commit message without implying the previous code must have been written by some moron. -- Steve To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message