From owner-svn-src-all@FreeBSD.ORG Sun Apr 13 23:23:27 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 76EED491 for ; Sun, 13 Apr 2014 23:23:27 +0000 (UTC) Received: from mail-pd0-f178.google.com (mail-pd0-f178.google.com [209.85.192.178]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 450F51262 for ; Sun, 13 Apr 2014 23:23:26 +0000 (UTC) Received: by mail-pd0-f178.google.com with SMTP id x10so7388629pdj.37 for ; Sun, 13 Apr 2014 16:23:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=wkPtrMe955AnqW1qOFceyLLskY+dUDATcTJlhmrWhsY=; b=cheKZKb/d5UKmpt8hZLb/pT/xzIBv+hH4UnD4DlkHE1dtOnv07yfDbY/MXc3qmXtCh owEaE8zdXPhGvQKB8+s2wAaLdxSuwuC1iObOWZLhTwKpIE2gDnIabUDldpul8BTatlRR 2KTwnBfb0BhHcE2InRvL7/tbq4lKxpyVsWzjA6u8DA2FSN9rMZ4BsNNTdedS+QTKP3Z8 j/Yzod1ej6kmn3x7Ay4PwbSEcgDCVR3hMGh3LkS7LkuITexDHXlX6IxLe5a6hz1XzNVc +EcnB8+h78GqW9/khAYXjzBQach0gnLVhtGgeFIbtIZxW+1cuQ3tUe27yGsjq3crIU2o kxjw== X-Gm-Message-State: ALoCoQkxqHSZsPj41ivKuOtTtoMML2YVm4+UEAm5rE610HIOBS7ev+IiLe0LO/QeE5p4LDOfl6hM X-Received: by 10.66.254.234 with SMTP id al10mr51494pad.137.1397431399526; Sun, 13 Apr 2014 16:23:19 -0700 (PDT) Received: from macintosh-c42c033c0b73.corp.netflix.com (dc1-prod.netflix.com. [69.53.236.251]) by mx.google.com with ESMTPSA id ja8sm29948212pbd.3.2014.04.13.16.23.18 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 13 Apr 2014 16:23:18 -0700 (PDT) Sender: Warner Losh Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\)) Subject: Re: svn commit: r264402 - in head/share: examples/etc man/man5 mk From: Warner Losh In-Reply-To: Date: Sun, 13 Apr 2014 17:23:16 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201404130522.s3D5MRXc053006@svn.freebsd.org> <9FB7142E-A0A0-41AF-BEFC-9306AE701B3F@bsdimp.com> To: Mark Johnston X-Mailer: Apple Mail (2.1874) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers , Warner Losh X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Apr 2014 23:23:27 -0000 Thanks Mark. I=92ve recreated both the problem, and the solution. I=92ve reverted the = offending change until I have time to make sure my fix actually works in = a variety of situations. The tree should be good to go now. Warner On Apr 13, 2014, at 5:10 PM, Mark Johnston wrote: > On Sun, Apr 13, 2014 at 4:57 PM, Warner Losh wrote: >>=20 >> Are you sure it is this exact commit? >=20 > It seems to be. I tried a >=20 > # make SRCCONF=3D/dev/null MAKECONF=3D/dev/null buildworld = installworld >=20 > with and without this commit reverted, and installworld completed > successfully when the change was reverted. >=20 >>=20 >> Do you have anything in your /etc/make.conf or /etc/src.conf file? >=20 > Yes, but clearing them doesn't fix the problem. >=20 >>=20 >> Can you send me your full install world output? >=20 > Attached. >=20 >>=20 >> I=92ll see if I can reproduce it myself. >>=20 >> Warner >>=20 >> On Apr 13, 2014, at 1:32 PM, Mark Johnston wrote: >>=20 >>> On Sun, Apr 13, 2014 at 1:22 AM, Warner Losh = wrote: >>>> Author: imp >>>> Date: Sun Apr 13 05:22:26 2014 >>>> New Revision: 264402 >>>> URL: http://svnweb.freebsd.org/changeset/base/264402 >>>>=20 >>>> Log: >>>> Convert NO_MANCOMPRESS to normal convention. >>>=20 >>> This breaks installworld for me with >>>=20 >>> ... >>> install -o root -g wheel -m 444 zh_CN.GB2312.cat >>> /usr/share/nls/zh_CN.GB2312/libc.cat >>> install -o root -g wheel -m 444 zh_CN.UTF-8.cat >>> /usr/share/nls/zh_CN.UTF-8/libc.cat >>> install -o root -g wheel -m 444 btree.3.gz /usr/share/man/man3 >>> install: btree.3.gz: No such file or directory >>> *** Error code 71 >>> ... >>>=20 >>>>=20 >>>> Modified: >>>> head/share/examples/etc/make.conf >>>> head/share/man/man5/make.conf.5 >>>> head/share/mk/bsd.man.mk >>>> head/share/mk/bsd.own.mk >>>>=20 >>>> [snip] >>>>=20 >>>> Modified: head/share/mk/bsd.man.mk >>>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>>> --- head/share/mk/bsd.man.mk Sun Apr 13 05:22:22 2014 = (r264401) >>>> +++ head/share/mk/bsd.man.mk Sun Apr 13 05:22:26 2014 = (r264402) >>>> @@ -30,9 +30,6 @@ >>>> # second, and there may be multiple pairs. The files >>>> # are hard-linked. >>>> # >>>> -# NO_MANCOMPRESS If you do not want unformatted manual pages = to be >>>> -# compressed when they are installed. [not set] >>>> -# >>>> # NO_MLINKS If you do not want install manual page links. [not = set] >>>> # >>>> # MANFILTER command to pipe the raw man page through before = compressing >>>> @@ -77,10 +74,10 @@ MAN+=3D ${MAN${__sect}} >>>> _manpages: >>>> all-man: _manpages >>>>=20 >>>> -.if defined(NO_MANCOMPRESS) >>>> +.if ${MK_MANCOMPRESS} !=3D "no" >>>>=20 >>>> # Make special arrangements to filter to a temporary file at build = time >>>> -# for NO_MANCOMPRESS. >>>> +# for MK_MANCOMPRESS =3D=3D no. >>>> .if defined(MANFILTER) >>>> FILTEXTENSION=3D .filt >>>> .else >>>> @@ -162,7 +159,7 @@ maninstall: _maninstall >>>> _maninstall: >>>> .if defined(MAN) && !empty(MAN) >>>> _maninstall: ${MAN} >>>> -.if defined(NO_MANCOMPRESS) >>>> +.if ${MK_MANCOMPRESS} =3D=3D "no" >>>=20 >>> Changing this line to ".if ${MK_MANCOMPRESS} !=3D "no" seems to fix = the problem. >>>=20 >>>> .if defined(MANFILTER) >>>> [snip] >>=20 >