From owner-svn-src-all@FreeBSD.ORG Thu Oct 16 23:01:08 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 864F983C; Thu, 16 Oct 2014 23:01:08 +0000 (UTC) Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.59.238]) by mx1.freebsd.org (Postfix) with ESMTP id 42A3AD24; Thu, 16 Oct 2014 23:01:07 +0000 (UTC) Received: by onelab2.iet.unipi.it (Postfix, from userid 275) id 4A1617300A; Fri, 17 Oct 2014 01:04:46 +0200 (CEST) Date: Fri, 17 Oct 2014 01:04:46 +0200 From: Luigi Rizzo To: Gleb Smirnoff Subject: Re: svn commit: r272906 - in head/sys: conf libkern netpfil/pf sys Message-ID: <20141016230446.GA11048@onelab2.iet.unipi.it> References: <201410101926.s9AJQRY1049602@svn.freebsd.org> <20141015030455.GC73266@FreeBSD.org> <20141015041418.GE73266@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141015041418.GE73266@FreeBSD.org> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: src-committers , Ed Maste , svn-src-all , "George V. Neville-Neil" , Olivier Cochard-Labb? , svn-src-head X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Oct 2014 23:01:08 -0000 On Wed, Oct 15, 2014 at 08:14:19AM +0400, Gleb Smirnoff wrote: > On Tue, Oct 14, 2014 at 11:38:23PM -0400, Ed Maste wrote: > E> On 14 October 2014 23:04, Gleb Smirnoff wrote: > E> > > E> > Look at results at the end of email. Guess what -j and -m mean. I > E> > want either proving me doing the test wrong, or backing the change > E> > out ASAP. > E> > E> It looks like there is indeed an error in the test: > E> > E> > h = murmur3_aligned_32((uint32_t *)&key[i], > E> > sizeof(struct pf_state_key_cmp)/sizeof(uint32_t), > E> > E> murmur3's size argument is bytes, not uint32_ts, so the test is only > E> hashing the first 1/4 of the keys. > > Thanks a lot, Ed. I rerun the tests. Results are fine. Distribution > is equal (plots attached). > > Murmur is 9% +/- 1.5% faster. Sorry for noise. is that 9% on the hash alone ? If so it is surprising that you could see any change on pf's throughput. In my very non-scientific tests with VALE, doing two hashes on the MAC address would result in 17 Mpps vs 20 Mpps when no hashes were done. The difference is about 8ns, which is totally in the noise at 2 Mpps or less. cheers luigi > x jenkins-time > + murmur-time > +------------------------------------------------------------------------------+ > | ++ x | > | ++ xx | > |+ +++ xx | > |+++++ + + xx x x x x x| > | |_A_| |_____M______A_____________| | > +------------------------------------------------------------------------------+ > N Min Max Median Avg Stddev > x 12 8147243 8851519 8173132 8296753.8 235815.07 > + 15 7502767 7655925 7547376 7551089.5 39524.149 > Difference at 95.0% confidence > -745664 +/- 127010 > -8.98742% +/- 1.53084% > (Student's t, pooled s = 159194) > > -- > Totus tuus, Glebius.