From owner-svn-src-all@FreeBSD.ORG Fri Oct 25 09:35:22 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 7DBF0DF; Fri, 25 Oct 2013 09:35:22 +0000 (UTC) (envelope-from dimitry@andric.com) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 39BCE2960; Fri, 25 Oct 2013 09:35:21 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7::808:bfde:4b8f:68a7] (unknown [IPv6:2001:7b8:3a7:0:808:bfde:4b8f:68a7]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 3451C5C43; Fri, 25 Oct 2013 11:35:13 +0200 (CEST) Content-Type: multipart/signed; boundary="Apple-Mail=_6F0E808E-615A-417A-9CDC-25841B1EAC9E"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 7.0 \(1816\)) Subject: Re: svn commit: r257109 - head/contrib/llvm/tools/clang/tools/driver From: Dimitry Andric In-Reply-To: <201310250909.r9P990nk083926@svn.freebsd.org> Date: Fri, 25 Oct 2013 11:34:50 +0200 Message-Id: References: <201310250909.r9P990nk083926@svn.freebsd.org> To: Steven Hartland X-Mailer: Apple Mail (2.1816) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Oct 2013 09:35:22 -0000 --Apple-Mail=_6F0E808E-615A-417A-9CDC-25841B1EAC9E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On 25 Oct 2013, at 11:09, Steven Hartland wrote: > Author: smh > Date: Fri Oct 25 09:09:00 2013 > New Revision: 257109 > URL: http://svnweb.freebsd.org/changeset/base/257109 >=20 > Log: > Add clang-CC and CC to list of hints allowing clang to identify its = operating > mode as c++ instead of defaulting to c for the binary names CC and = clang-CC. >=20 > This fixes builds that use cmake, which automatically sets CXX to > /usr/bin/CC by default. Huh, I=92ve never seen that behavior with cmake? At least, not with any fairly recent version...=20 Anyway, I do not really agree with this change, and I would rather just get rid of the /usr/bin/CC link instead. Build scripts and Makefiles should use "c++" instead, which is the standard name for a C++ compiler. Note that you also introduce yet another change from upstream... :-/ -Dimitry --Apple-Mail=_6F0E808E-615A-417A-9CDC-25841B1EAC9E Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iEYEARECAAYFAlJqO0kACgkQsF6jCi4glqNcaQCgqHrze0j8xFBcWuwDPxoldayE PC0AnRrB3iYVY6yzCs9mku0+uYjSjcf/ =oKuE -----END PGP SIGNATURE----- --Apple-Mail=_6F0E808E-615A-417A-9CDC-25841B1EAC9E--