From owner-svn-ports-head@freebsd.org Wed May 22 21:04:57 2019 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DB74D15B76F8; Wed, 22 May 2019 21:04:57 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7F94D6A64F; Wed, 22 May 2019 21:04:57 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 6B65A1D058; Wed, 22 May 2019 21:04:57 +0000 (UTC) Date: Wed, 22 May 2019 21:04:57 +0000 From: Alexey Dokuchaev To: Carlo Strub Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r502285 - head/www/otrs Message-ID: <20190522210457.GA33127@FreeBSD.org> References: <201905222049.x4MKn3lU076208@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201905222049.x4MKn3lU076208@repo.freebsd.org> User-Agent: Mutt/1.11.4 (2019-03-13) X-Rspamd-Queue-Id: 7F94D6A64F X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.94)[-0.941,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 May 2019 21:04:58 -0000 On Wed, May 22, 2019 at 08:49:03PM +0000, Carlo Strub wrote: > New Revision: 502285 > URL: https://svnweb.freebsd.org/changeset/ports/502285 > > Log: > Add missing dependendies. This commit message sucks. Not just it does not accurately reflect the changes made -- it does not explain the rationale behind them. > Modified: head/www/otrs/Makefile > @@ -56,7 +60,7 @@ SHEBANG_FILES= bin/cgi-bin/*.pl bin/cgi-bin/app.psgi b > scripts/tools/*.pl scripts/*.pl > > OPTIONS_DEFINE= MYSQL PGSQL REPORTS SMTP POP3 IMAP LDAP PDF \ > - GNUPG APACHE SSL XML > + GNUPG APACHE SSL > OPTIONS_DEFAULT= MYSQL REPORTS SMTP POP3 IMAP PDF ASPELL APACHE \ > SSL > OPTIONS_RADIO= SPELL > @@ -125,10 +129,6 @@ ISPELL_RUN_DEPENDS= ispell:textproc/aspell-ispell > ASPELL_RUN_DEPENDS= aspell:textproc/aspell > > GNUPG_RUN_DEPENDS= gpg:security/gnupg1 > - > -XML_RUN_DEPENDS= p5-XML-Parser>=0:textproc/p5-XML-Parser \ > - p5-XML-LibXML>=0:textproc/p5-XML-LibXML \ > - p5-XML-LibXSLT>=0:textproc/p5-XML-LibXSLT So basically you've removed the XML option, rather than making it on by default. Why? ./danfe