From owner-freebsd-stable@FreeBSD.ORG Tue Nov 26 00:18:23 2013 Return-Path: Delivered-To: freebsd-stable@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 321DB2D3; Tue, 26 Nov 2013 00:18:23 +0000 (UTC) Received: from mx.ams1.isc.org (mx.ams1.isc.org [IPv6:2001:500:60::65]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id E6A002443; Tue, 26 Nov 2013 00:18:22 +0000 (UTC) Received: from zmx1.isc.org (zmx1.isc.org [149.20.0.20]) by mx.ams1.isc.org (Postfix) with ESMTP id BD41F2383A8; Tue, 26 Nov 2013 00:18:07 +0000 (UTC) (envelope-from marka@isc.org) Received: from zmx1.isc.org (localhost [127.0.0.1]) by zmx1.isc.org (Postfix) with ESMTP id 783DF160436; Tue, 26 Nov 2013 00:25:19 +0000 (UTC) Received: from rock.dv.isc.org (c211-30-183-50.carlnfd1.nsw.optusnet.com.au [211.30.183.50]) by zmx1.isc.org (Postfix) with ESMTPSA id 481E116042E; Tue, 26 Nov 2013 00:25:19 +0000 (UTC) Received: from rock.dv.isc.org (localhost [IPv6:::1]) by rock.dv.isc.org (Postfix) with ESMTP id 27951AD3DBF; Tue, 26 Nov 2013 11:18:06 +1100 (EST) To: Ian Lepore From: Mark Andrews References: <52911993.8010108@ipfw.ru> <529259DE.2040701@FreeBSD.org> <20131125152238.S78756@sola.nimnet.asn.au> <1385391778.1220.4.camel@revolution.hippie.lan> Subject: Re: ipfw table add problem In-reply-to: Your message of "Mon, 25 Nov 2013 08:02:58 -0700." <1385391778.1220.4.camel@revolution.hippie.lan> Date: Tue, 26 Nov 2013 11:18:05 +1100 Message-Id: <20131126001806.27951AD3DBF@rock.dv.isc.org> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on mx.ams1.isc.org Cc: "Alexander V. Chernikov" , Ian Smith , freebsd-ipfw , freebsd-stable , Luigi Rizzo , =?ISO-8859-1?Q?=D6zkan?= KIRIK X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Nov 2013 00:18:23 -0000 In message <1385391778.1220.4.camel@revolution.hippie.lan>, Ian Lepore writes: > On Mon, 2013-11-25 at 15:30 +1100, Ian Smith wrote: > > On Sun, 24 Nov 2013 23:56:14 +0400, Alexander V. Chernikov wrote: > > > On 24.11.2013 19:43, =D6zkan KIRIK wrote: > > > > Hi, > > > > = > > > > > I tested patch. This patch solves, ipfw table 1 add 4899 > > > Ok. So I'll commit this fix soon. > > > > = > > > > > But, ipfw table 1 add 10.2.3.01 works incorrectly. > > > > output is below. > > > > # ./ipfw table 1 flush > > > > # ./ipfw table 1 add 10.2.3.01 > > > inet_pton() does not recognize this as valid IPv4 address, so it is > > > treated as usigned unteger key. It looks like this behavior is mention= > ed > > > in STANDARDS section. > > > > # ./ipfw table 1 list > > > > 0.0.0.10/32 0 > > = > > > I'm wondering if "so don't do that" is really sufficient to deal with = > > > this? If it's not recognised as a valid address, shouldn't it fail to = > > > add anything, with a complaint? I don't see how a string containing = > > > dots can be seen as a valid unsigned integer? > > It's still not clear to me that inet_pton() is doing the right thing. > Per the rfc cited earlier in the thread, it's not supposed to interpret > the digits as octal or hex -- they are specifically declared to be > decimal numbers. There's nothing invalid about "01" as a decimal > number. The fact that many of us have a C-programming background and > tend to think of leading-zero as implying octal doesn't change that. But it does result in unexpected results when there is code that does treat 070 as 56 not 70. Rejecting ambigious input is a good thing. Part of what inet_pton() was trying to do was to get rid of the ambiguity in address inputs by tightening up the specification. 10.2.3.70 is not ambigious 10.2.3.070 is ambigious Mark > -- Ian > > > > > _______________________________________________ > freebsd-stable@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-stable > To unsubscribe, send any mail to "freebsd-stable-unsubscribe@freebsd.org" -- Mark Andrews, ISC 1 Seymour St., Dundas Valley, NSW 2117, Australia PHONE: +61 2 9871 4742 INTERNET: marka@isc.org