From owner-svn-src-all@freebsd.org Wed Mar 14 14:21:24 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CBCE7F54E51 for ; Wed, 14 Mar 2018 14:21:24 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from pmta2.delivery6.ore.mailhop.org (pmta2.delivery6.ore.mailhop.org [54.200.129.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 52634829E0 for ; Wed, 14 Mar 2018 14:21:23 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: d788596d-2792-11e8-b951-f99fef315fd9 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound2.ore.mailhop.org (Halon) with ESMTPSA id d788596d-2792-11e8-b951-f99fef315fd9; Wed, 14 Mar 2018 14:20:27 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id w2EELKCr022775; Wed, 14 Mar 2018 08:21:20 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1521037280.84937.285.camel@freebsd.org> Subject: Re: svn commit: r330925 - in head/sys: conf powerpc/powernv From: Ian Lepore To: Wojciech Macek , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Wed, 14 Mar 2018 08:21:20 -0600 In-Reply-To: <201803140920.w2E9K3mn019118@repo.freebsd.org> References: <201803140920.w2E9K3mn019118@repo.freebsd.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Mar 2018 14:21:25 -0000 On Wed, 2018-03-14 at 09:20 +0000, Wojciech Macek wrote: > Author: wma > Date: Wed Mar 14 09:20:03 2018 > New Revision: 330925 > URL: https://svnweb.freebsd.org/changeset/base/330925 > > Log: >   PowerNV: Fix I2C to compile if FDT is disabled >    >   Submitted by:          Wojciech Macek >   Obtained from:         Semihalf >   Sponsored by:          IBM, QCM Technologies > This seems to be a nonsensical commit.  What's the point of compiling in a driver which is hard-coded to return failure from the probe and attach routines?  The pre-change code seemed more correct: the driver can only possibly work if FDT/OFW data is available, so only compile it in when that option is in effect. -- Ian