From owner-freebsd-ports@FreeBSD.ORG Tue Sep 26 07:57:23 2006 Return-Path: X-Original-To: ports@FreeBSD.org Delivered-To: freebsd-ports@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D405916A412; Tue, 26 Sep 2006 07:57:23 +0000 (UTC) (envelope-from erwin@mail.droso.net) Received: from mail.droso.net (koala.droso.net [193.88.12.38]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6116A43D5D; Tue, 26 Sep 2006 07:57:21 +0000 (GMT) (envelope-from erwin@mail.droso.net) Received: by mail.droso.net (Postfix, from userid 1001) id 0E5CF22FE4; Tue, 26 Sep 2006 09:57:18 +0200 (CEST) Date: Tue, 26 Sep 2006 09:57:18 +0200 From: Erwin Lansing To: ports@FreeBSD.org Message-ID: <20060926075717.GN10626@droso.net> Mail-Followup-To: ports@FreeBSD.org, ale@FreeBSD.org, leeym@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Q0rSlbzrZN6k9QnT" Content-Disposition: inline X-Operating-System: FreeBSD/i386 5.4-RELEASE User-Agent: Mutt/1.5.13 (2006-08-11) Cc: leeym@FreeBSD.org, ale@FreeBSD.org Subject: PHP_VER magic too smart for its own good X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Sep 2006 07:57:23 -0000 --Q0rSlbzrZN6k9QnT Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable After leeym added graphics/php4-imlib2 slave port to php5-imlib2, I've been getting a warning in INDEX and an error in the modules check script. This is due to bsd.php.mk and the slave port both trying to accomplish the same result via different ways, and thus outsmarting eachother when php4 is installed on a system. The problem is: graphics/php4-imlib2> make -V PKGNAME php4-imlib2-0.1.00 graphics/php5-imlib2> make -V PKGNAME php4-imlib2-0.1.00 which of course is completely bogus. We can't have two packages with the same names in ports. The reason: graphics/php5-imlib2> make -V DEFAULT_PHP_VER 5 graphics/php5-imlib2> make -V PHP_VER 4 Confused yet? bsd.php.mk does a runtime check to set PHP_VER from php-config and uses this to build the port, even though the php5 port is chosen, a php4 binary is built (at least, I hope so, the PKGNAME is php4). Instead of this confusing magic to install php4 from at php5 port, I prefer that php5-imlib2 gets marked IGNORE when PHP_VER is 4, both to not confuse our users and to unbreak the INDEX/modules. -erwin --=20 Erwin Lansing http://droso.org Security is like an onion. (o_ _o) It's made up of several layers \\\_\ /_/// erwin@FreeBSD.org And it makes you cry. <____) (____> erwin@aauug.dk --Q0rSlbzrZN6k9QnT Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFGN1dqy9aWxUlaZARAk9EAJ9ncGP4ksK87rrjR6QfSKuKfdXFCACfeF/i 2smEyPkTvWvqzyTetMtiPII= =3+ME -----END PGP SIGNATURE----- --Q0rSlbzrZN6k9QnT--