From owner-freebsd-hackers@freebsd.org  Wed Feb 14 07:14:31 2018
Return-Path: <owner-freebsd-hackers@freebsd.org>
Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8D2A2F06618
 for <freebsd-hackers@mailman.ysv.freebsd.org>;
 Wed, 14 Feb 2018 07:14:31 +0000 (UTC)
 (envelope-from lists@eitanadler.com)
Received: from mail-yw0-x229.google.com (mail-yw0-x229.google.com
 [IPv6:2607:f8b0:4002:c05::229])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 26BB687D87
 for <freebsd-hackers@freebsd.org>; Wed, 14 Feb 2018 07:14:31 +0000 (UTC)
 (envelope-from lists@eitanadler.com)
Received: by mail-yw0-x229.google.com with SMTP id p2so470233ywg.10
 for <freebsd-hackers@freebsd.org>; Tue, 13 Feb 2018 23:14:31 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=eitanadler.com; s=0xdeadbeef;
 h=mime-version:from:date:message-id:subject:to;
 bh=sS6O1fAjLh/jmeiVCyJ4wpBNomKvI1A3tK01sdzPQwU=;
 b=inkOo5Zm6SC0AVkWCTNblCvXX+dLslw4FMldtauh7Ni9Xwceviv0cRvAsdck6IStvI
 RlP5Jhw1goBwtxKlN9BDckmLoXxqBFkvLSEksnhNoWEGd7OEgzH6XcbmAj3T9JuD17qe
 hXFhnQE6oVv5vs3FIAsWGOe2ipUS6t7k74MxQ=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:from:date:message-id:subject:to;
 bh=sS6O1fAjLh/jmeiVCyJ4wpBNomKvI1A3tK01sdzPQwU=;
 b=jPCTKA8IYw33C62qPGMEqoEnqOA+qHxaC/3tMKtXkSJ/iRpDsGsdaHdxyT0O7iCu2h
 6e6j6gnw2BlI0PUB7hiM9kg5/b7r7dqzBV6ba5KhlRt05F6LN0jAmsV6R6U9/Y8vWYYN
 zDRgJQXnfwy9hj5rIgKZVFNyvRlNAsQm4o94rDaJ/SJFBlFHwUDkBVAhM+rppIp3sOpW
 /bB48e9GPLdbDTXyRSmJ9rTeu+JrJI6hM9AS/4SV5lfavaRZfUjnyS0GeWigic65UaJd
 GE4k2A097CenxSbHxw/6OFDPyfbI0IbEKFkHqPXeeBp+RUzehAkuS/xCKPX/617zNmZz
 sn+w==
X-Gm-Message-State: APf1xPAyYzClogggs6FVTtvZUSewGtT/9aJMTbG3gho36e97uEh8bhLO
 d56fqmwAidFkqZgl9U5koO+dVIWQQs/0AtkCIf1ORTA2
X-Google-Smtp-Source: AH8x227I/YH96YxHVWB8UYerZJswqbtRVqRGP+zPbtTCw1rMCiN6BMQUmYLdLBW0YAff/BtCk/4XK/WUa99xKqlkWnk=
X-Received: by 10.37.189.135 with SMTP id f7mr2552167ybh.486.1518592470021;
 Tue, 13 Feb 2018 23:14:30 -0800 (PST)
MIME-Version: 1.0
Received: by 2002:a25:7107:0:0:0:0:0 with HTTP; Tue, 13 Feb 2018 23:13:59
 -0800 (PST)
From: Eitan Adler <lists@eitanadler.com>
Date: Tue, 13 Feb 2018 23:13:59 -0800
Message-ID: <CAF6rxgmrkUS18kVPCK1VkBJAhBQ2vY3_MJgq+XNjqcx8yFi7Lw@mail.gmail.com>
Subject: select call in devd
To: FreeBSD Hackers <freebsd-hackers@freebsd.org>, Warner Losh <imp@bsdimp.com>,
 zrj@dragonflybsd.org
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers/>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Feb 2018 07:14:31 -0000

Hi all,

select(2) is declared with restrict for the pointers for fd. Can y'all
confirm this is the correct fix?

It is only lightly tested (it seems to do its job on my machine)

Index: devd.cc
===================================================================
--- devd.cc (revision 329192)
+++ devd.cc (working copy)
@@ -1021,7 +1021,7 @@ event_loop(void)
  tv.tv_usec = 0;
  FD_ZERO(&fds);
  FD_SET(fd, &fds);
- rv = select(fd + 1, &fds, &fds, &fds, &tv);
+ rv = select(fd + 1, &fds, NULL, NULL, &tv);
  // No events -> we've processed all pending events
  if (rv == 0) {
  devdlog(LOG_DEBUG, "Calling daemon\n");


-- 
Eitan Adler