From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Feb 13 15:50:01 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1E5B51065673 for ; Fri, 13 Feb 2009 15:50:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id ED8B98FC1E for ; Fri, 13 Feb 2009 15:50:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n1DFo0dt099993 for ; Fri, 13 Feb 2009 15:50:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n1DFo048099992; Fri, 13 Feb 2009 15:50:00 GMT (envelope-from gnats) Resent-Date: Fri, 13 Feb 2009 15:50:00 GMT Resent-Message-Id: <200902131550.n1DFo048099992@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Ben C. O. Grimm" Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 00876106566C for ; Fri, 13 Feb 2009 15:42:56 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id E23338FC15 for ; Fri, 13 Feb 2009 15:42:56 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n1DFguMe070590 for ; Fri, 13 Feb 2009 15:42:56 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n1DFguSP070589; Fri, 13 Feb 2009 15:42:56 GMT (envelope-from nobody) Message-Id: <200902131542.n1DFguSP070589@www.freebsd.org> Date: Fri, 13 Feb 2009 15:42:56 GMT From: "Ben C. O. Grimm" To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/131646: rsnapshot exclude statements not properly documented X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Feb 2009 15:50:01 -0000 >Number: 131646 >Category: ports >Synopsis: rsnapshot exclude statements not properly documented >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: doc-bug >Submitter-Id: current-users >Arrival-Date: Fri Feb 13 15:50:00 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Ben C. O. Grimm >Release: 7.1-STABLE >Organization: None >Environment: FreeBSD hail.bengrimm.net 7.1-STABLE FreeBSD 7.1-STABLE #0: Fri Feb 6 17:12:09 CET 2009 root@hail.bengrimm.net:/usr/obj/usr/src/sys/HAIL i386 >Description: The sysutils/rsnapshot port's config file (rsnapshot.conf) has include/exclude statements. The statements are applied to every rsnapshot backup, even when included config files have different include/exclude statements, or have no include/exclude statements at all. For example: in rsnapshot.conf: include # exclude # include_conf /usr/local/etc/host1_rsnapshot.conf include_conf /usr/local/etc/host2_rsnapshot.conf in host1_rsnapshot.conf: exclude backups* in host2_rsnapshot.conf: exclude docs* Executing rsnapshot -v will produce, FOR BOTH HOSTS: /usr/local/bin/rsync -a --delete --numeric-ids --relative --delete-excluded \ --exclude=backups* --exclude=docs* [etcetera) Nothing in the man page suggests that this functionality exists when include/exclude statements are used in several included config files. I'm aware of the fact that includes/excludes will work correctly when they are passed on the backup line itself, like this: backup root@example.com:/etc/ example.com/ exclude=mtab,exclude=core >How-To-Repeat: >Fix: I think the man file should make it clear that any include/exclude statements that are not part of a 'backup' line will be used for every single backup in a single rsnapshot run, and will be 'added up' and applied across the board. >Release-Note: >Audit-Trail: >Unformatted: