From owner-svn-src-all@freebsd.org Thu Jun 14 03:34:34 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 78A261019C7C for ; Thu, 14 Jun 2018 03:34:34 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22b.google.com (mail-io0-x22b.google.com [IPv6:2607:f8b0:4001:c06::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0654A6F44D for ; Thu, 14 Jun 2018 03:34:34 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22b.google.com with SMTP id u4-v6so5735073iof.2 for ; Wed, 13 Jun 2018 20:34:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=5Qpz+tOntiGpl+liUCcdnVnxpdIxEZkHzuVX3G+It44=; b=TdcIWRxW78iMhyR+9UGsIXPhMREALKK+zsi5uKgf4bi0fAyqxU+BJyHjFMROIXyrBa qJOJ8cs6fbEneyxJ1e9aDBXWOGeuTU+cAfuPT9dyGGtmUGTND4WWeJbhXubeeAgouNNA QT8yJavlQAsUgrSJv53jO1uIQItHUfYiwfmy4dAgga67PAxfm/yC14beSO8FsTJvG0Pp rR6VnaxsyKHt7hFSszCiZKDn1bG4AUj4Io7fDtOre2jOnmBtSvK4ElJ6rHnDZ560H2su i6VnW12DRfMOz34KhOwkc5TDxVdMmv59wL65ayiyb3FOEr0eux85GA4gN3RBttFFkoyY Bfmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=5Qpz+tOntiGpl+liUCcdnVnxpdIxEZkHzuVX3G+It44=; b=JVPOrvgtpas1kUOzy8HJEM1PPmo2FnZ2gKLE25Re6bn6NUIsnGdkS5Pw6TFvpseK17 PX0gmvK9s1Zw5waFWJ78rs+0g13lhpzZq7aC485QbENAEUG6rkEbbIN5GZmgtpxEG365 Oiyi9wkhBbQMaQ+VpkmD2eaBSO6qCxlcrHb8vimTvJ+2hoRF5jREKBNceuGVRO+h50ih 1ANIcJWaf+/+fquX/4BTLPxmyX0atiry1ktECngWRMQnKk7R9DDLvxkzAy19Qfvs36PD qQJhwjAqeJ+LNjhYvwBENxEx3ilYMPbuJVD8/mt7j19Z05lSdNW/9d1xGhkXoXRTT+1x 9M4Q== X-Gm-Message-State: APt69E10uZCrIO9Db5ZoYRv/jGvxt4UqKlFPfOPR9mJ5v2MJosgS+Mnw MptqhKHZTVWHqoveVvEWkxWOtuSEBCccbXsVyXQz5w== X-Google-Smtp-Source: ADUXVKKkvjWpuBYWtP1V6c3SewhGhOBpxMc4hSj5S+2jNsjZmxRhudRVj41vrfWbsvnwr51drKgCV2nglsLrOBBUrCA= X-Received: by 2002:a6b:d40c:: with SMTP id l12-v6mr759818iog.37.1528947273356; Wed, 13 Jun 2018 20:34:33 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:d028:0:0:0:0:0 with HTTP; Wed, 13 Jun 2018 20:34:32 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: References: <201806140328.w5E3SCZp042620@pdx.rh.CN85.dnsmgr.net> From: Warner Losh Date: Wed, 13 Jun 2018 21:34:32 -0600 X-Google-Sender-Auth: QO5BZk1KHtjv9BWadMBh7iuLhy4 Message-ID: Subject: Re: svn commit: r335091 - head/sbin/nvmecontrol To: Juli Mallett Cc: "Rodney W. Grimes" , Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jun 2018 03:34:34 -0000 On Wed, Jun 13, 2018 at 9:31 PM, Juli Mallett wrote: > On 13 June 2018 at 20:28, Rodney W. Grimes > wrote: > >> > On Wed, Jun 13, 2018 at 9:03 PM, Rodney W. Grimes < >> > freebsd@pdx.rh.cn85.dnsmgr.net> wrote: >> > >> > > > Author: imp >> > > > Date: Wed Jun 13 22:00:02 2018 >> > > > New Revision: 335091 >> > > > URL: https://svnweb.freebsd.org/changeset/base/335091 >> > > > >> > > > Log: >> > > > Make it possible to use print_controller from another program >> > > > >> > > > Rename print_controller to nvme_print_controller. Put it in its >> > > > own file for easy inclusion. Move util.c to be nc_util.c to not >> > > > conflict with camcontrol. add nvecontrol_ext.h to define shared >> > > > interfaces. >> > > > >> > > > Sponsored by: Netflix >> > > > Differential Revision: https://reviews.freebsd.org/D15371 >> > > > >> > > > Added: >> > > > head/sbin/nvmecontrol/identify_ext.c >> > > > - copied, changed from r335089, head/sbin/nvmecontrol/identify >> .c >> > > > head/sbin/nvmecontrol/nc_util.c >> > > > - copied, changed from r335089, head/sbin/nvmecontrol/util.c >> > > > head/sbin/nvmecontrol/nvmecontrol_ext.h (contents, props >> changed) >> > > > - copied, changed from r335089, head/sbin/nvmecontrol/util.c >> > > ... >> > > >> > > > >> > > > Copied and modified: head/sbin/nvmecontrol/nvmecontrol_ext.h (from >> > > r335089, head/sbin/nvmecontrol/util.c) >> > > > ============================================================ >> > > ================== >> > > > --- head/sbin/nvmecontrol/util.c Wed Jun 13 21:10:23 2018 >> > > (r335089, copy source) >> > > > +++ head/sbin/nvmecontrol/nvmecontrol_ext.h Wed Jun 13 22:00:02 >> 2018 >> > > (r335091) >> > > > @@ -1,7 +1,8 @@ >> > > > /*- >> > > > - * Copyright (c) 2017 Netflix, Inc >> > > > - * All rights reserved. >> > > > + * SPDX-License-Identifier: BSD-2-Clause-FreeBSD >> > > > * >> > > > + * Copyright (C) 2018 Netflix >> > > >> > > You moved a copyright forward, that is not proper to do. >> > > >> > >> > Thought it was. I honestly don't care where (nor does my employer), so >> if >> > you want to tweak it to be more conforming, be my guest. >> >> You can add a new date to the end of a list, but you should always >> retain the oldest date, and many opinions are that all dates should >> be retained unless they are continuous. >> > > Do you have a citation for this, Rod? I ask because my impression was > that although it has often been done, and at one point may legitimately > have been required, it is not any longer so. I'd love to have a concrete > source on this, though. > The project just does oldest and newest with a -. The US copyright office says you just need the newest. There's some concern elsewhere is different, but I have nothing concrete on that. I've never heard Rod's advice in the 20 years I've been minding the store here and at small shops I've worked at. Warner > > It would be much simpler for you to commit: >> - * Copyright (C) 2018 Netflix >> + * Copyright (C) 2017-2018 Netflix >> >> Than for me to get approval: bde, phk. >> >> Thanks. >> Rod >> >> > >> > > Not sure about dropping the , Inc either. >> > >> > >> > Doesn't matter. Different Netflix committers do different things and I >> was >> > trying to move towards uniformity. >> >> Ok >> >> > Warner >> >> -- >> Rod Grimes >> rgrimes@freebsd.org >> >> >