Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 2 Jul 2019 00:23:47 +0100 (BST)
From:      Gerald Pfeifer <gerald@pfeifer.com>
To:        Mark Linimon <linimon@lonesome.com>
Cc:        Alexey Dokuchaev <danfe@freebsd.org>,  Cy Schubert <Cy.Schubert@cschubert.com>, ports-committers@freebsd.org,  svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r504198 - head/Mk
Message-ID:  <alpine.LSU.2.21.1907020017480.4639@anthias.pfeifer.com>
In-Reply-To: <20190615173659.GB19307@lonesome.com>
References:  <201906141610.x5EGAdnN049103@repo.freebsd.org> <F69E23F2-E526-4B3F-95EB-1786222C2D61@cschubert.com> <20190614165425.GA42674@FreeBSD.org> <8BDC3B40-7FEA-46EA-AE7C-A3C266F6978F@cschubert.com> <20190614175822.GA3336@FreeBSD.org> <20190615061345.GA20346@lonesome.com> <alpine.LSU.2.21.1906151028570.3441@anthias.pfeifer.com> <20190615173659.GB19307@lonesome.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 15 Jun 2019, Mark Linimon wrote:
> No, our build cluster is still using base 4.2 by default.  Most of 
> the ports that fail are fixed by specifying a USES that names a newer
> compiler.

Yep, such as the one below.  Hence my proposal to switch to a 
newer version of GCC by default where there's currently USE_GCC=any 
or similar via USES=compiler.

> Clang is "coming soon".  It's a race between the folks working 
> on fixing ports on base vs. the folks working on clang :-)

Well, and it surely is going to be an easier switch from current
GCC (such as GCC 8) to current clang than from a decade old compiler
(such as GCC 4.2).  

I'm not necessarily proposing to use modern GCC across the port, but 
at least where some version of GCC is explicitly requested (hence 
s/USE_GCC=any/USE_GCC=yes/g and, though that can be an independent 
change, the equivalent in Mk/Uses/compiler.mk).

Gerald


======== example commit ========
Author: stephen
Date: Sun Jun 30 23:32:57 2019
New Revision: 505525
URL: https://svnweb.freebsd.org/changeset/ports/505525

Log:
  - On GCC architectures, don't use the base GCC to build.
  
  PR:		238885
  Submitted by:	Piotr Kubaj <pkubaj@FreeBSD.org>

Modified:
  head/math/octave-forge-nurbs/Makefile

Modified: head/math/octave-forge-nurbs/Makefile
==============================================================================
--- head/math/octave-forge-nurbs/Makefile	Sun Jun 30 23:10:19 2019	(r505524)
+++ head/math/octave-forge-nurbs/Makefile	Sun Jun 30 23:32:57 2019	(r505525)
@@ -22,8 +22,15 @@ WRKSRC=		${WRKDIR}/${OCTSRC}/src
 
 .include "${.CURDIR}/../../Mk/bsd.octave.mk"
 
+.include <bsd.port.pre.mk>
+
+# Force newer GCC on platforms using GCC 4.2 as base
+.if ${CHOSEN_COMPILER_TYPE} == gcc
+USE_GCC=        yes
+.endif
+
 post-build:
 	${RM} ${WRKSRC}/Makefile ${WRKSRC}/configure
 	cd ${WRKDIR} && ${TAR} cfz ${DISTNAME}.tar.gz ${OCTSRC}
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LSU.2.21.1907020017480.4639>