From nobody Fri May 29 23:11:32 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gRzd12GBpz6gGVH for ; Fri, 29 May 2026 23:11:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gRzd06DcSz3WmQ for ; Fri, 29 May 2026 23:11:32 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780096292; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Vu5nOhN+5onxA1TeYdlNXeBFd2yE89ukXpoIvP48aQo=; b=DeesSdKceAl3ZlAILN5ySoOxvZyWS4c/1rHNSTRL09y/ACjsVAa9MyulJmGvmwDdgAr4X/ 6sELY6qHnAJQVmfVuwAey8YXqIkxrhwiKE4gNffUZFrIPZsIveiFu7sipiklFO/kRbzi67 RIRowLra/sR0yMp8sgpgjD7vwlehRYVscmN6RHkiuP84fZuqLufU1u+eBHKt5SdmgbfwCd CnaEGwBLE0kSRwXQ5gQMuLauw5KPllGkjsZAUQInTZl1u0gSZ2isVWVkApk97nWbQpDx8J N0fOUVb9b3k0pNksm1Phu9L7CEUhhketjxrKKdWml+Y61s8bs/KxLm6UXkXkUw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1780096292; a=rsa-sha256; cv=none; b=FdLw4O14gD1Iu/MjQCHhx1/RgeaxkWYdv5FMB795JIFuoqdF3+mm91lT4rYfD2NqU+xbh6 FSZ5XwnM9Mp6T6eCxxew8zK0nTk7nJPtJSkZU8wUuOe6igKwKfkti7452wDWRbsK3bNGfC HEW9wFzch53JR6XCxqhj0yEyHllq4OCnQKz5TYCAL5GckmkEU6aB8htYjZnlFmGenSeBGi KFawfkm/3c1d786WCRMHoUHEkWAoIPEjTWzlz9hiprvauqW83k9/Jp4IBKs7L/QxZrwnsS UQnEvbxrwRLOwP9NeDctqx+qKF8O9N4UAMnxdt3qj8Gje30j1z5zdsv9vNp23w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780096292; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Vu5nOhN+5onxA1TeYdlNXeBFd2yE89ukXpoIvP48aQo=; b=tdvrDND2HPbmSWYpD1zUvfCN/vVqe/xpIM0KrQesh2p9mANt0VwqtY2KIhdBbdfXriqBYN tjtia5nwHUVhhV+CNm6f3oAWMTD1VZZ82Ux1PGgXbErv775Ssg/R/BI+/LJHZbXskVVQ0f CBZvs8nbsXFQeTl6friH9OhMhojW+Bf+o7xaka8j8zPsOAgDUmekc7FgolOoUx4ftamRCW a9vClmptuGdSHuwdBt2b5FQyl0lDgio5G6k/oMcSNsQk8VrtB/ldT7PgLZcQXNz/IerHxA zm1ndMJ/An/yCFvKu70X0xK/1/fCPzJ8Q0fY/N1OcUEVpQ4TqHKUYgKDeN/tbQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gRzd05MX7zv3v for ; Fri, 29 May 2026 23:11:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 43c1e by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 29 May 2026 23:11:32 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ed Maste Subject: git: 96dbc9a8de10 - main - netlink: Check permissions for interface flag changes List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 96dbc9a8de105065b6b1e55702aa648319176587 Auto-Submitted: auto-generated Date: Fri, 29 May 2026 23:11:32 +0000 Message-Id: <6a1a1d24.43c1e.1bfef5c@gitrepo.freebsd.org> The branch main has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=96dbc9a8de105065b6b1e55702aa648319176587 commit 96dbc9a8de105065b6b1e55702aa648319176587 Author: Ed Maste AuthorDate: 2026-05-29 15:52:03 +0000 Commit: Ed Maste CommitDate: 2026-05-29 23:11:21 +0000 netlink: Check permissions for interface flag changes Reviewed by: pouria, melifaro Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D57332 --- sys/netlink/route/iface_drivers.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/sys/netlink/route/iface_drivers.c b/sys/netlink/route/iface_drivers.c index d26e92044ff5..79daa4215dba 100644 --- a/sys/netlink/route/iface_drivers.c +++ b/sys/netlink/route/iface_drivers.c @@ -83,6 +83,10 @@ _nl_modify_ifp_generic(struct ifnet *ifp, struct nl_parsed_link *lattrs, if ((lattrs->ifi_change & IFF_UP) != 0 || lattrs->ifi_change == 0) { /* Request to up or down the interface */ + if (!nlp_has_priv(npt->nlp, PRIV_NET_SETIFFLAGS)) { + nlmsg_report_err_msg(npt, "Not enough privileges to set flags"); + return (EPERM); + } if (lattrs->ifi_flags & IFF_UP) if_up(ifp); else @@ -104,7 +108,7 @@ _nl_modify_ifp_generic(struct ifnet *ifp, struct nl_parsed_link *lattrs, } if ((lattrs->ifi_change & IFF_PROMISC) != 0 || - lattrs->ifi_change == 0) + lattrs->ifi_change == 0) { /* * When asking for IFF_PROMISC, set permanent flag instead * (IFF_PPROMISC) as we have no way of doing promiscuity @@ -112,7 +116,12 @@ _nl_modify_ifp_generic(struct ifnet *ifp, struct nl_parsed_link *lattrs, * function either sets or unsets IFF_PROMISC, and ifi_change * is usually set to 0xFFFFFFFF. */ + if (!nlp_has_priv(npt->nlp, PRIV_NET_SETIFFLAGS)) { + nlmsg_report_err_msg(npt, "Not enough privileges to set promisc"); + return (EPERM); + } if_setppromisc(ifp, (lattrs->ifi_flags & IFF_PROMISC) != 0); + } if (lattrs->ifla_address != NULL) { if (!nlp_has_priv(npt->nlp, PRIV_NET_SETIFMAC)) {