From owner-svn-src-all@freebsd.org Sun Dec 9 20:37:30 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 178C0132EB85 for ; Sun, 9 Dec 2018 20:37:30 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 65BB47A99A for ; Sun, 9 Dec 2018 20:37:29 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x836.google.com with SMTP id e5so10145366qtr.12 for ; Sun, 09 Dec 2018 12:37:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+WM9s9Lfm8ifValAHHuTBzcWuZYWFYu5YMpLErL0Mzg=; b=nWMn1jvI+SiAy66l/1Byjx3zrfR9gpCw0eYM8RpALIMt9jMxe1lkSGM+sKOHDYkz8A MgQuR1bQ641XsBM3IDTakxt5Lw3HV2cqLCY3NGvgyac1hxeugphWegxSmvvMV6D4JVSY oys7/D+jM+xGWWMnigJc6K3O7hDS4XHSnSDiOvjSaq82YhzoBkB+8DgbrBh4ShekjgUD XGmesU2s/JngCPt+PHU1n76Rq1IedixxcV86xvdy64EwReDcTCw8ySGLvabuB7LSYiCZ W5jRFpWiUCxFXhQw9dQjR+woSO71rNWkX9akhtPQmVwgNSA4avg+UV/siPEQp7ja7VjV UFDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+WM9s9Lfm8ifValAHHuTBzcWuZYWFYu5YMpLErL0Mzg=; b=M1rQqCgaqyqN/H7LMizN37uOsq68NSyw4+zATfAIy3hsq2fZeVQr6nsboNHBrW4pHl 3OZzXwQe87ITCUnrwfz9mZ6Y7UHlChhYk93FaJ3l1yLJJuaaWndtEtWrzaBmSTkFWS18 w5qYXxpWoqo7TTcpMpk2BGtTuopUdrozOl91baZoEN8Z77fGSUC/ntsiJsNyl4bePgMf qx/UkwSFbu/UfIvZ7m95z32/JU7d2YYjabQ0GzQyvTV2rrxgi2Il0q2GppptvwkvxKVK q19A+TLxQX4DJlSlGkChNP/jzCaHJN59hOd7fFEGVRmkkcBYAZGdGoOjOIKOz4rNVsD+ Jxnw== X-Gm-Message-State: AA+aEWb/mvoxGL2yhYsXxIxy25pX8+W0X1qAHcSSXZNn815CQ/Hx1sNI B5lBm0YszmU/qV0IZDQYhvZRpZFmFxMK4zCWN3TDGA== X-Google-Smtp-Source: AFSGD/VygZYI0hmEc8m+gu10UpW8ZZYbnokH7NdEZPU30XsBCazF7vZTqps9AQdPLuVEj899Ffsv0cNvpBI230aCCGk= X-Received: by 2002:ac8:3f2d:: with SMTP id c42mr9648537qtk.33.1544387848642; Sun, 09 Dec 2018 12:37:28 -0800 (PST) MIME-Version: 1.0 References: <201812090701.wB9711aN058754@slippy.cwsent.com> <201812091933.wB9JXOvW062964@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201812091933.wB9JXOvW062964@pdx.rh.CN85.dnsmgr.net> From: Warner Losh Date: Sun, 9 Dec 2018 13:37:17 -0700 Message-ID: Subject: Re: svn commit: r341759 - in head: contrib/wpa contrib/wpa/hostapd contrib/wpa/hs20/client contrib/wpa/src/ap contrib/wpa/src/common contrib/wpa/src/crypto contrib/wpa/src/drivers contrib/wpa/src/eap_c... To: "Rodney W. Grimes" Cc: Cy Schubert , Cy Schubert , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 65BB47A99A X-Spamd-Result: default: False [-4.67 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.99)[-0.993,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; MX_GOOD(-0.01)[cached: ALT1.aspmx.l.google.com]; RCVD_IN_DNSWL_NONE(0.00)[6.3.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.73)[-0.733,0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_LAST(0.00)[]; IP_SCORE(-1.93)[ip: (-6.79), ipnet: 2607:f8b0::/32(-1.50), asn: 15169(-1.30), country: US(-0.09)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Server: mx1.freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Dec 2018 20:37:30 -0000 On Sun, Dec 9, 2018 at 1:09 PM Rodney W. Grimes < freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > In message <201812090645.wB96jnso066329@repo.freebsd.org>, Cy Schubert > > writes: > > > Author: cy > > > Date: Sun Dec 9 06:45:49 2018 > > > New Revision: 341759 > > > URL: https://svnweb.freebsd.org/changeset/base/341759 > > > > > > Log: > > > MFV r341618: > > > > > > Update wpa 2.6 --> 2.7. > > > > Relnotes: yes > > As an FYI, or maybe a new procedure, doing a reply to > a commit message adding relnotes: yes does very little > to insure that this commit gets refered to in release > notes. > > What about we add RELNOTES.missed to the tree > next to UPDATING, and when someone forgets to tag > the Relnotes:yes into a commit you just follow up > with a commit to that file, stating the svn revision > which was missing the note and then we have a nice > documented and clean way to extract the missing > release note items, rather than trying to cull it > from a thread in a mail list archive. > > The file would get truncated to 0 at appropriate > times on various branches. > How about just RELNOTES. You put the revision that is relevant and a quick blurb. That way we don't have to look in two places. All release notes go in here, no exceptions. You can retroactively tag them, or you can commit this as part of commit. Have a blurb at the top that tells people what order to add them in, and you'd be set. We'd then retire "relnotes: yes" in the commit message. This would also allow 'helpers' to format the RELNOTES file as we go rather than having to play 2 years of catch-up at major branch times. Having it in the commit message just doesn't work, and this is one of many reasons: Cy forgot. Other times I'll do something and it's only a month later I realize it needs to be in the release notes after some issue has come up.... Other times I put relnotes: yes in only to realize that's my vanity talking, and nobody else cares. Warner