From owner-svn-src-head@freebsd.org Mon Jun 17 10:27:56 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6E6A915B3C1F; Mon, 17 Jun 2019 10:27:56 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from mail.daemonic.se (mail.daemonic.se [IPv6:2607:f740:d:20::25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E0C8E89176; Mon, 17 Jun 2019 10:27:55 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from cid.daemonic.se (localhost [IPv6:::1]) by mail.daemonic.se (Postfix) with ESMTP id 45S6qF49vBz3kkc; Mon, 17 Jun 2019 10:27:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at daemonic.se Received: from mail.daemonic.se ([IPv6:::1]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256) by cid.daemonic.se (mailscanner.daemonic.se [IPv6:::1]) (amavisd-new, port 10587) with ESMTPS id ihwxH04i2ko9; Mon, 17 Jun 2019 10:27:52 +0000 (UTC) Received: from garnet.daemonic.se (host-90-236-237-150.mobileonline.telia.com [90.236.237.150]) by mail.daemonic.se (Postfix) with ESMTPSA id 45S6qD4CjQz3c7W; Mon, 17 Jun 2019 10:27:52 +0000 (UTC) Subject: Re: svn commit: r349133 - head/share/man/man4 To: rgrimes@freebsd.org Cc: Benjamin Kaduk , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201906170903.x5H93Wac008131@gndrsh.dnsmgr.net> From: Niclas Zeising Message-ID: <4e64bb67-7e4b-cd2d-7690-b6be11d78f58@freebsd.org> Date: Mon, 17 Jun 2019 12:27:51 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <201906170903.x5H93Wac008131@gndrsh.dnsmgr.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E0C8E89176 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.96)[-0.965,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jun 2019 10:27:56 -0000 On 2019-06-17 11:03, Rodney W. Grimes wrote: >> On 2019-06-17 09:56, Benjamin Kaduk wrote: >>> On Sun, Jun 16, 2019 at 10:42 PM Niclas Zeising >> > wrote: >>> >>> Author: zeising (doc,ports committer) >>> Date: Mon Jun 17 05:41:47 2019 >>> New Revision: 349133 >>> URL: https://svnweb.freebsd.org/changeset/base/349133 >>> >>> Log: >>> ? pci(4): Document PCIOCATTACHED >>> >>> ? Document the PCIOCATTACHED ioctl(2) in the pci(4) manual. >>> ? PCIOCATTACHED is used to query if a driver has attached to a PCI. >>> >>> ? Reviewed by:? bcr, imp >>> ? MFC after:? ? 2 weeks >>> ? Differential Revision: https://reviews.freebsd.org/D20652 >>> >>> Modified: >>> ? head/share/man/man4/pci.4 >>> >>> Modified: head/share/man/man4/pci.4 >>> ============================================================================== >>> --- head/share/man/man4/pci.4? ?Mon Jun 17 03:48:44 2019 >>> (r349132) >>> +++ head/share/man/man4/pci.4? ?Mon Jun 17 05:41:47 2019 >>> (r349133) >>> @@ -24,7 +24,7 @@ >>> ?.\" >>> ?.\" $FreeBSD$ >>> ?.\" >>> -.Dd June 14, 2018 >>> +.Dd June 17, 2019 >>> ?.Dt PCI 4 >>> ?.Os >>> ?.Sh NAME >>> @@ -333,6 +333,26 @@ The limitations on data width described for >>> ?reading registers, above, also apply to writing >>> ?.Tn PCI >>> ?configuration registers. >>> +.It PCIOCATTACHED >>> +This >>> +.Xr ioctl 2 >>> +allows users to query if a driver is attached to the >>> +.Tn PCI >>> +specified in the passed-in >>> >>> >>> Is there a missing word like "device" here? > > Actally I think the missing word, in both cases, is register, > unless I am misreading some part of the manual page and > what a struct pci_io points at. I guess if the pi_reg is null > then this would be device. Either way there is defanity a > missing word. I'll try to fix this. In the PCIOCWRITE case, perhaps register is best, however, inthe PCIOCATTACHED case, device is best, I think. I'll create a patch and put it for review, I'll get back to you once it's done. Regards > >> >> I just followed the same syntax as for the PCIOCWRITE ioctl in the >> paragraph before. > > Probably a mistake there too. > >> I found it a little strange when I read it, but I >> kind of assumed there was a reason it said PCI and not PCI device, >> perhaps similar to using RAM instead of RAM memory, if you understand >> what I mean. > > RAM memory == Random Access Memory Memory > PCI == Peripheral Component Interconnect > PCI {Register, Device, Bus} all make valid sense, > PCI alone does not. > >> Regards >> Niclas >> >>> >>> +.Va pci_io >>> +structure. >>> +The >>> +.Va pci_io >>> +structure is described above, however, the >>> +.Va pi_reg >>> +and >>> +.Va pi_width >>> +fields are not used. >>> +The status of the device is stored in the >>> +.Va pi_data >>> +field. >>> +A value of 0 indicates no driver is attached, while a value larger >>> than 0 >>> +indicates that a driver is attached. >>> ?.It PCIOCBARMMAP >>> ?This >>> ?.Xr ioctl 2 >> >> >> -- >> Niclas Zeising >> >> >> > -- Niclas Zeising