From owner-dev-commits-src-all@freebsd.org Fri Sep 3 01:14:22 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 26D4766C7AE; Fri, 3 Sep 2021 01:14:22 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4H10F95wJXz4cHb; Fri, 3 Sep 2021 01:14:21 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 1831EDKf070630 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Fri, 3 Sep 2021 04:14:16 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 1831EDKf070630 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 1831EDkT070629; Fri, 3 Sep 2021 04:14:13 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 3 Sep 2021 04:14:13 +0300 From: Konstantin Belousov To: Toomas Soome Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 4c7a3a70e047 - main - loader.efi: fix console output after BS off Message-ID: References: <202109022150.182LoYDP046220@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202109022150.182LoYDP046220@gitrepo.freebsd.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.5 X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on tom.home X-Rspamd-Queue-Id: 4H10F95wJXz4cHb X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Sep 2021 01:14:22 -0000 On Thu, Sep 02, 2021 at 09:50:34PM +0000, Toomas Soome wrote: > The branch main has been updated by tsoome: > > URL: https://cgit.FreeBSD.org/src/commit/?id=4c7a3a70e047fbba2a3ce4a0168eaf2baddca76b > > commit 4c7a3a70e047fbba2a3ce4a0168eaf2baddca76b > Author: Toomas Soome > AuthorDate: 2021-09-02 21:17:32 +0000 > Commit: Toomas Soome > CommitDate: 2021-09-02 21:48:56 +0000 > > loader.efi: fix console output after BS off > > When Boot Services (BS) are switched off, we can not use BS > functions any more. Since drawn console does implement our own > Blt(), we can use it to draw the console. > > However, SimpleTextOutput protocol based console output must be > blocked. > > Tested by inserting printf() after ExitBootServices() call. > > MFC after: 1 week > --- > stand/common/gfx_fb.c | 14 +++++--------- > stand/efi/libefi/efi_console.c | 22 +++++++++++++++++++++- > 2 files changed, 26 insertions(+), 10 deletions(-) > > diff --git a/stand/common/gfx_fb.c b/stand/common/gfx_fb.c > index 45d0072bd858..99968e10d8fe 100644 > --- a/stand/common/gfx_fb.c > +++ b/stand/common/gfx_fb.c > @@ -751,12 +751,15 @@ gfxfb_blt(void *BltBuffer, GFXFB_BLT_OPERATION BltOperation, > #if defined(EFI) > EFI_STATUS status; > EFI_GRAPHICS_OUTPUT *gop = gfx_state.tg_private; > + extern int boot_services_gone; I suspect the time come to move boot_services_done declaration into some common header for UEFI loader. > + EFI_TPL tpl;