From owner-svn-src-all@freebsd.org Fri Aug 7 15:45:11 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 432263BD82E for ; Fri, 7 Aug 2020 15:45:11 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound2k.ore.mailhop.org (outbound2k.ore.mailhop.org [54.148.219.64]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4BNV6t5zpqz4YtH for ; Fri, 7 Aug 2020 15:45:10 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1596815109; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=YMRmI9XrzsFSFLTKQ6HFLWv4M6EHMwcZ9KKUl8gzvim9gdYmNO+y9h79gPmQYOgXVrfqEnvlCzNvC 7AY9OULg4e7r2MmpArfItoARj/0xHysIbO2SKe2nmMVLTPDgTPlqD4j/qw69c9p7+tch4i5xOYH+cm OK8FlI5sg2ouVGK8uGovuSRcj29+ucAL99xMYE2JGDmhkfRbgWp7HzZ7woxLNb/p8XfN7hT0GHv8OV uWFVVcp6hrUOwKElNwgHCeVExDSXpvmi3hrKr9CHF0S1Jq8qNpPzxOZl+/TMa3RFXd3BLThC4Aa5SS Vuq5iJDSr+8ZaB6G6vSSTc4VDh/7K6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=KWrKMNPXqmdZ9AZpnK1McNnLDacj8A80QxBYlZNDlm4=; b=I0SZ9nQ2qBdsFFo8pZVAh+9JtVN+dGBBQ0wascqd68SeMi/S0ia9T8l3hC3OIREFFpzsIM5pLTy+y aAS8YAjJfj3fwHwbO8QxY2cCbKJHlFEYab2zx1MESeViOpQbDwwXX10qt8cGvHDghIE9aEB3343Fb4 QYUShjyjKochbBgHy7zqLvmZdF0mxZ/aym5q/EZechw7uVgwCPiZlb0Lb6d5P1MteJWN5pqxPEHIcC HLEEq6BL25lyEJC/20IMFRcxOqUa6HsVjTuiU3tes0La0KBxhWv+d4bJoRjTJP2pkuNmAVUnkvci5l 6VvF39+EKuT6FCzDBD5+C+ORSxwO4vg== ARC-Authentication-Results: i=1; outbound4.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=KWrKMNPXqmdZ9AZpnK1McNnLDacj8A80QxBYlZNDlm4=; b=MlUHc9jVfDFB4e3q+FLg13BDDgQcdj/brmEdC2vYqDnxqAAnGYQE2D66aIM8DCvWNUCUkIrIFicdn MCoCmxS7LpCUsfsyu5enyS1GkTx7MBumD+XOQw4Nw+ZCKNym8iNfGc2C+Z8fXdClzPFv7U4DkUACjV jhTbtU69blEQrz7eo8jUiWUkNf3tlWhWJNvTNvnhV05/MzRyTsVAVR2PSp/8lUHLioMUiO2Terbr73 nvYsgQ665CtqmXQ3cxY1R34ezdHg3anBDQVHNqe5vYhpeSQu4kWKGxJl8oMdmUvALR2dcRkkGsqDqQ S57MHA5TwPoykQknM9cRQU56wYbACQQ== X-MHO-RoutePath: aGlwcGll X-MHO-User: f6f943d3-d8c4-11ea-b630-6b8aa7872eb8 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (c-67-177-211-60.hsd1.co.comcast.net [67.177.211.60]) by outbound4.ore.mailhop.org (Halon) with ESMTPSA id f6f943d3-d8c4-11ea-b630-6b8aa7872eb8; Fri, 07 Aug 2020 15:45:08 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id 077Fj5oG042620; Fri, 7 Aug 2020 09:45:05 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <5456249cc4128924a57729905b561ad39bc8663e.camel@freebsd.org> Subject: Re: svn commit: r364010 - head/sbin/iscontrol From: Ian Lepore To: Emmanuel Vadot , rgrimes@freebsd.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Fri, 07 Aug 2020 09:45:05 -0600 In-Reply-To: <20200807173214.0f831da5ab649eec811b2466@bidouilliste.com> References: <202008071219.077CJLbH085411@repo.freebsd.org> <202008071526.077FQ0uQ017440@gndrsh.dnsmgr.net> <20200807173214.0f831da5ab649eec811b2466@bidouilliste.com> Content-Type: text/plain; charset="ASCII" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4BNV6t5zpqz4YtH X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; local_wl_from(0.00)[freebsd.org]; ASN(0.00)[asn:16509, ipnet:54.148.0.0/15, country:US] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Aug 2020 15:45:11 -0000 On Fri, 2020-08-07 at 17:32 +0200, Emmanuel Vadot wrote: > On Fri, 7 Aug 2020 08:26:00 -0700 (PDT) > "Rodney W. Grimes" wrote: > > > > Author: manu > > > Date: Fri Aug 7 12:19:21 2020 > > > New Revision: 364010 > > > URL: https://svnweb.freebsd.org/changeset/base/364010 > > > > > > Log: > > > pkgbase: We can't easily have a package with either a - or a _ > > > > Wow, hopefully this is short term. > > Not really. > > > I would think a package name can be any valid file name, and to > > remove - and _ from that set is going > > to cause lots of POLA. > > The package file itself contain '-', they are named > FreeBSD--{dbg,lib32,dev,}-. it's just that we used - > and > _ when building them to get some variable which contain the > description, nothing that can't be patched by this is clearly not my > priority. > This should be easy to fix. Use sed instead of tr, and translate - to __ to remove dashes, and then translate __ back to - to restore them, and you've properly preserved single _ usage in names. -- Ian > > > > > > > > Rename iscsi_legacy to iscsilegacy, having - or _ in a package > > > name cause > > > problems when we process them and generate the ucl. > > > > > > Modified: > > > head/sbin/iscontrol/Makefile > > > > > > Modified: head/sbin/iscontrol/Makefile > > > ================================================================= > > > ============= > > > --- head/sbin/iscontrol/Makefile Fri Aug 7 10:20:39 2020 ( > > > r364009) > > > +++ head/sbin/iscontrol/Makefile Fri Aug 7 12:19:21 2020 ( > > > r364010) > > > @@ -1,6 +1,6 @@ > > > # $FreeBSD$ > > > > > > -PACKAGE=iscsi_legacy > > > +PACKAGE=iscsilegacy > > > SRCS= iscontrol.c pdu.c fsm.c config.c login.c auth_subr.c > > > misc.c > > > PROG= iscontrol > > > LIBADD= cam md > > > > > > > -- > > Rod Grimes > > rgrimes@freebsd.org > >