From owner-freebsd-bugs Tue Jul 14 17:00:47 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id RAA06095 for freebsd-bugs-outgoing; Tue, 14 Jul 1998 17:00:47 -0700 (PDT) (envelope-from owner-freebsd-bugs@FreeBSD.ORG) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id RAA06062 for ; Tue, 14 Jul 1998 17:00:43 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id RAA10250; Tue, 14 Jul 1998 17:00:01 -0700 (PDT) Date: Tue, 14 Jul 1998 17:00:01 -0700 (PDT) Message-Id: <199807150000.RAA10250@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.ORG From: Bruce Evans Subject: Re: kern/7282: some old and rarely used drivers have apparently become broken Reply-To: Bruce Evans Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org The following reply was made to PR kern/7282; it has been noted by GNATS. From: Bruce Evans To: FreeBSD-gnats-submit@FreeBSD.ORG, woods@zeus.leitch.com Cc: erich@rrnet.com Subject: Re: kern/7282: some old and rarely used drivers have apparently become broken Date: Wed, 15 Jul 1998 09:57:27 +1000 > It would seem as though all drivers were not converted to use > the new driver ioctl() interface, i.e. the the one where driver > ioctl() routines should not use copyin()/copyout() because this > is done for them one level up. It's not new. It's (much?) older than Net/3, much older than any FreeBSD driver. > Possibly even mention in copyin.9 et al that these routines > should not be used in driver ioctl() routines. But they should be used if the data is larger than will fit in the ioctl data. labpc uses them to copy rather small data that probably should have been put in the ioctl data. If DSI_SOFT_MODEM is configured, then sio uses copyin() to copy arbitrarly large data (large enough to use all of kernel memory :-(). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message