From owner-freebsd-ports-bugs@freebsd.org Mon Jul 20 02:09:41 2015 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 42FA49A5CB8 for ; Mon, 20 Jul 2015 02:09:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1561318AC for ; Mon, 20 Jul 2015 02:09:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id t6K29eAN009638 for ; Mon, 20 Jul 2015 02:09:40 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 201703] [PATCH] textproc/p5-EBook-Tools: update to 0.5.4, fix tidy usage Date: Mon, 20 Jul 2015 02:09:41 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: jason.unovitch@gmail.com X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jul 2015 02:09:41 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201703 --- Comment #1 from Jason Unovitch --- Hello maintainer of p5-Ebook-Tools, I've been looking at updating textproc/p5-Ebook-Tools based on efforts in bug 200631. This is the only port left that is currently referencing the old www/tidy port that has a security issue that still needs to be fixed. If we opt to remove it we'll need to adjust this port to use tidy5. What I found is the current p5-Ebook-Tools is broken with regards to tidy usage. It tried to use 'tidy' when 'tidy4' is the installed binary. So while here to make sure tidy5 works, I updated the port. == Runtime testing == == 0.4.9_2 == # ebook tidyxml /usr/ports/security/vuxml/vuln.xml Can't exec "tidy": No such file or directory at /usr/local/lib/perl5/site_perl/EBook/Tools.pm line 6812. Tidy did something unexpected (return value=-1). Check all output. at /usr/local/bin/ebook line 1383. Once I fix line 92 of /usr/local/bin/ebook to fall back to tidy4, it works. I ran these two commands to get a baseline of what output to expect before. # ebook tidyxml /usr/ports/security/vuxml/vuln.xml # ebook tidyxhtml /usr/local/share/doc/bash/bash.htmldoc/bash/bash.html == 0.5.4 == After the 0.5.4 update, I checked the same two commands. The different versions of tidy produce different white space padding but aside from that the output appears to be the same. I visually inspected the resulting HTML with Firefox and it looks fine in both the old and new. # ebook tidyxml /usr/ports/security/vuxml/vuln.xml # ebook tidyxhtml /usr/local/share/doc/bash/bash.htmldoc/bash/bash.html -- You are receiving this mail because: You are the assignee for the bug.