From owner-svn-src-all@FreeBSD.ORG Mon May 25 14:58:07 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5DB5953E; Mon, 25 May 2015 14:58:07 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 393B269B; Mon, 25 May 2015 14:58:07 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (pool-173-54-116-245.nwrknj.fios.verizon.net [173.54.116.245]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 01C7EB915; Mon, 25 May 2015 10:58:05 -0400 (EDT) From: John Baldwin To: Chagin Dmitry Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r283424 - in head/sys: amd64/linux modules/linux64 Date: Mon, 25 May 2015 10:40:09 -0400 Message-ID: <3590632.VFQBH2fsZP@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.1-STABLE; KDE/4.14.3; amd64; ; ) In-Reply-To: <20150525140421.GA17366@dchagin.static.corbina.net> References: <201505241607.t4OG7C7b073936@svn.freebsd.org> <2938779.SXzlp9bc0j@ralph.baldwin.cx> <20150525140421.GA17366@dchagin.static.corbina.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Mon, 25 May 2015 10:58:05 -0400 (EDT) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 May 2015 14:58:07 -0000 On Monday, May 25, 2015 05:04:21 PM Chagin Dmitry wrote: > On Mon, May 25, 2015 at 07:48:49AM -0400, John Baldwin wrote: > > On Sunday, May 24, 2015 04:07:12 PM Dmitry Chagin wrote: > > > Author: dchagin > > > Date: Sun May 24 16:07:11 2015 > > > New Revision: 283424 > > > URL: https://svnweb.freebsd.org/changeset/base/283424 > > > > > > Log: > > > Add preliminary support for x86-64 Linux binaries. > > > > > > Differential Revision: https://reviews.freebsd.org/D1076 > > > > > > Added: > > > head/sys/amd64/linux/ > > > head/sys/amd64/linux/Makefile (contents, props changed) > > > head/sys/amd64/linux/linux.h (contents, props changed) > > > head/sys/amd64/linux/linux_dummy.c (contents, props changed) > > > head/sys/amd64/linux/linux_genassym.c (contents, props changed) > > > head/sys/amd64/linux/linux_ipc64.h (contents, props changed) > > > head/sys/amd64/linux/linux_locore.s (contents, props changed) > > > head/sys/amd64/linux/linux_machdep.c (contents, props changed) > > > head/sys/amd64/linux/linux_support.s (contents, props changed) > > > head/sys/amd64/linux/linux_sysvec.c (contents, props changed) > > > head/sys/amd64/linux/linux_vdso.lds.s (contents, props changed) > > > head/sys/amd64/linux/syscalls.conf (contents, props changed) > > > head/sys/amd64/linux/syscalls.master (contents, props changed) > > > head/sys/modules/linux64/ > > > head/sys/modules/linux64/Makefile (contents, props changed) > > > > First, I'm really happy to see this land in HEAD! > Thanks! > > > > > Second, __FreeBSD_version bump perhaps? > dim@ bumped, is that enough? That is fine to reuse, but it should probably be explicitly noted in the comments for that version that it is both for clang 3.6.1 and for x86-64 Linux support. I imagine the ports tree will know which versions include your changes. Also, I don't read ports commits since src is enough of a firehouse, so I have a naive question: is the ports tree updated to supply a 64-bit linux-base? Maybe a mail to current@ on how to use a 64-bit base, etc.? Some other related questions are: can we revive print/acroread now and or use a 64-bit flash plugin after these changes? -- John Baldwin