From owner-cvs-src@FreeBSD.ORG Wed May 14 09:07:47 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 90AF0106566C; Wed, 14 May 2008 09:07:47 +0000 (UTC) (envelope-from jh@saunalahti.fi) Received: from gw02.mail.saunalahti.fi (gw02.mail.saunalahti.fi [195.197.172.116]) by mx1.freebsd.org (Postfix) with ESMTP id 4E3028FC12; Wed, 14 May 2008 09:07:47 +0000 (UTC) (envelope-from jh@saunalahti.fi) Received: from a91-153-116-186.elisa-laajakaista.fi (a91-153-116-186.elisa-laajakaista.fi [91.153.116.186]) by gw02.mail.saunalahti.fi (Postfix) with SMTP id 5928E139492; Wed, 14 May 2008 11:43:34 +0300 (EEST) Date: Wed, 14 May 2008 11:43:34 +0300 From: Jaakko Heinonen To: Craig Rodrigues Message-ID: <20080514084333.GB2388@a91-153-116-186.elisa-laajakaista.fi> References: <200804040150.m341owGT075760@repoman.freebsd.org> <20080404085746.GB19086@dg.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080404085746.GB19086@dg.local> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: Yar Tikhiy , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sbin/fsck_ffs main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 May 2008 09:07:47 -0000 Hi, On 2008-04-04, Yar Tikhiy wrote: > On Fri, Apr 04, 2008 at 01:50:58AM +0000, Craig Rodrigues wrote: > > diff -u src/sbin/fsck_ffs/main.c:1.49 src/sbin/fsck_ffs/main.c:1.50 > > --- src/sbin/fsck_ffs/main.c:1.49 Wed Mar 5 08:25:49 2008 > > +++ src/sbin/fsck_ffs/main.c Fri Apr 4 01:50:58 2008 > > @@ -541,6 +541,10 @@ > > build_iovec(&iov, &iovlen, "errmsg", errmsg, > > sizeof(errmsg)); > > build_iovec(&iov, &iovlen, "update", NULL, 0); > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > As I've already pointed out, this line you also added is dangerous > because it installs the string "update" to among the root mount > point options, which may blow up later with more changes to the > mount framework. The option still needs to be spelled MNT_UPDATE > and passed as a flag for now. There's also a similar problem with "snapshot" mount option. See these problem reports: kern/122833 kern/118360 Problems are caused by the fact that "snapshot" mount option persist after a nmount(2) call. "update" and "snapshot" shouldn't be permanent mount options. # mount -u -o snapshot /.snap/foo / # mount -u -o atime / mount: /dev/ad2s1a : Cross-device link # mount -u -o nosnapshot / # mount -u -o atime / # Oh, and the original bug still kind of exists: (boot to single user mode) # mount /dev/ad2s1a on / (ufs, local, read-only) devfs on /dev (devfs, local) # mount -o noatime / # mount /dev/ad2s1a on / (ufs, local, noatime) devfs on /dev (devfs, local) # (/ is now read-write) -- Jaakko