From owner-svn-ports-all@FreeBSD.ORG Fri Feb 1 00:36:14 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 314B1DA1 for ; Fri, 1 Feb 2013 00:36:14 +0000 (UTC) (envelope-from timur@bat.ru) Received: from mail-we0-x232.google.com (we-in-x0232.1e100.net [IPv6:2a00:1450:400c:c03::232]) by mx1.freebsd.org (Postfix) with ESMTP id BB577DFC for ; Fri, 1 Feb 2013 00:36:13 +0000 (UTC) Received: by mail-we0-f178.google.com with SMTP id x48so2484632wey.23 for ; Thu, 31 Jan 2013 16:36:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=j2YU0eXcDjnssO5yST21VorWFCgSskrGWdecCRFhUzE=; b=LXZU61p428JAvaSFFA4clmzyFN4JrYRjYpyB4dDdacGtF/ZZszxVBRRy0BCYaD2bYE hUcp9J0l2uBvHZpSx5g4HQtD+tsIyNLCTlcs7Igjm0Q5vsuSQILdDHpYYMMAeh41wlvl tKXdvcmJ+pjfcRYruJS4w82Ef80z8p+uD+vu7NCtiaRaVarM1e++wYnMtdWEB+gQ6ELQ rdHwRa4GLotPW3XIcxQN3gkgRuABkm3M5nCLdW92Ajo46yJcoXpPne1lX26vnavKUVdu eO+Uq8fy6IXhB3Sq9IlaqzcpTgcZDNfcdWWwJiVIKgP2h53AAXKZymaKCR4I0jVaNzxX oH5w== X-Received: by 10.194.20.231 with SMTP id q7mr18557682wje.44.1359678972543; Thu, 31 Jan 2013 16:36:12 -0800 (PST) MIME-Version: 1.0 Sender: timur@bat.ru Received: by 10.194.152.74 with HTTP; Thu, 31 Jan 2013 16:35:52 -0800 (PST) In-Reply-To: References: <201301311914.r0VJE8R8091684@svn.freebsd.org> <510ACB0F.9040402@FreeBSD.org> From: "Timur I. Bakeyev" Date: Fri, 1 Feb 2013 01:35:52 +0100 X-Google-Sender-Auth: jTEIqIXetnA37s0w061y89bsFGQ Message-ID: Subject: Re: svn commit: r311324 - in head: . misc/amanda-server misc/amanda25-server misc/amanda26-server misc/amanda32-server misc/instant-server net-im/kpopup net-im/linpopup net/jags net/lanbrowsing net/pro... To: Eitan Adler X-Gm-Message-State: ALoCoQneP/psuX4FcMGbXCHfWan/fTKUiy19h+6SXqfgcu8EV6CcwCQjBqf9+B6UGQw/mS+9a/w4 Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Bryan Drewery X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Feb 2013 00:36:14 -0000 Sorry, forgot to mention that fix, did it almost automatically... On Fri, Feb 1, 2013 at 12:34 AM, Eitan Adler wrote: > On 31 January 2013 14:50, Bryan Drewery wrote: > > On 1/31/2013 1:14 PM, Timur I. Bakeyev wrote: > >> .if defined (WITH_SAMBA) > >> -SAMBA_PORT?= samba34 > >> +SAMBA_PORT?= samba36 > >> BUILD_DEPENDS+= smbclient:${PORTSDIR}/net/${SAMBA_PORT} > >> RUN_DEPENDS+= smbclient:${PORTSDIR}/net/${SAMBA_PORT} > >> -CONFIGURE_ARGS+= --with-smbclient=${PREFIX}/bin/smbclient > >> +CONFIGURE_ARGS+= --with-smbclient=${LOCALBASE}/bin/smbclient > > > > Shouldn't PREFIX be respected and LOCALBASE just the default? > > This diff is correct. PREFIX is where samba will be installed to. > LOCALBASE refers to where things are already installed. In this case > smbclient is a build and run depend, which means is already installed > (and therefore in LOCALBASE). > > I wish the commit log were more clear. > > -- > Eitan Adler > Source, Ports, Doc committer > Bugmeister, Ports Security teams >