From owner-freebsd-arch@FreeBSD.ORG  Sat Jun  9 10:36:13 2007
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
X-Original-To: arch@freebsd.org
Delivered-To: freebsd-arch@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 7646C16A41F
	for <arch@freebsd.org>; Sat,  9 Jun 2007 10:36:13 +0000 (UTC)
	(envelope-from rdivacky@vlk.vlakno.cz)
Received: from vlakno.cz (vlk.vlakno.cz [62.168.28.247])
	by mx1.freebsd.org (Postfix) with ESMTP id 3016D13C447
	for <arch@freebsd.org>; Sat,  9 Jun 2007 10:36:12 +0000 (UTC)
	(envelope-from rdivacky@vlk.vlakno.cz)
Received: from localhost (localhost [127.0.0.1])
	by vlakno.cz (Postfix) with ESMTP id 958898BDE41;
	Sat,  9 Jun 2007 12:36:11 +0200 (CEST)
X-Virus-Scanned: amavisd-new at vlakno.cz
Received: from vlakno.cz ([127.0.0.1])
	by localhost (vlk.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id kJX+qFWiMU0o; Sat,  9 Jun 2007 12:36:10 +0200 (CEST)
Received: from vlk.vlakno.cz (localhost [127.0.0.1])
	by vlakno.cz (Postfix) with ESMTP id 8833D8BDE09;
	Sat,  9 Jun 2007 12:36:10 +0200 (CEST)
Received: (from rdivacky@localhost)
	by vlk.vlakno.cz (8.13.8/8.13.8/Submit) id l59Aa9Xl052325;
	Sat, 9 Jun 2007 12:36:09 +0200 (CEST) (envelope-from rdivacky)
Date: Sat, 9 Jun 2007 12:36:09 +0200
From: Roman Divacky <rdivacky@freebsd.org>
To: Dag-Erling Sm??rgrav <des@des.no>
Message-ID: <20070609103609.GA52234@freebsd.org>
References: <20070604162430.GA76813@freebsd.org>
	<896DB1FBFFD5A145833D9DA08CA12A85051A7F@seaxch07.desktop.isilon.com>
	<20070606074429.GA42032@freebsd.org> <4666F0FB.8020101@FreeBSD.org>
	<20070607070455.GA71012@freebsd.org>
	<896DB1FBFFD5A145833D9DA08CA12A85051A84@seaxch07.desktop.isilon.com>
	<20070607210313.GA603@freebsd.org>
	<896DB1FBFFD5A145833D9DA08CA12A85051A87@seaxch07.desktop.isilon.com>
	<20070608161322.GA27624@freebsd.org> <86myzadv21.fsf@dwp.des.no>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <86myzadv21.fsf@dwp.des.no>
User-Agent: Mutt/1.4.2.3i
Cc: Eric Lemar <eric.lemar@isilon.com>, arch@freebsd.org
Subject: Re: *at family of syscalls in FreeBSD
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 09 Jun 2007 10:36:13 -0000

On Fri, Jun 08, 2007 at 10:56:38PM +0200, Dag-Erling Sm??rgrav wrote:
> Roman Divacky <rdivacky@freebsd.org> writes:
> > On Thu, Jun 07, 2007 at 05:56:39PM -0700, Eric Lemar wrote:
> > > Obviously I prefer the wrapping, but I'm just a tad biased :)
> > well.. unless I hear some strong voice to change what I have I am not
> > changing it. it can always be changed in future.
> 
> I would strongly urge you to consider following Eric's suggestion; it is
> conceptually far cleaner.

ok, that was the strong voice I wanted to hear :) the patch is here:

www.vlakno.cz/~rdivacky/linux_at.patch

changes:

I consistently use the mode of having

kern_foo() {
	return kern_fooat(..., AT_FDCWD);
}

and kern_fooat() being the complete syscall calling the kern_get_at(). There is no
kern_common_foo() anymore.


the only comment from Eric now is the flags parameter but I don't think we should implement
it right now as we don't have any use for it so the patch is ok as it is. we will add the
flags parameter once we implement some functionality using it.

comments?

roman