From owner-freebsd-threads@FreeBSD.ORG Fri Nov 27 13:23:29 2009 Return-Path: Delivered-To: threads@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 15A1E1065670 for ; Fri, 27 Nov 2009 13:23:29 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (skuns.zoral.com.ua [91.193.166.194]) by mx1.freebsd.org (Postfix) with ESMTP id 5CF388FC12 for ; Fri, 27 Nov 2009 13:23:27 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id nARDCg4H023309 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 27 Nov 2009 15:12:42 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id nARDCgvV012074; Fri, 27 Nov 2009 15:12:42 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id nARDCgdY012073; Fri, 27 Nov 2009 15:12:42 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 27 Nov 2009 15:12:42 +0200 From: Kostik Belousov To: Joe Marcus Clarke Message-ID: <20091127131242.GA2368@deviant.kiev.zoral.com.ua> References: <1259298918.1608.19.camel@shumai.marcuscom.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="AhhlLboLdkugWU4S" Content-Disposition: inline In-Reply-To: <1259298918.1608.19.camel@shumai.marcuscom.com> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: threads@freebsd.org Subject: Re: [PATCH] Add missing pthread_condattr_{init, destroy} stubs to libc X-BeenThere: freebsd-threads@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Threading on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Nov 2009 13:23:29 -0000 --AhhlLboLdkugWU4S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 27, 2009 at 12:15:18AM -0500, Joe Marcus Clarke wrote: > I would like permission to commit this patch which adds missing > pthread_condattr_{init,destroy} symbols to libc. I think I did the > symbol addition correctly (and it seems to work). Without this, the > weak symbols added in the libpthread-stubs port conflict with those in > libthr, and applications with use these symbols can crash. >=20 > I have temporarily hacked libpthread-stubs to fix this, but I really > feel these stubs should be added to libc. I've also copied kib as he > has been kind enough to review my work in the past. Thanks. >=20 > http://www.marcuscom.com/downloads/stubs.diff It is FBSD_1.2 version that we use for symbols added after HEAD become CURRENT-9. I think that you shall change lib/libc/libc_private.h, adding corresponding definitions for the PJT_CONDATTR_DESTROY/PJT_CONDATTR_INIT indexes. Is the patch buildable ? Interesting question is whether these changes are mergeable to the stable branch. Possibly yes, if we declare that rtld/libc/libthr shall be built from the consistent source snapshot. --AhhlLboLdkugWU4S Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAksP0EoACgkQC3+MBN1Mb4hTNwCgpNcCKfhO4bbUXxt3Kv2wfm/W c6UAoNR/VPVfGKxjG5tN3xxx4pDDkmIK =qujH -----END PGP SIGNATURE----- --AhhlLboLdkugWU4S--