From owner-cvs-all@FreeBSD.ORG  Thu Mar 20 11:00:49 2008
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5DB47106566C;
	Thu, 20 Mar 2008 11:00:49 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 1679D8FC2D;
	Thu, 20 Mar 2008 11:00:49 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [209.31.154.41])
	by cyrus.watson.org (Postfix) with ESMTP id 4D03946B94;
	Thu, 20 Mar 2008 07:00:48 -0400 (EDT)
Date: Thu, 20 Mar 2008 11:00:48 +0000 (GMT)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Doug Rabson <dfr@rabson.org>
In-Reply-To: <F042E351-95A3-4C9A-92AF-878CB0F93EBE@rabson.org>
Message-ID: <20080320105941.H38241@fledge.watson.org>
References: <200803191233.m2JCXPRp070753@repoman.freebsd.org>
	<20080320025645.GI67856@elvis.mu.org>
	<F042E351-95A3-4C9A-92AF-878CB0F93EBE@rabson.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: cvs-src@FreeBSD.org, Doug Rabson <dfr@FreeBSD.org>,
	Alfred Perlstein <alfred@freebsd.org>, cvs-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: cvs commit: src/sys/nfsserver nfs_srvsock.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Mar 2008 11:00:49 -0000

On Thu, 20 Mar 2008, Doug Rabson wrote:

>> This function should have a WITNESS check at the top of it.
>> 
>> Can you add it?  If not I will unless you see a problem with it.
>
> The various WITNESS_* macros appear to be undocumented and I'm not sure what 
> they do. Perhaps it would be best if you added something.

I usually copy and paste it from another use, such as the sleep checks for the 
MAC Framework.  When I do that, I often think to myself: wouldn't it be nice 
if we had a simple WITNESS_MAYSLEEP() macro to say "this code path may sleep, 
just do whateve ryou're going to do".

Robert N M Watson
Computer Laboratory
University of Cambridge