From owner-svn-src-all@FreeBSD.ORG Fri Oct 25 10:03:20 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 64DB450F; Fri, 25 Oct 2013 10:03:20 +0000 (UTC) (envelope-from prvs=101050af22=killing@multiplay.co.uk) Received: from mail1.multiplay.co.uk (mail1.multiplay.co.uk [85.236.96.23]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A9FF42AA1; Fri, 25 Oct 2013 10:03:19 +0000 (UTC) Received: from r2d2 ([82.69.141.170]) by mail1.multiplay.co.uk (mail1.multiplay.co.uk [85.236.96.23]) (MDaemon PRO v10.0.4) with ESMTP id md50006501204.msg; Fri, 25 Oct 2013 11:03:17 +0100 X-Spam-Processed: mail1.multiplay.co.uk, Fri, 25 Oct 2013 11:03:17 +0100 (not processed: message from valid local sender) X-MDDKIM-Result: neutral (mail1.multiplay.co.uk) X-MDRemoteIP: 82.69.141.170 X-Return-Path: prvs=101050af22=killing@multiplay.co.uk X-Envelope-From: killing@multiplay.co.uk Message-ID: <2DE0EA95F6944DB28D4B2F03EEF582F8@multiplay.co.uk> From: "Steven Hartland" To: "Dimitry Andric" References: <201310250909.r9P990nk083926@svn.freebsd.org> Subject: Re: svn commit: r257109 - head/contrib/llvm/tools/clang/tools/driver Date: Fri, 25 Oct 2013 11:03:16 +0100 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="Windows-1252"; reply-type=original Content-Transfer-Encoding: 8bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.5931 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Oct 2013 10:03:20 -0000 > On 25 Oct 2013, at 11:09, Steven Hartland wrote: > > Author: smh > > Date: Fri Oct 25 09:09:00 2013 > > New Revision: 257109 > > URL: http://svnweb.freebsd.org/changeset/base/257109 > > > > Log: > > Add clang-CC and CC to list of hints allowing clang to identify its operating > > mode as c++ instead of defaulting to c for the binary names CC and clang-CC. > > > > This fixes builds that use cmake, which automatically sets CXX to > > /usr/bin/CC by default. > > Huh, I’ve never seen that behavior with cmake? At least, not with any > fairly recent version... > > Anyway, I do not really agree with this change, and I would rather just > get rid of the /usr/bin/CC link instead. Build scripts and Makefiles > should use "c++" instead, which is the standard name for a C++ compiler. > > Note that you also introduce yet another change from upstream... :-/ As discussed on IRC while I agree removing CC is possibly the better fix moving forward, I think removing /usr/bin/CC has quite a bit more risk, especially at this stage in the release phase of 10. Given this I would suggest this for now we make the change to clang and then possibly look at remove CC at a later date. If there's no objections I intend to ask re@ for permission to MFC this for the release of 10, so if there are any objections please do speak up :) Regards Steve ================================================ This e.mail is private and confidential between Multiplay (UK) Ltd. and the person or entity to whom it is addressed. In the event of misdirection, the recipient is prohibited from using, copying, printing or otherwise disseminating it or any information contained in it. In the event of misdirection, illegible or incomplete transmission please telephone +44 845 868 1337 or return the E.mail to postmaster@multiplay.co.uk.