From nobody Sat Sep 20 00:47:40 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cT9hF0Xr6z67vTb; Sat, 20 Sep 2025 00:47:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cT9hD52m6z40F2; Sat, 20 Sep 2025 00:47:40 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758329260; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XnKyji4OH2RkxNdGkPKfbhqJbxENkMVCv/VpsWyBQek=; b=kPlk+xkdj+PZjGo4Ckh0DK2N6kYWPnQtZS239GJWKyRcD1g3a2afKGhffNENKFKdGiWigR jj3tyvXHjo47jnf47u0T4cTaw/D2daU6+/kw0gNP8MAEavdZTlpjc7ahE8fw4RwKZnMitw gCQaQ57WivufVazRPzBCwgZ5gtxhZamEz3hv6MivZfqJ4QClioeVQowaSs/hfL5oDbiO/5 YfbyNkeams3diJY/AXLSNgoEy41Z3v0/Y0/MOHNr3yKgIx49uvmWH4Q27noaeg7nFh/Bit Vk9TXHJyXUyslLwwkJdCWW9/wiT17AROUu0GoizS8vPIfy3cP4oLus2Cz3xXOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758329260; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XnKyji4OH2RkxNdGkPKfbhqJbxENkMVCv/VpsWyBQek=; b=YjgG+Za6M+sg7PBLyzIAYPErIyVcscu3PceefQPn72whlK1NA0Kp1McF00VHqHGMs227GA NLprEc4/ck0NWAd7+5gJIJUx2YdFJkHh9xup2+fpotIiLsU1JPph2beM9/fbKob65vOHNE E9xJVV0EKg/ltsMx+iUgQ1p9Wnvokac2guN7n/7WKV4maCTLlvzyUcIU5jh07ThgGoHbiE N41E+tq180DDLeISdLj5QPoRp7UqhWv3ya0R8oQu3q+TSQKHd9ZrdYJc5P/YfwBJpjgPxB bjeTHor3Wd+eDprMz5R2Sb3GE2Jbqo2XYeLb5uJR2YIJOrjLvNwCPXcado+1Tg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758329260; a=rsa-sha256; cv=none; b=FfStsfrYuMxkpBC9qfDdY2n3sWCHE+BLjodb1s8QXUJxyzT5fGS9fwLXXpdZfE5bLEQYBP S8BSMmERP/y53ZKh8OcxY9nT/VHU28hYY6w0OtghxGkVqJBz/g1RKT6WFjNMozIiEKNOty Z+nhLrij75AkGXt20GFXIUDFxsOsBmd1AOV8K50DLlJwC54rGp+ODEVtdQPRUGivKQC3Uz Q7elYyRRTp0z5ZmmK3bTiDobhkQt0+2/VACsUvTLpAGLmzb6rBIZ+MCwvgyY63ZcQLva1C K9Hmc6SKXToBnLDdTvqIIy5sYRB1RUYC8e0gapkDwc/x88ZlqfA4IjuJOa3dXQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cT9hD4cCRz1KSD; Sat, 20 Sep 2025 00:47:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58K0leFQ017107; Sat, 20 Sep 2025 00:47:40 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58K0leL1017103; Sat, 20 Sep 2025 00:47:40 GMT (envelope-from git) Date: Sat, 20 Sep 2025 00:47:40 GMT Message-Id: <202509200047.58K0leL1017103@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Adrian Chadd Subject: git: a58f30788070 - main - [iwn] Don't originate NULL data frames in net80211 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: adrian X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a58f307880700fff7646416101c301e4d1784bfb Auto-Submitted: auto-generated The branch main has been updated by adrian: URL: https://cgit.FreeBSD.org/src/commit/?id=a58f307880700fff7646416101c301e4d1784bfb commit a58f307880700fff7646416101c301e4d1784bfb Author: Adrian Chadd AuthorDate: 2025-08-27 20:06:55 +0000 Commit: Adrian Chadd CommitDate: 2025-09-20 00:46:32 +0000 [iwn] Don't originate NULL data frames in net80211 Don't originate null data frames in net80211; leave that up to the iwn firmware. This should fix a bunch of cases where we're seeing out of sequence 802.11n aggregation data packets because net80211 power management stuff was triggering NULL data frames when we don't need them and messing up the firmware / ring buffer sequence number space. Differential Revision: https://reviews.freebsd.org/D52299 Locally tested: * 6205, STA mode --- sys/dev/iwn/if_iwn.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/dev/iwn/if_iwn.c b/sys/dev/iwn/if_iwn.c index 6270de3627e6..a949103f20d4 100644 --- a/sys/dev/iwn/if_iwn.c +++ b/sys/dev/iwn/if_iwn.c @@ -586,6 +586,8 @@ iwn_attach(device_t dev) /* Driver / firmware assigned sequence numbers */ ic->ic_flags_ext |= IEEE80211_FEXT_SEQNO_OFFLOAD; + /* Don't originate null data frames in net80211 */ + ic->ic_flags_ext |= IEEE80211_FEXT_NO_NULLDATA; /* Read MAC address, channels, etc from EEPROM. */ if ((error = iwn_read_eeprom(sc, ic->ic_macaddr)) != 0) {