From owner-freebsd-x11@FreeBSD.ORG Wed Apr 1 08:29:21 2015 Return-Path: Delivered-To: x11@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 384B22DC for ; Wed, 1 Apr 2015 08:29:21 +0000 (UTC) Received: from mx.nsu.ru (mx.nsu.ru [84.237.50.39]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CF59C6A1 for ; Wed, 1 Apr 2015 08:29:19 +0000 (UTC) Received: from regency.nsu.ru ([193.124.210.26]) by mx.nsu.ru with esmtp (Exim 4.72) (envelope-from ) id 1YdE1N-0004jm-JT; Wed, 01 Apr 2015 14:29:15 +0600 Received: from regency.nsu.ru (localhost [127.0.0.1]) by regency.nsu.ru (8.14.2/8.14.2) with ESMTP id t318SjAs085019; Wed, 1 Apr 2015 15:28:55 +0700 (NOVT) (envelope-from danfe@regency.nsu.ru) Received: (from danfe@localhost) by regency.nsu.ru (8.14.2/8.14.2/Submit) id t318SeX3085008; Wed, 1 Apr 2015 14:28:40 +0600 (NOVT) (envelope-from danfe) Date: Wed, 1 Apr 2015 14:28:40 +0600 From: Alexey Dokuchaev To: Koop Mast Subject: Re: INSTALLS_ICONS being gnome/gtk-oriented, pulling unneeded(?) deps for Qt-ports Message-ID: <20150401082840.GA83582@regency.nsu.ru> References: <20150331162654.GA96906@regency.nsu.ru> <551B094E.90806@rainbow-runner.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <551B094E.90806@rainbow-runner.nl> User-Agent: Mutt/1.4.2.1i X-KLMS-Rule-ID: 1 X-KLMS-Message-Action: clean X-KLMS-AntiSpam-Lua-Profiles: 75470 [Apr 01 2015] X-KLMS-AntiSpam-Version: 5.5.4 X-KLMS-AntiSpam-Envelope-From: danfe@regency.nsu.ru X-KLMS-AntiSpam-Rate: 0 X-KLMS-AntiSpam-Status: not_detected X-KLMS-AntiSpam-Method: none X-KLMS-AntiSpam-Moebius-Timestamps: 3463056, 3463091, 0 X-KLMS-AntiSpam-Info: LuaCore: 185 2015-03-31_20-04-48 fbd7c020651bd474e44ba44c47af82adc0abc7aa, 193.124.210.26:4.0.2; nsu.ru:6.3.8; regency.nsu.ru:6.3.8 X-KLMS-AntiSpam-Interceptor-Info: scan successful X-KLMS-AntiPhishing: Clean, 2015/03/31 12:29:45 X-KLMS-AntiVirus: Kaspersky Security 8.0 for Linux Mail Server, version 8.0.1.705, not scanned, license restriction Cc: x11@freebsd.org X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2015 08:29:21 -0000 On Tue, Mar 31, 2015 at 10:53:34PM +0200, Koop Mast wrote: > On 31-3-2015 18:26, Alexey Dokuchaev wrote: > >Currently, portlint(1) suggests to add INSTALLS_ICONS knob if it sees > >share/icons/hicolor/* files in pkg-plist, which in turn means USE_GNOME+= > >gtk-update-icon-cache and thus pulls things which are from Gtk+ world, > >and thus seem not quite natural for e.g. Qt-based (or even completely > >unattached) ports. > > INSTALL_ICONS is only needed for gtk ports, so Qt ports don't need it. I > guess the check should be updated to take that into account, but it > might be complex to do so. Thanks; nice to know Qt ports do not need it. Having such vaguely-named knob certainly adds to confusion. Can its logic be turned into automatic detection of share/icons/hicolor/* in plist and calling appropriate icon- cache update commands? Telling the framework something that it should be able to detect itself looks bogus. ./danfe