From owner-cvs-gnu Fri Aug 30 09:50:05 1996 Return-Path: owner-cvs-gnu Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id JAA04742 for cvs-gnu-outgoing; Fri, 30 Aug 1996 09:50:05 -0700 (PDT) Received: from spinner.DIALix.COM (spinner.DIALix.COM [192.203.228.67]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id JAA04696; Fri, 30 Aug 1996 09:49:48 -0700 (PDT) Received: from spinner.DIALix.COM (localhost.DIALix.oz.au [127.0.0.1]) by spinner.DIALix.COM (8.7.5/8.7.3) with ESMTP id AAA02200; Sat, 31 Aug 1996 00:49:35 +0800 (WST) Message-Id: <199608301649.AAA02200@spinner.DIALix.COM> To: =?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?= (Andrey A. Chernov) cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-gnu@freefall.freebsd.org Subject: Re: cvs commit: src/gnu/lib/libreadline Makefile In-reply-to: Your message of "Fri, 30 Aug 1996 14:30:44 +0400." <199608301030.OAA00587@nagual.ru> Date: Sat, 31 Aug 1996 00:49:35 +0800 From: Peter Wemm Sender: owner-cvs-gnu@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk =?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?= wrote: > > peter 96/08/29 19:13:09 > > > > Modified: gnu/lib/libreadline Makefile > > Log: > > cmp -s || install -c ==> install -C > > Add -DHAVE_UNISTD_H -DHAVE_STDLIB_H to get these files > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > Please, back out this change, they already defined in config.h The following files dont include config.h or rldefs.h at all: funmap.c history.c isearch.c tilde.c xmalloc.c (rldefs.h #include's config.h as well) Those files do test the HAVE_x_H defines to #include unistd.h or stdlib.h. The choice was add the defines to the CFLAGS, or change those files and diverge from their gnu counterparts. Since the Makefile is under our control, but the source is 3rd party, it made sense to me at the time to change the Makefile. > -- > Andrey A. Chernov > > http://www.nagual.ru/~ache/ Cheers, -Peter