From nobody Thu Jan 18 20:15:24 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TGDWc6Z4Zz56tR0; Thu, 18 Jan 2024 20:15:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TGDWc2ZKrz4YQ0; Thu, 18 Jan 2024 20:15:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1705608924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=F2vI2CktHqdvix4dMV6UFBfZmfSS1sEt7BaF/mAbA/4=; b=XbY5gpRhe9xBXoQ9xoIAaaxWExEGqWaeXmfsbu0ekwhhzCulgotlrPRwFNT+X+IqVMDgmP BudtxhcbHWszIlkSnEowsKsebgPml+VGT9dYSU7uEAMwLnVTkCWjHv+fayqtAtpQ7faTT3 rZCsZ+IlQ8gVAK0Ojb5FP6YW2zfMRIzdrE+KhmGueJCRYMb05QG/+jZi6RHeHjjcKoE1/C 3wcm/lERlBO52EJH4RnVcHkjM9orU0BfWB+pd5qSIv00zLBDW/i22Pqv9eQRxCa9vbmNbS BMWi45zQlvdA5whUZjiJG5MN6ozR9W8GASdzfIOH5+akMYfrNv+xgdtcjVlXmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1705608924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=F2vI2CktHqdvix4dMV6UFBfZmfSS1sEt7BaF/mAbA/4=; b=mEh5REvElQbeUPJXlxSnJSr1pyCeIfSnxOvfto983fa+jzE8P6AmT0mot2LgN6fuS2MmH+ /8bYQsIi4t8Sf/q8MXlp6bhEFU+SMuLZcvdiUR5Rh7G1lXQrZ3O5HQMLeAxF/FXarfRAPx 9pqTICitJ9I+EEWJIV5EY76WIKnoNzHhCug0D49I+aVIbQ9pBB5mUlUF3LjsyEhV4By9M7 HqfRkHkuR8NM/x84kQJtwzp3RB/FKhyu9VLrLK19jZ0247QsUW49mdOQw5OE7NgdMxFfMH 1H2BWHUVzjqmZQAKX+fj90IPqLMhsvBUOWOr10pE3ajSCxVT5ZU1z98Pt6memA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1705608924; a=rsa-sha256; cv=none; b=Oh6wPtbbwaRbnEgA4kTBvmrTPFRvcJw6NWE3HeyQ5Pniw9ms7qz5xAUrCdYHotqQQd+GUi sor0u35aZ1ecsj9wCpNZMq6JUN/tLgkhQxoN81Y8nGijE1FL/7AHe2PC3iJgmumWs7dtsS +9kdEpqLYh6nAanrDzct3l27AR9nwJ63d219MJNxnw70RiGoaL5WbQVwOLiM1jyVIgmTxl Dn0BPa9iRDx4Kt1I1VB3v2ASpZjmRObjl5FCz981AmouZG2DRcA9of8YwSILTuG2EV1Dj1 RQWPGLUfN4HbQrdOk4zwZ8Qj3BTSsD4DLHN2X70eEXMZwEXEcgw+WY/O9utktg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TGDWc1CxyzM7Y; Thu, 18 Jan 2024 20:15:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 40IKFORn068347; Thu, 18 Jan 2024 20:15:24 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 40IKFOXp068343; Thu, 18 Jan 2024 20:15:24 GMT (envelope-from git) Date: Thu, 18 Jan 2024 20:15:24 GMT Message-Id: <202401182015.40IKFOXp068343@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Marius Strobl Subject: git: bf81fc51ccf0 - stable/13 - igb(4): Remove disconnected SYSCTL List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: marius X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: bf81fc51ccf04a6ae58f7c4d281266d5ab59d4e0 Auto-Submitted: auto-generated The branch stable/13 has been updated by marius: URL: https://cgit.FreeBSD.org/src/commit/?id=bf81fc51ccf04a6ae58f7c4d281266d5ab59d4e0 commit bf81fc51ccf04a6ae58f7c4d281266d5ab59d4e0 Author: Marius Strobl AuthorDate: 2024-01-09 22:01:46 +0000 Commit: Marius Strobl CommitDate: 2024-01-18 20:14:56 +0000 igb(4): Remove disconnected SYSCTL The global hw.igb.rx_process_limit knob never was adhered to by the in-tree version of this driver but similar functionality is available via the device-specific dev.igb.N.iflib.rx_budget. While at it, remove the - besides initialization of tx_process_limit - unused {r,t}x_process_limit members. (cherry picked from commit f221d35be7a5749e2a1246c81adc9c03c1dc545c) --- share/man/man4/igc.4 | 6 +----- sys/dev/igc/if_igc.c | 9 --------- sys/dev/igc/if_igc.h | 2 -- 3 files changed, 1 insertion(+), 16 deletions(-) diff --git a/share/man/man4/igc.4 b/share/man/man4/igc.4 index bc8c3547230d..e3dc7da65713 100644 --- a/share/man/man4/igc.4 +++ b/share/man/man4/igc.4 @@ -3,7 +3,7 @@ .\" Copyright 2021 Rubicon Communications, LLC (Netgate) .\" SPDX-License-Identifier: BSD-3-Clause .\" -.Dd May 10, 2021 +.Dd January 9, 2023 .Dt IGC 4 .Os .Sh NAME @@ -119,10 +119,6 @@ maximum delay in which a transmit interrupt is generated. .It Va hw.igc.sbp Show bad packets when in promiscuous mode. Default is false. -.It Va hw.igc.rx_process_limit -Maximum number of received packets to process at a time. -Default is 100. -A value of -1 means unlimited. .It Va hw.igc.eee_setting Disable or enable Energy Efficient Ethernet. Default 1 (disabled). diff --git a/sys/dev/igc/if_igc.c b/sys/dev/igc/if_igc.c index 3e05d1a7b957..8de044169269 100644 --- a/sys/dev/igc/if_igc.c +++ b/sys/dev/igc/if_igc.c @@ -255,13 +255,6 @@ static int igc_debug_sbp = true; SYSCTL_INT(_hw_igc, OID_AUTO, sbp, CTLFLAG_RDTUN, &igc_debug_sbp, 0, "Show bad packets in promiscuous mode"); -/* How many packets rxeof tries to clean at a time */ -static int igc_rx_process_limit = 100; -SYSCTL_INT(_hw_igc, OID_AUTO, rx_process_limit, CTLFLAG_RDTUN, - &igc_rx_process_limit, 0, - "Maximum number of received packets to process " - "at a time, -1 means unlimited"); - /* Energy efficient ethernet - default to OFF */ static int igc_eee_setting = 1; SYSCTL_INT(_hw_igc, OID_AUTO, eee_setting, CTLFLAG_RDTUN, &igc_eee_setting, 0, @@ -467,8 +460,6 @@ igc_if_attach_pre(if_ctx_t ctx) adapter->media = iflib_get_media(ctx); hw = &adapter->hw; - adapter->tx_process_limit = scctx->isc_ntxd[0]; - /* SYSCTL stuff */ SYSCTL_ADD_PROC(device_get_sysctl_ctx(dev), SYSCTL_CHILDREN(device_get_sysctl_tree(dev)), diff --git a/sys/dev/igc/if_igc.h b/sys/dev/igc/if_igc.h index 382931468ade..fde9429b5360 100644 --- a/sys/dev/igc/if_igc.h +++ b/sys/dev/igc/if_igc.h @@ -372,8 +372,6 @@ struct igc_adapter { u32 txd_cmd; - u32 tx_process_limit; - u32 rx_process_limit; u32 rx_mbuf_sz; /* Management and WOL features */