From owner-freebsd-hackers@FreeBSD.ORG Thu Feb 12 16:33:46 2009 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5A59C10656C4 for ; Thu, 12 Feb 2009 16:33:46 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: from palm.hoeg.nl (mx0.hoeg.nl [IPv6:2001:7b8:613:100::211]) by mx1.freebsd.org (Postfix) with ESMTP id E94E28FC18 for ; Thu, 12 Feb 2009 16:33:45 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: by palm.hoeg.nl (Postfix, from userid 1000) id F14591CDD2; Thu, 12 Feb 2009 17:33:44 +0100 (CET) Date: Thu, 12 Feb 2009 17:33:44 +0100 From: Ed Schouten To: FreeBSD Hackers Message-ID: <20090212163344.GR79178@hoeg.nl> References: <200902121717.47841.max@love2party.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3sseE1tnmEs+TkKq" Content-Disposition: inline In-Reply-To: <200902121717.47841.max@love2party.net> User-Agent: Mutt/1.5.19 (2009-01-05) Subject: Re: pahole - Finding holes in kernel structs X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Feb 2009 16:33:46 -0000 --3sseE1tnmEs+TkKq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable * Max Laier wrote: > So to answer your first question, submitting 101 patches to rearrange 101= =20 > structs is certainly a wasted effort. However, if you take a good look a= t the=20 > 2000 holes, identify an interesting subset and submit a patch to fix that= =20 > subset ... that would be a worthwhile effort ... IMHO. I guess it's also a wasted effort to reduce struct tty from 8xx to 7xx bytes, because it still allocates 1024 bytes of memory using malloc(9). I guess we should mainly focus on structures that are allocated using uma(9) or are slightly bigger than 2^n. --=20 Ed Schouten WWW: http://80386.nl/ --3sseE1tnmEs+TkKq Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkmUT2gACgkQ52SDGA2eCwX4CgCbBWWHMVpf3rWgHyw2c2djCycj +6sAn2cXisPzxeE1GAa4/fHGjd7WuQvk =pEmH -----END PGP SIGNATURE----- --3sseE1tnmEs+TkKq--