Date: Thu, 12 Oct 2017 09:06:18 +0000 (UTC) From: Mathieu Arnold <mat@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r451834 - in head: databases/mongodb32-tools databases/mongodb34-tools devel/arduino-builder devel/arduinoOTA devel/gb devel/git-codereview devel/grumpy devel/jfrog-cli editors/micro mi... Message-ID: <201710120906.v9C96IXa085282@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: mat Date: Thu Oct 12 09:06:17 2017 New Revision: 451834 URL: https://svnweb.freebsd.org/changeset/ports/451834 Log: Stripping go binaries is perfectly fine. https://dominik.honnef.co/posts/2016/10/go-and-strip/ Sponsored by: Absolight Modified: head/databases/mongodb32-tools/Makefile (contents, props changed) head/databases/mongodb34-tools/Makefile (contents, props changed) head/devel/arduino-builder/Makefile (contents, props changed) head/devel/arduinoOTA/Makefile (contents, props changed) head/devel/gb/Makefile (contents, props changed) head/devel/git-codereview/Makefile (contents, props changed) head/devel/grumpy/Makefile (contents, props changed) head/devel/jfrog-cli/Makefile (contents, props changed) head/editors/micro/Makefile (contents, props changed) head/misc/exercism/Makefile (contents, props changed) head/net-mgmt/kapacitor/Makefile (contents, props changed) head/net-mgmt/telegraf/Makefile (contents, props changed) head/net/cf/Makefile (contents, props changed) head/net/concourse-fly/Makefile (contents, props changed) head/net/nsq/Makefile (contents, props changed) head/net/rclone/Makefile (contents, props changed) head/net/syncthing-cli/Makefile (contents, props changed) head/net/syncthing-discosrv/Makefile (contents, props changed) head/security/ssh-vault/Makefile (contents, props changed) head/sysutils/consul-alerts/Makefile (contents, props changed) head/sysutils/epazote/Makefile (contents, props changed) head/sysutils/ipfs-go/Makefile (contents, props changed) head/sysutils/node_exporter/Makefile (contents, props changed) head/sysutils/nomad/Makefile (contents, props changed) head/sysutils/restic/Makefile (contents, props changed) head/sysutils/siegfried/Makefile (contents, props changed) head/sysutils/zfs-snap-diff/Makefile (contents, props changed) head/textproc/spiff/Makefile (contents, props changed) head/www/go-www/Makefile (contents, props changed) head/www/grafana3/Makefile (contents, props changed) head/www/minio-client/Makefile (contents, props changed) head/www/uchiwa/Makefile (contents, props changed) Modified: head/databases/mongodb32-tools/Makefile ============================================================================== --- head/databases/mongodb32-tools/Makefile Thu Oct 12 09:04:05 2017 (r451833) +++ head/databases/mongodb32-tools/Makefile Thu Oct 12 09:06:17 2017 (r451834) @@ -29,8 +29,6 @@ SSL_USE= my_tags=ssl ONLY_FOR_ARCHS= i386 amd64 ONLY_FOR_ARCHS_REASON= "not yet ported to anything other than i386 and amd64" -STRIP= # Stripping can break go binaries - # Go is not our friend. Without below, ignores user-supplied flags. MAKE_CMD= ${LOCALBASE}/bin/go build MAKE_ENV= GOPATH="${WRKSRC}/.gopath:${WRKSRC}/vendor" \ Modified: head/databases/mongodb34-tools/Makefile ============================================================================== --- head/databases/mongodb34-tools/Makefile Thu Oct 12 09:04:05 2017 (r451833) +++ head/databases/mongodb34-tools/Makefile Thu Oct 12 09:06:17 2017 (r451834) @@ -30,8 +30,6 @@ SSL_USE= my_tags=ssl ONLY_FOR_ARCHS= amd64 i386 ONLY_FOR_ARCHS_REASON= "not yet ported to anything other than i386 and amd64" -STRIP= # Stripping can break go binaries - # Go is not our friend. Without below, ignores user-supplied flags. MAKE_CMD= ${LOCALBASE}/bin/go build MAKE_ENV= GOPATH="${WRKSRC}/.gopath:${WRKSRC}/vendor" \ Modified: head/devel/arduino-builder/Makefile ============================================================================== --- head/devel/arduino-builder/Makefile Thu Oct 12 09:04:05 2017 (r451833) +++ head/devel/arduino-builder/Makefile Thu Oct 12 09:06:17 2017 (r451834) @@ -27,7 +27,6 @@ TOOLS_RUN_DEPENDS= arduino-tools>=${_COMPAT_VER}:devel TOOLS_PLIST_FILES= arduino/arduino-builder.options GO_ENV+= GOPATH=${WRKSRC} -STRIP= # stripping can break go binaries _COMPAT_VER= 1.6.12 _IDE_VER= 10612 Modified: head/devel/arduinoOTA/Makefile ============================================================================== --- head/devel/arduinoOTA/Makefile Thu Oct 12 09:04:05 2017 (r451833) +++ head/devel/arduinoOTA/Makefile Thu Oct 12 09:06:17 2017 (r451834) @@ -18,8 +18,6 @@ GH_TAGNAME= c2b8306 PLIST_FILES= bin/${PORTNAME} COMPILEINFO= ${OPSYS}${OSREL}-${ARCH}-${GH_TAGNAME} -STRIP= # stripping can break go binaries - do-build: (cd ${WRKSRC} && ${SETENV} ${GO_ENV} go build -o ${PORTNAME} -ldflags "-X main.compileInfo=${COMPILEINFO}" main.go) Modified: head/devel/gb/Makefile ============================================================================== --- head/devel/gb/Makefile Thu Oct 12 09:04:05 2017 (r451833) +++ head/devel/gb/Makefile Thu Oct 12 09:06:17 2017 (r451834) @@ -19,7 +19,6 @@ PLIST_FILES= bin/gb bin/gb-vendor PORTDOCS= README.md -STRIP= # stripping can break go binaries GO_PKGNAME= github.com/${GH_ACCOUNT}/${GH_PROJECT} GO_TARGET= ./... Modified: head/devel/git-codereview/Makefile ============================================================================== --- head/devel/git-codereview/Makefile Thu Oct 12 09:04:05 2017 (r451833) +++ head/devel/git-codereview/Makefile Thu Oct 12 09:06:17 2017 (r451834) @@ -16,8 +16,6 @@ GH_TAGNAME= 77ae237 PLIST_FILES= bin/git-codereview -STRIP= # stripping can break go binaries - post-patch: @${MKDIR} ${WRKSRC}/src/golang.org/x/review .for src in .gitattributes AUTHORS CONTRIBUTING.md CONTRIBUTORS LICENSE PATENTS \ Modified: head/devel/grumpy/Makefile ============================================================================== --- head/devel/grumpy/Makefile Thu Oct 12 09:04:05 2017 (r451833) +++ head/devel/grumpy/Makefile Thu Oct 12 09:06:17 2017 (r451834) @@ -25,8 +25,6 @@ PLIST_SUB= ARCH=amd64 PLIST_SUB= ARCH=386 .endif -STRIP= # stripping can break go binaries - do-install: cd ${WRKSRC}/build/pkg && ${COPYTREE_SHARE} . ${STAGEDIR}${PREFIX}/go/pkg/ cd ${WRKSRC}/build/src && ${COPYTREE_SHARE} . ${STAGEDIR}${PREFIX}/go/src/ Modified: head/devel/jfrog-cli/Makefile ============================================================================== --- head/devel/jfrog-cli/Makefile Thu Oct 12 09:04:05 2017 (r451833) +++ head/devel/jfrog-cli/Makefile Thu Oct 12 09:06:17 2017 (r451834) @@ -15,8 +15,6 @@ GH_PROJECT= jfrog-cli-go PLIST_FILES= bin/jfrog -STRIP= # stripping can break go binaries - post-extract: @${MV} ${WRKSRC}/vendor/ ${WRKSRC}/src @${MKDIR} ${WRKSRC}/src/github.com/jfrogdev/jfrog-cli-go Modified: head/editors/micro/Makefile ============================================================================== --- head/editors/micro/Makefile Thu Oct 12 09:04:05 2017 (r451833) +++ head/editors/micro/Makefile Thu Oct 12 09:06:17 2017 (r451834) @@ -37,8 +37,6 @@ GH_TUPLE= \ BUILD_HASH= 5dc8fe4 BUILD_DATE= February 10, 2017 -STRIP= # stripping can break go binaries - PLIST_FILES= bin/micro PORTDOCS= README.md Modified: head/misc/exercism/Makefile ============================================================================== --- head/misc/exercism/Makefile Thu Oct 12 09:04:05 2017 (r451833) +++ head/misc/exercism/Makefile Thu Oct 12 09:06:17 2017 (r451834) @@ -14,8 +14,6 @@ BUILD_DEPENDS= ${LOCALBASE}/bin/go:lang/go USE_GITHUB= yes GH_PROJECT= cli -STRIP= # stripping can break go binaries - PLIST_FILES= bin/exercism post-patch: Modified: head/net-mgmt/kapacitor/Makefile ============================================================================== --- head/net-mgmt/kapacitor/Makefile Thu Oct 12 09:04:05 2017 (r451833) +++ head/net-mgmt/kapacitor/Makefile Thu Oct 12 09:06:17 2017 (r451834) @@ -28,8 +28,6 @@ SUB_FILES= kapacitord SUB_LIST+= KAPACITORD_PIDDIR=${KAPACITORD_PIDDIR} PLIST_SUB= KAPACITORD_PIDDIR=${KAPACITORD_PIDDIR} -STRIP= # stripping can break go binaries - post-patch: @${MKDIR} ${WRKSRC}/src/github.com/${GH_ACCOUNT}/${PORTNAME} @cd ${WRKSRC} && ${MV} \ Modified: head/net-mgmt/telegraf/Makefile ============================================================================== --- head/net-mgmt/telegraf/Makefile Thu Oct 12 09:04:05 2017 (r451833) +++ head/net-mgmt/telegraf/Makefile Thu Oct 12 09:06:17 2017 (r451834) @@ -90,8 +90,6 @@ SUB_FILES= telegraf SUB_LIST+= TELEGRAF_PIDDIR=${TELEGRAF_PIDDIR} PLIST_SUB= TELEGRAF_PIDDIR=${TELEGRAF_PIDDIR} -STRIP= # stripping can break go binaries - post-patch: @${MKDIR} ${WRKSRC}/src/github.com/${GH_ACCOUNT_DEFAULT}/${PORTNAME} @cd ${WRKSRC} && ${MV} CHANGELOG.md CONTRIBUTING.md Godeps Godeps_windows \ Modified: head/net/cf/Makefile ============================================================================== --- head/net/cf/Makefile Thu Oct 12 09:04:05 2017 (r451833) +++ head/net/cf/Makefile Thu Oct 12 09:06:17 2017 (r451834) @@ -24,8 +24,6 @@ PLIST_FILES= bin/cf PORTDOCS= CHANGELOG.md NOTICE README.md -STRIP= # stripping can break go binaries - OPTIONS_DEFINE= DOCS do-build: Modified: head/net/concourse-fly/Makefile ============================================================================== --- head/net/concourse-fly/Makefile Thu Oct 12 09:04:05 2017 (r451833) +++ head/net/concourse-fly/Makefile Thu Oct 12 09:06:17 2017 (r451834) @@ -22,8 +22,6 @@ CONFLICTS_INSTALL= fly PLIST_FILES= bin/fly -STRIP= # stripping can break go binaries - # The build instructions for `fly` suggest to clone the global Concourse # repository, which contains many Git submodules, including fly, and # build from there. So basically: Modified: head/net/nsq/Makefile ============================================================================== --- head/net/nsq/Makefile Thu Oct 12 09:04:05 2017 (r451833) +++ head/net/nsq/Makefile Thu Oct 12 09:06:17 2017 (r451834) @@ -39,8 +39,6 @@ GH_TUPLE= BurntSushi:toml:v0.2.0:toml/src/github.com/B TARGETS= nsqd nsqlookupd nsqadmin nsq_pubsub nsq_to_nsq nsq_to_file \ nsq_to_http nsq_tail nsq_stat to_nsq -STRIP= - .for _t in ${TARGETS} build-${_t}: cd ${GO_WRKSRC}/apps/${_t}; \ Modified: head/net/rclone/Makefile ============================================================================== --- head/net/rclone/Makefile Thu Oct 12 09:04:05 2017 (r451833) +++ head/net/rclone/Makefile Thu Oct 12 09:06:17 2017 (r451834) @@ -41,8 +41,6 @@ GH_TUPLE+= \ PLIST_FILES= bin/rclone -STRIP= # stripping can break go binaries - do-build: @cd ${WRKSRC}/src/github.com/${GH_ACCOUNT_DEFAULT}/${PORTNAME}; ${SETENV} GOPATH=${WRKSRC} go build . Modified: head/net/syncthing-cli/Makefile ============================================================================== --- head/net/syncthing-cli/Makefile Thu Oct 12 09:04:05 2017 (r451833) +++ head/net/syncthing-cli/Makefile Thu Oct 12 09:06:17 2017 (r451834) @@ -16,8 +16,6 @@ GH_TAGNAME= 9594d39 PLIST_FILES= bin/syncthing-cli -STRIP= # stripping can break go binaries - do-build: @cd ${WRKSRC} ; ${SETENV} GOPATH=${WRKSRC}/Godeps/_workspace:${WRKSRC} go build @${MV} ${WRKSRC}/syncthing-cli-${GH_TAGNAME} ${WRKSRC}/syncthing-cli Modified: head/net/syncthing-discosrv/Makefile ============================================================================== --- head/net/syncthing-discosrv/Makefile Thu Oct 12 09:04:05 2017 (r451833) +++ head/net/syncthing-discosrv/Makefile Thu Oct 12 09:06:17 2017 (r451834) @@ -21,8 +21,6 @@ USE_RC_SUBR= syncthing-discosrv USERS= syncthing GROUPS= syncthing -STRIP= # stripping can break go binaries - post-patch: @cd ${WRKSRC} ; ${MKDIR} src/github.com/${GH_ACCOUNT}/${GH_PROJECT} ; \ ${MV} .gitignore CONTRIBUTORS LICENSE README.md build.sh \ Modified: head/security/ssh-vault/Makefile ============================================================================== --- head/security/ssh-vault/Makefile Thu Oct 12 09:04:05 2017 (r451833) +++ head/security/ssh-vault/Makefile Thu Oct 12 09:06:17 2017 (r451834) @@ -20,8 +20,6 @@ GH_TUPLE= ssh-vault:crypto:ae180e0:crypto/src/github.c ssh-vault:ssh2pem:c1edc64:ssh2pem/src/github.com/ssh-vault/ssh2pem GH_SUBDIR= src/github.com/${PORTNAME}/${PORTNAME} -STRIP= # stripping can break go binaries - PLIST_FILES= bin/ssh-vault post-patch: Modified: head/sysutils/consul-alerts/Makefile ============================================================================== --- head/sysutils/consul-alerts/Makefile Thu Oct 12 09:04:05 2017 (r451833) +++ head/sysutils/consul-alerts/Makefile Thu Oct 12 09:06:17 2017 (r451834) @@ -25,8 +25,6 @@ PLIST_FILES= ${PREFIX}/bin/${PORTNAME} USE_RC_SUBR= ${PORTNAME} -STRIP= #none - do-build: cd ${GO_WRKSRC} && \ ${SETENV} ${BUILD_ENV} GOPATH=${WRKSRC} go build -v -x \ Modified: head/sysutils/epazote/Makefile ============================================================================== --- head/sysutils/epazote/Makefile Thu Oct 12 09:04:05 2017 (r451833) +++ head/sysutils/epazote/Makefile Thu Oct 12 09:06:17 2017 (r451834) @@ -19,8 +19,6 @@ GH_TUPLE= epazote:scheduler:0.1.0:scheduler/src/github go-yaml:yaml:cd8b52f:yaml/src/github.com/go-yaml/yaml GH_SUBDIR= src/github.com/${PORTNAME}/${PORTNAME} -STRIP= # stripping can break go binaries - PLIST_FILES= bin/epazote do-build: Modified: head/sysutils/ipfs-go/Makefile ============================================================================== --- head/sysutils/ipfs-go/Makefile Thu Oct 12 09:04:05 2017 (r451833) +++ head/sysutils/ipfs-go/Makefile Thu Oct 12 09:06:17 2017 (r451834) @@ -25,8 +25,6 @@ PLIST_FILES= bin/${PORTNAME} USE_RC_SUBR= ${PORTNAME} -STRIP= # stripping can break go binaries - do-build: cd ${WRKSRC}/src/github.com/ipfs/go-ipfs/cmd/ipfs; \ ${SETENV} ${BUILD_ENV} ${MAKE_ENV} go build -v -x \ Modified: head/sysutils/node_exporter/Makefile ============================================================================== --- head/sysutils/node_exporter/Makefile Thu Oct 12 09:04:05 2017 (r451833) +++ head/sysutils/node_exporter/Makefile Thu Oct 12 09:06:17 2017 (r451834) @@ -23,8 +23,6 @@ PLIST_FILES= bin/node_exporter USE_RC_SUBR= node_exporter -STRIP= # stripping can break go binaries - do-install: ${INSTALL_PROGRAM} ${WRKDIR}/bin/node_exporter ${STAGEDIR}${PREFIX}/bin Modified: head/sysutils/nomad/Makefile ============================================================================== --- head/sysutils/nomad/Makefile Thu Oct 12 09:04:05 2017 (r451833) +++ head/sysutils/nomad/Makefile Thu Oct 12 09:06:17 2017 (r451834) @@ -25,8 +25,6 @@ USE_RC_SUBR= nomad USERS= nomad GROUPS= nomad -STRIP= - do-build: @cd ${WRKSRC}/src/github.com/hashicorp/nomad; \ ${SETENV} ${BUILD_ENV} GOPATH=${WRKSRC} go build -v -x \ Modified: head/sysutils/restic/Makefile ============================================================================== --- head/sysutils/restic/Makefile Thu Oct 12 09:04:05 2017 (r451833) +++ head/sysutils/restic/Makefile Thu Oct 12 09:06:17 2017 (r451834) @@ -14,7 +14,6 @@ LICENSE= BSD2CLAUSE USES= go USE_GITHUB= yes -STRIP= # stripping can break go binaries PLIST_FILES= bin/restic post-patch: Modified: head/sysutils/siegfried/Makefile ============================================================================== --- head/sysutils/siegfried/Makefile Thu Oct 12 09:04:05 2017 (r451833) +++ head/sysutils/siegfried/Makefile Thu Oct 12 09:06:17 2017 (r451834) @@ -22,6 +22,4 @@ USES= go GO_PKGNAME= github.com/${GH_ACCOUNT}/${PORTNAME} GO_TARGET= github.com/${GH_ACCOUNT}/${PORTNAME}/cmd/sf -STRIP= # stripping can break go binaries - .include <bsd.port.mk> Modified: head/sysutils/zfs-snap-diff/Makefile ============================================================================== --- head/sysutils/zfs-snap-diff/Makefile Thu Oct 12 09:04:05 2017 (r451833) +++ head/sysutils/zfs-snap-diff/Makefile Thu Oct 12 09:06:17 2017 (r451834) @@ -24,6 +24,4 @@ USES= go PLIST_FILES= bin/zfs-snap-diff -STRIP= # stripping can break go binaries - .include <bsd.port.mk> Modified: head/textproc/spiff/Makefile ============================================================================== --- head/textproc/spiff/Makefile Thu Oct 12 09:04:05 2017 (r451833) +++ head/textproc/spiff/Makefile Thu Oct 12 09:06:17 2017 (r451834) @@ -18,8 +18,6 @@ PLIST_FILES= bin/spiff PORTDOCS= LICENSE README.md examples/cf-aws.yml \ examples/multi-az-cf-aws.yml examples/tutorial.md -STRIP= # stripping can break go binaries - OPTIONS_DEFINE= DOCS post-patch: Modified: head/www/go-www/Makefile ============================================================================== --- head/www/go-www/Makefile Thu Oct 12 09:04:05 2017 (r451833) +++ head/www/go-www/Makefile Thu Oct 12 09:06:17 2017 (r451834) @@ -19,8 +19,6 @@ GH_ACCOUNT= nbari:DEFAULT GH_TUPLE= golang:crypto:847319b:crypto/src/golang.org/x/crypto GH_SUBDIR= src/github.com/nbari/${PORTNAME} -STRIP= # stripping can break go binaries - PLIST_FILES= bin/www post-patch: Modified: head/www/grafana3/Makefile ============================================================================== --- head/www/grafana3/Makefile Thu Oct 12 09:04:05 2017 (r451833) +++ head/www/grafana3/Makefile Thu Oct 12 09:06:17 2017 (r451834) @@ -97,8 +97,6 @@ SUB_LIST+= GRAFANA_USER=${GRAFANA_USER} \ PLIST_SUB+= GRAFANAHOMEDIR=${GRAFANAHOMEDIR} -STRIP= - post-extract: @${MKDIR} ${WRKSRC}/src/github.com/grafana/grafana .for src in .bowerrc .bra.toml .editorconfig .github .gitignore .hooks \ Modified: head/www/minio-client/Makefile ============================================================================== --- head/www/minio-client/Makefile Thu Oct 12 09:04:05 2017 (r451833) +++ head/www/minio-client/Makefile Thu Oct 12 09:06:17 2017 (r451834) @@ -32,7 +32,6 @@ GH_TAGNAME= RELEASE.2017-02-06T20-16-19Z GH_SUBDIR= src/github.com/${GH_ACCOUNT}/${GH_PROJECT} MAKE_ENV= GOPATH=${WRKSRC} GOROOT=${LOCALBASE}/go -STRIP= # stripping can break go binaries PLIST_FILES= bin/${MC} do-build: Modified: head/www/uchiwa/Makefile ============================================================================== --- head/www/uchiwa/Makefile Thu Oct 12 09:04:05 2017 (r451833) +++ head/www/uchiwa/Makefile Thu Oct 12 09:06:17 2017 (r451834) @@ -46,8 +46,6 @@ GH_TUPLE+= kless:osutil:3ac994847c4376a4b905fc0a19f450 USERS= uchiwa GROUPS= uchiwa -STRIP= # - post-extract: @${MKDIR} ${WRKSRC}/src/github.com/${GH_ACCOUNT}/${PORTNAME} .for src in .travis.yml Gruntfile.js bower.json package.json uchiwa \
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201710120906.v9C96IXa085282>