From nobody Mon Mar 23 10:52:58 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ffVRH0hNhz6Vpsd; Mon, 23 Mar 2026 10:54:19 +0000 (UTC) (envelope-from Sarah.Walker2@arm.com) Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazlp170130006.outbound.protection.outlook.com [IPv6:2a01:111:f403:c201::6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (secp384r1) server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.protection.outlook.com", Issuer "DigiCert Cloud Services CA-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ffVRF6LVdz3Wwg; Mon, 23 Mar 2026 10:54:17 +0000 (UTC) (envelope-from Sarah.Walker2@arm.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=arm.com header.s=selector1 header.b=AKIK48VX; dkim=pass header.d=arm.com header.s=selector1 header.b=AKIK48VX; dmarc=pass (policy=none) header.from=arm.com; arc=pass ("microsoft.com:s=arcselector10001:i=2"); spf=pass (mx1.freebsd.org: domain of Sarah.Walker2@arm.com designates 2a01:111:f403:c201::6 as permitted sender) smtp.mailfrom=Sarah.Walker2@arm.com ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=SFCgU/9x+EWs5a8aarHyX+ClyQvPt8Lp7cYxGtcpIO1UcBsxmL3G09YfeSeQX8lMGxItbllCNMksuR+Av8fhA90tNJvTcbt+/IWd1TvFc9FVaZkyGWA7+mJ769QCo3pIHh1EtSMQPKxMqNMjF+t/jEkT4byEQBFLkV1wD9dzS1iupdO//uakunuSWqZ4ji8BRhjmvqsMd8rk2IINUhzLqViSf1C3tRWqS/aHLKbcTxpuIu4u7L7FFkQnO0ZCxThGeuwCUQ9rZxSEGYLBM/HY8YFd7DX39sqL11R4Z3CFmdrAM8lC9zhcbmNQquxD9We/WOhUYYmlzqzbWNz72h23PA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oLPmOVxIpyhZl3wt436KyfBBEUMjydzw4UvQQHgUJwI=; b=t3VtsCPyQkg1HdfDxmd6xJrLzRpVeMGls1fo9cJiVGdu3+TT9/O0CWNexwL7DJd9GViRun02L6k9nK9oT3wtM7I+PXyqRj3mYbOTm6CgoY24d3uzCif70QpDagy195G9PMta9CNE8wQynx1v2Y9hEiIYZWRML01JYsGWf6aZHjouzbJ4WobcxKu79/MRdDGJljqykS/ih3TSRtKgvFuZe2BknT7kvQfBYf9K4Zclxvb9R2ys2bZ74ozKSbprfS5RHU+HlYpP/PfqKqdiNw7bOzQqpvD6QHAT276HWBijXnwryB0BP0xIOcrhaZGAtWOc4DwrVOjg84r8pygVj87yLQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=freebsd.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oLPmOVxIpyhZl3wt436KyfBBEUMjydzw4UvQQHgUJwI=; b=AKIK48VXQJxSqgKKwoOtxscUmB+59dH+aNf5vbfzgEUFRpN/SEe7+hOUbH5DR0oxpDjBjo8iOhRFsQsLvt0rKGG+h/sARge2sU3ELvk3LPyZOnhPqHY0mia1rE2tMuA85Am4s1tI9bsjSN/D53jrQqDxGGYah4uoJNPm7nrSCw8= Received: from DB8PR04CA0003.eurprd04.prod.outlook.com (2603:10a6:10:110::13) by DU5PR08MB10756.eurprd08.prod.outlook.com (2603:10a6:10:51e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.31; Mon, 23 Mar 2026 10:54:05 +0000 Received: from DU2PEPF0001E9C1.eurprd03.prod.outlook.com (2603:10a6:10:110:cafe::fd) by DB8PR04CA0003.outlook.office365.com (2603:10a6:10:110::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9723.25 via Frontend Transport; Mon, 23 Mar 2026 10:54:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by DU2PEPF0001E9C1.mail.protection.outlook.com (10.167.8.70) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9723.19 via Frontend Transport; Mon, 23 Mar 2026 10:54:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CQfKFBScPuJr8+xPg/QVNn4CaKnbHd0N7WqS6itEjrrkuJD6oxyfrPKj8sGYHql2PeiKJcHZoIkQf6aREjteAz5f2KLCUb8pVeUfGm20wsVZImIPG7D7mKg/8ExZDAmpHpp88PUFORbVYgBwOiP5yeuPPetRAzTk+sqHNkYaIMHcNOBa8+hKVTI4jh3hwGgVQdkNz3UgyAnOsWOptiwMnj6WM0VwjGKENqJrU6G0GSRwOP4X6BarA29ssZKxvhjnpLnHrSc7F2kQpFF5Q0SaBb291O4VU29yywlPH4gd4Ew+GMNuq+LPW1eiSR6vUSla60UaK9nZj3b8wduHuwL8BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oLPmOVxIpyhZl3wt436KyfBBEUMjydzw4UvQQHgUJwI=; b=iX/LicDfo6m7Ts3rde8OWA4cL5QcZI1rbuDKYWtgToaw+pYexn8wS9YsBow69p1bGTtOXK5ImGSm1E3mKXhAGcDtG6jKVnsCgRDL0G57oSLoFAaCSb6aQkvSRSngbqVXGy+V6QOVodt6v7lhzoF2D8SDFTF39ty2ZrC35ai5qnPPGI//iC0zJazB6xdGGK6dAIZ7QVIQU9SJs/5CRk5pFD80Mn9DPIGqbbrd8TOf0CPeLbAyC48DpeUpGvWPl2xHTCfCBsfOBz786ONqNEl7zYbKr9aoQHXxetBJbzK61p17fltfqfbkv2ZEHJbDkE+wwsCaGdqcKNr2QjdvaXaXjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oLPmOVxIpyhZl3wt436KyfBBEUMjydzw4UvQQHgUJwI=; b=AKIK48VXQJxSqgKKwoOtxscUmB+59dH+aNf5vbfzgEUFRpN/SEe7+hOUbH5DR0oxpDjBjo8iOhRFsQsLvt0rKGG+h/sARge2sU3ELvk3LPyZOnhPqHY0mia1rE2tMuA85Am4s1tI9bsjSN/D53jrQqDxGGYah4uoJNPm7nrSCw8= Received: from AS1PR08MB7636.eurprd08.prod.outlook.com (2603:10a6:20b:478::11) by GV1PR08MB7683.eurprd08.prod.outlook.com (2603:10a6:150:62::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.31; Mon, 23 Mar 2026 10:52:58 +0000 Received: from AS1PR08MB7636.eurprd08.prod.outlook.com ([fe80::358d:e4bf:8a24:ee12]) by AS1PR08MB7636.eurprd08.prod.outlook.com ([fe80::358d:e4bf:8a24:ee12%6]) with mapi id 15.20.9723.030; Mon, 23 Mar 2026 10:52:58 +0000 From: Sarah Walker To: Jessica Clarke , Andrew Turner CC: "src-committers@FreeBSD.org" , "dev-commits-src-all@FreeBSD.org" , "dev-commits-src-main@FreeBSD.org" Subject: Re: git: 1d13d938fe6c - main - virtio: Ensure power-of-two alignment for indirect queue Thread-Topic: git: 1d13d938fe6c - main - virtio: Ensure power-of-two alignment for indirect queue Thread-Index: AQHctgCWZSVMo+x3+kO0T1bDvMdTdrWymCkAgATKTQCABJd6Gg== Date: Mon, 23 Mar 2026 10:52:58 +0000 Message-ID: References: <69b939d7.26113.1aca36de@gitrepo.freebsd.org> <8F587FE2-CF54-4605-9CD6-581FC1D98D34@freebsd.org> <52B83EF2-4427-44ED-8486-B513189DA4AA@freebsd.org> In-Reply-To: <52B83EF2-4427-44ED-8486-B513189DA4AA@freebsd.org> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS1PR08MB7636:EE_|GV1PR08MB7683:EE_|DU2PEPF0001E9C1:EE_|DU5PR08MB10756:EE_ X-MS-Office365-Filtering-Correlation-Id: 94888da7-eae1-4298-071b-08de88ca8016 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230040|376014|366016|1800799024|38070700021|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info-Original: r4x8mXMw/l7yLHWNm5vyu/zIlJj9EZfV8yImI4NUHorwH9KjbD9QK6f7+eu5DebNhVBxikFvkvHMWWqEKloxDDTNTi8KmBnOas0QR6lrABw3hAH5Saaw8DddRUrFg1xGqZjtQ1+tBW3iLVebyd56w1FH6To3AbFR+FfcOMwNG+rU58NpLWeIziMCh4q6XLJp1VozNXtiCe7xluMMm0ZMlRCuTXXs9Ds/jHbDz5ZfP04kccGzaqTMYaJCFgwieJWD4bv/INyrLD817OfZC2O0cd4AkxhwipI06D0Di/njWe5elVmuFnYJofqCkRlEKNSoxJ5ov8ojpelb1AmYIE4DTIUoI2wBvRo9kTTk0U6CfsGAgRT4T88m0Sri/NU5N9RmwyiKDP9Iso4A7uQ1AuxvGkn5CiAtvH1T0sJnHpZnFUGkvAxud+3cM2cyv3jXK9UZERKziIQTFJHXDArbD4ugC90uNPqkS5Y+aT9PcpTnFse1XPoOlmzdSrxvWWG9wEEbqCjpy4aW7gjkCJJoXTf88xZ4J8Qgd2vGL1zUuLCJm4FNv/Qv9FBIGGkCSsGixx5SmszCvNCPKz1IX1q0+6UJbJmGR4YlA8vgTDZ4qwcpJixvpvKHcC+xC0wxSxVkPiu5YqSkIctPf/64eM/u0YozB1i/J6zcJEVKh/K+ORbQDAtweeOXUHg6wFIuAsDMbAyy+QWTIaVcDAQ3qCriukVI/VdqyGihZ6Kj/pnQE9m1AQ1WdUpBzkoGtV9wnDPzd/P1nfL0oMnz4lxx0JiYWXDudnbl/EEs5bFPzB22f70YWzwG+oJibJ2380zIvD8e4yt7 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS1PR08MB7636.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(38070700021)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: hew6nHoZg7+F2k9DIMeZ6EHLNioRg9Gxlr+kbglrnevGneXqa6r5XOJ4k0yvCRNnYWnmlVIwKW2cWXG+JuAMUuXJKG3w7xZDBQplKNHrnWPDZ97hpMBFQsj/jpFnCFtMEWvs4Ztxv7xHb93IL1VpIwKW/wpHHR7H8N4U1/acD3KgXVWgE0Buf74usX1cfcRnMU91z0uGOGjurdw67ow7iPS134iKNbbjzRyVm1mb32qZ8S+ROLY4z6KiHJfqVdU3JwYzEfsK/mzxuXvY1kfVDT14ESNIF9q3wKw27vYjgf+16umVGwk66kfCMBs4A2rkIrocDs7SwrScg9mL3gUcdA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7683 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DU2PEPF0001E9C1.eurprd03.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3fad6f5f-023b-4605-e138-08de88ca5870 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|376014|14060799003|36860700016|35042699022|13003099007|7053199007|22082099003|56012099003|18002099003; X-Microsoft-Antispam-Message-Info: ZWuXxsNVNNAiO38qofk7MVa/iYp8U2ZizcdOHRH75GWMTI4uUxQHTU60BQhrK1mEA+l0F6cRm/Kl20JYgjPG4aHGrsLrFhaAWu+19TnAdUz0cLMxQmxcpUfIeqqPtwzb7Mwg0lccFLfeL1nnz6yKC7rE1NLdA3KUOMZnukMEvCcXRIuTiRmdNOHCczq370mOn059NuEac+CkHSQnI8KVrHRqN3ERKFs8s/tKbkaLsfxZz2OHsi5Lwt+OW5fsGLfzQWSbh6g6qP1mQHCtR4vGA+Fv11jaC4mz7cx6VwtIlhTWjTa9Mvd9eYYNcOxyedi8oTUM7OS9Xo05WcVsTply71SKKMKnYnP9JclBKZH0K+3swVWN6HjPcSXrxWx4m0a2jhmIUDbAuiJBU9alMwyiGIrhdEqgA29mCvD+zhzzn4qWeCQ5jS88sg/K5PPeAIbrl/YlMSLCPKc/hx7V3xGkloiImpiNMvrvfu+lPq8JM8rQlhdQvwRwcDZwjHI6Vv1/P/op3LAfi2vAacwQ3fi4OKoAK9xmpQo+x6ZyB+3rwDjvoHGG/LfeB64Bm7ESN9kkliFS8wG8X4+pQi1KURh3GC6sOnF9wIxGsfRopcq/Yvm21hq9YwQup1E9gJaY1CUWYfnw2ju2zKe7pjob0hAKoniejFsD87OPZXYLbl29XKf+jA3krIXjYKk87u1FhCNA9VXwYW5YC4oJajAiQzS4Pr6BxlomwJ8c/ASfYnvDOkWhHnKXOaW5H7MM5B3WlIkQwJAKSs/GhIzKSgrk68zqhqIFOFqYnci4s5fItOaviLM= X-Forefront-Antispam-Report: CIP:4.158.2.129;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:outbound-uk1.az.dlp.m.darktrace.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(376014)(14060799003)(36860700016)(35042699022)(13003099007)(7053199007)(22082099003)(56012099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: JXAdgnPOkTR87m7vWcF4GaVxc8lrcnrbZlqmwhpKEXAem5fpihQiW2Hp3yIpYt2MFfwn5IOX79ei39YRJ0GmhvfDF7yMNDuoZI6nImbWX3h22AM3xvz14AupHap0o8dld/QGFohZFR1Jjd6iNfaGKkYOTagNM+L4Sg9yEVref2ZnEMmiF3d0gkk8T0w/kw4oe3eiNWG+SdULGaHo7+6E85mNqW/qxbXnuyfKZs7gg0Bq/r2D8Ow2SRsUXwGdUuqkf7Tos3+xR1KgTdnWEPuEpGMrThnnCdlMUJH8TuJrJMJM+rR4VaTbsPgKuHi7q+JM/kEW5HINKoDXp1O0fRw0dNKF5efyXk4ciRhDaipHyzGHZh80tYjEFKmwfweB2lmuoFPW375YBNC1RL+p0eUTLFKzH5iGlB+Vr29YoTy+6sGMs7/PI7Nx8fdE4hipef/n X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2026 10:54:04.5872 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 94888da7-eae1-4298-071b-08de88ca8016 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[4.158.2.129];Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: DU2PEPF0001E9C1.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU5PR08MB10756 X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; DWL_DNSWL_LOW(-1.00)[arm.com:dkim]; ARC_ALLOW(-1.00)[microsoft.com:s=arcselector10001:i=2]; NEURAL_HAM_SHORT(-1.00)[-0.995]; DMARC_POLICY_ALLOW(-0.50)[arm.com,none]; R_SPF_ALLOW(-0.20)[+ip6:2a01:111:f403:c000::/51]; R_DKIM_ALLOW(-0.20)[arm.com:s=selector1]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; MISSING_XM_UA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; ASN(0.00)[asn:8075, ipnet:2a01:111:f000::/36, country:US]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_FIVE(0.00)[5]; DKIM_TRACE(0.00)[arm.com:+] X-Rspamd-Queue-Id: 4ffVRF6LVdz3Wwg X-Spamd-Bar: ----- On 17 Mar 2026, at 11:34, Jessica Clarke wrote: > > On 17 Mar 2026, at 11:24, Andrew Turner wrote: >> >> The branch main has been updated by andrew: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=3D1d13d938fe6c7639d2bb4cb52= 48a1f81275b6891 >> >> commit 1d13d938fe6c7639d2bb4cb5248a1f81275b6891 >> Author: Sarah Walker >> AuthorDate: 2026-03-17 10:54:30 +0000 >> Commit: Andrew Turner >> CommitDate: 2026-03-17 10:56:27 +0000 >> >> virtio: Ensure power-of-two alignment for indirect queue >> >> Some platforms enforce power-of-two alignment for bus_dma tags. Roundi= ng up >> the natural size may result in over-alignment, but should be safe. >> >> PR: 293770 >> Reviewed by: andrew >> Fixes: c499ad6f997c ("virtio: Use bus_dma for ring and indire= ct buffer allocations") >> Sponsored by: Arm Ltd >> Differential Revision: https://reviews.freebsd.org/D55843 >> --- >> sys/dev/virtio/virtqueue.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/sys/dev/virtio/virtqueue.c b/sys/dev/virtio/virtqueue.c >> index b7fdb4703ccb..10b5179bd3d5 100644 >> --- a/sys/dev/virtio/virtqueue.c >> +++ b/sys/dev/virtio/virtqueue.c >> @@ -341,7 +341,7 @@ virtqueue_init_indirect(struct virtqueue *vq, int in= direct_size) >> align =3D size; > > Why is this the alignment in the first place? Pre-busdma it just used > malloc with no explicit alignment. Given: > > size =3D indirect_size * sizeof(struct vring_desc); > > can=92t this get quite large? Except VIRTIO_MAX_INDIRECT looks to be > rather stale, tied to the malloc rather than busdma world=85 Apologies, I was playing safe with the alignment. I've opened a review at h= ttps://reviews.freebsd.org/D56038 to change it to align to a single descrip= tor (16 bytes). Sarah IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.