Date: Thu, 7 Dec 2017 13:07:51 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: Pietro Cerutti <gahr@FreeBSD.org>, Joe Marcus Clarke <marcus@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r447981 - in head/ports-mgmt/portlint: . src Message-ID: <67778550-ec80-89d4-8914-80d001280e6d@FreeBSD.org> In-Reply-To: <20171207120403.7wafl635xclviqsr@ptrcrt.ch> References: <201708151243.v7FChEAF043279@repo.freebsd.org> <20171207080421.qijzbigqkbfbezqe@ptrcrt.ch> <20171207081055.xtssqrp5okethfeu@ptrcrt.ch> <20171207081308.5bxt5mp2o5wr33un@ptrcrt.ch> <df5a59b6-df44-9a2c-2a4d-d85b15376a97@freebsd.org> <20171207120403.7wafl635xclviqsr@ptrcrt.ch>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PBGFXvFN2hm8pvgs9THKFUTgcGaiW5h1K Content-Type: multipart/mixed; boundary="cS8nX8qONro97o5Cu6lWWM3186sN3NGRt"; protected-headers="v1" From: Mathieu Arnold <mat@FreeBSD.org> To: Pietro Cerutti <gahr@FreeBSD.org>, Joe Marcus Clarke <marcus@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: <67778550-ec80-89d4-8914-80d001280e6d@FreeBSD.org> Subject: Re: svn commit: r447981 - in head/ports-mgmt/portlint: . src References: <201708151243.v7FChEAF043279@repo.freebsd.org> <20171207080421.qijzbigqkbfbezqe@ptrcrt.ch> <20171207081055.xtssqrp5okethfeu@ptrcrt.ch> <20171207081308.5bxt5mp2o5wr33un@ptrcrt.ch> <df5a59b6-df44-9a2c-2a4d-d85b15376a97@freebsd.org> <20171207120403.7wafl635xclviqsr@ptrcrt.ch> In-Reply-To: <20171207120403.7wafl635xclviqsr@ptrcrt.ch> --cS8nX8qONro97o5Cu6lWWM3186sN3NGRt Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: fr Le 07/12/2017 =C3=A0 13:04, Pietro Cerutti a =C3=A9crit=C2=A0: > On Dec 7 17 06:22, Joe Marcus Clarke wrote: >> On 12/7/17 03:13, Pietro Cerutti wrote: >>> On Dec 7 17 08:10, Pietro Cerutti wrote: >>>> On Dec 7 17 08:04, Pietro Cerutti wrote: >>>>> On Aug 15 17 12:43, Joe Marcus Clarke wrote: >>>>>> Author: marcus >>>>>> Date: Tue Aug 15 12:43:14 2017 >>>>>> New Revision: 447981 >>>>>> URL: https://svnweb.freebsd.org/changeset/ports/447981 >>>>>> >>>>>> Log: >>>>>> Update to 2.17.12. >>>>>> @@ -3400,6 +3437,11 @@ sub abspathname { >>>>>> =20 >>>>>> if ($pre =3D~ /MASTER_SITE_SUBDIR/) { >>>>>> # MASTER_SITE_SUBDIR lines are ok. >>>>>> + $i =3D ''; >>>>>> + } >>>>>> + if ($s =3D~ /\$\{[^}]*?$i/) { >>>>>> + # If we're inside a make variable, we probably do not have >>>>>> + # an absolute path. >>>>>> $i =3D ''; >>>>>> } >>>>>> } >>>>>> >>>>> Unmatched ) in regex; marked by <-- HERE in m/\$\{[^}]*?/dev/null 2= >&1 )=20 >>>>> <-- HERE / at /usr/local/bin/portlint line 3443. >>>>> >>>>> I think the ? doesn't belong there. >>>> No, my analysis was wrong. It's about the contents of the $i variabl= e.=20 >>>> Here's why. You can reproduce by portlint -AC in net-im/openfire. >>>> >>>> i is /var/log/openfire >>>> WARN: Makefile: possible use of absolute pathname "/var/log/openfire= ". >>>> >>>> i is /var/db/openfire >>>> WARN: Makefile: possible use of absolute pathname "/var/db/openfire"= =2E >>>> >>>> i is /dev/null 2>&1 ) >>>> Unmatched ) in regex; marked by <-- HERE in m/\$\{[^}]*?/dev/null 2>= &1 )=20 >>>> <-- HERE / at /usr/local/bin/portlint line 3444. >>> Surrounding $i with \Q and \E in the regex solves the problem. >>> >>> >> Thanks. I'll commit a quick fix ahead of the next release. > Thanks. I still don't understand why you have both * and ? as=20 > quantifiers, though. perlre(1): =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 *?=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Match 0 or more times, not greedily --=20 Mathieu Arnold --cS8nX8qONro97o5Cu6lWWM3186sN3NGRt-- --PBGFXvFN2hm8pvgs9THKFUTgcGaiW5h1K Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJaKS8YXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85ISyUP/AsZzWE/+HaBWUOz2MXAmp45 xbgwIM3tpHs133HOm8/GBjhb0qFnX4l4DwXDf09w+RAvfmXeWi7TO+rspK4nJEMP vow8ps+yDHK2luywD6mcwpPBTe4FYhQp5wdFsH+UaELr6FQUJHA+ZCLcSZvcYbKU 4Ax4zPQSLtx+JzVtkQKmKAemfsV/b1cMQfkym6AlP79GLmRa+vH1xUpPzAdj1e34 59zTSlDhgPgmSk5XlxXFb8sJyGK2UFXNx6G0SSOI+r4lYLrCkIHDo8NF0dgW5O/+ 6n+9DHqeh+fGqCvAmn4RQExi6oCqvW+uaGOr+q5iezJJUWBw7uj/hAJ5YjEafoSO O8zBbVRBONwIRuT459J3tzuLlPHX9wylfyopabGp1JQFCjipwsxv2UsMEroewFow LbCppQfy6QXaJddpQzK3MGPmp2i5ZUBw7ndC1fkqJI9cFV5bsjnbmHv71dKJ1GuK K2GOpw1bt6Cy45u0f2TsMrwCf1s42m0/xfNuJAtxd7gE5m0gk1ukmV+gorOwettT 4LMpRbuAHWn2aEN8VokPlBN+dhdU6SSv5imL7XW8v1F8KbIvUL/aActIgG76Hvm7 sT6DA3dGfNxXgdT9M4DNOEVNOdoS6uxoIQrym8UjNx4BsVq3WX3p96XJslEUzsyw XmsQb+4GoE9NtxcdIV7e =wV4R -----END PGP SIGNATURE----- --PBGFXvFN2hm8pvgs9THKFUTgcGaiW5h1K--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?67778550-ec80-89d4-8914-80d001280e6d>