From owner-cvs-src@FreeBSD.ORG  Sun Dec 24 13:20:10 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 0D6C416A403;
	Sun, 24 Dec 2006 13:20:10 +0000 (UTC)
	(envelope-from phk@critter.freebsd.dk)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
	by mx1.freebsd.org (Postfix) with ESMTP id B689313C46E;
	Sun, 24 Dec 2006 13:20:09 +0000 (UTC)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (critter.freebsd.dk [192.168.48.2])
	by phk.freebsd.dk (Postfix) with ESMTP id 0E6551747B;
	Sun, 24 Dec 2006 12:47:18 +0000 (UTC)
To: Bruce Evans <bde@zeta.org.au>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Sun, 24 Dec 2006 22:08:45 +1100."
	<20061224211712.W25632@delplex.bde.org> 
Date: Sun, 24 Dec 2006 12:47:13 +0000
Message-ID: <27975.1166964433@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
Cc: Scott Long <scottl@samsco.org>, src-committers@FreeBSD.org,
	cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, John Polstra <jdp@polstra.com>,
	Robert Watson <rwatson@FreeBSD.org>
Subject: Re: cvs commit: src/sys/dev/bge if_bge.c 
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 24 Dec 2006 13:20:10 -0000

In message <20061224211712.W25632@delplex.bde.org>, Bruce Evans writes:

>Be careful with micro-optimizations.  I saw a single change (adding
>about 1K in unrelated code that is never executed) give a pessimization
>of 15% for tx bge (from 360 kpps to 300 kpps).

It is still a good idea to also disable caches or also benchmark
on a very slow CPU when doing optimizations.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.