From owner-freebsd-bugs@freebsd.org Mon Jan 13 16:08:50 2020 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BFEE41E170D for ; Mon, 13 Jan 2020 16:08:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 47xJRk4mg4z3DF4 for ; Mon, 13 Jan 2020 16:08:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id A3C671E170C; Mon, 13 Jan 2020 16:08:50 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A390F1E170B for ; Mon, 13 Jan 2020 16:08:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47xJRk3wXkz3DF2 for ; Mon, 13 Jan 2020 16:08:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 8212272F0 for ; Mon, 13 Jan 2020 16:08:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 00DG8ovu069331 for ; Mon, 13 Jan 2020 16:08:50 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 00DG8oLT069330 for bugs@FreeBSD.org; Mon, 13 Jan 2020 16:08:50 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 243324] Module with 'mii' can panic during kldunload Date: Mon, 13 Jan 2020 16:08:50 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: ghuckriede@blackberry.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jan 2020 16:08:50 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D243324 Bug ID: 243324 Summary: Module with 'mii' can panic during kldunload Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: ghuckriede@blackberry.com Overview: While trying to see if setting ivars to NULL during detach was required (See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D242727), discovered 're' module can panic on kldunload. Upon further analysis, it was determined th= at there is no protection for ioctls during the kldunload. The 'mii' devices appear to be detached and destroyed while ioctl (ifconfig) is holding the RL_LOCK. There does not appear to be a 'mii' device lock (perhaps assuming= the RL_LOCK would protect it, which it doesn't). Steps to Reproduce: Compile a kernel without re module (needed to do a kldunload). After rebooting open 2 terminals (ssh for example) for 're' #### 1st terminal $ su root # /bin/sh # while true ; do kldload /usr/obj/usr/src/amd64.amd64/sys/modules/re/if_re.ko;ifconfig re0 up;sleep = 1; kldunload if_re.ko ; done #### 2nd terminal $ su root # /bin/sh # while true ; do ifconfig re0 ; done OR for 'axe' $ su root # /bin/sh # while true ; do ifconfig ue0 up;sleep 1; kldunload if_axe.ko ; done #### 2nd terminal $ su root # /bin/sh # while true ; do ifconfig ue0 ; done Actual Results: Panic occurred within a few seconds. Expected Results: no panic Build Date & Hardware: # uname -a FreeBSD FreeBSD_head_ghuckriede 13.0-CURRENT FreeBSD 13.0-CURRENT #2 r35655= 9: Thu Jan 9 15:45:41 EST 2020=20=20=20=20 ghuckriede@FreeBSD_head_ghuckriede:/usr/obj/usr/src/amd64.amd64/sys/GENERIC= _NO_RE amd64 --=20 You are receiving this mail because: You are the assignee for the bug.=