From owner-svn-src-head@freebsd.org Sun Feb 25 23:54:46 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C18EAF33FAC for ; Sun, 25 Feb 2018 23:54:46 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22c.google.com (mail-io0-x22c.google.com [IPv6:2607:f8b0:4001:c06::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B8037791A for ; Sun, 25 Feb 2018 23:54:46 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22c.google.com with SMTP id g21so15332347ioj.5 for ; Sun, 25 Feb 2018 15:54:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=hU4svuu+ZD3vumMWwoIfXqRcQdldLJSaDbhSebLDO/g=; b=BMFgc4B+e90lJUKLNTvqWMCZ7Nhd/LrHdV4FeV5szdvfJb4479uym83IY1vxo/X4ff rTrq2ln+thnAMFAG0lFpcFMwlk5IPDl2jz07ZMBzsQGLolOIXi6RrfF/uOlrcLiNQaPw P5FYD4AG3PvyECP39lK1hAIe3FyuK5E3ZPNj18qrvUGJ0VEFwAEHrVpiI0GlKEHdTfdC 6hzXuGDLjIiAx4Xki7t9SgWEEaPTyuCpO+vbYLjUwN25NCnOp/SzEzQxKiX3oKS7Eysk zSlmKhfo29It0p50w0GE5a13HwQcKDpHrEb21TnJJ4zthQSA0oqYGY5RBuBfd1QOK6mc BPvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=hU4svuu+ZD3vumMWwoIfXqRcQdldLJSaDbhSebLDO/g=; b=P58e2ExIKWHPGdEpS9pvyTc6V+AcOcslio4dcFH3R2/eX2zZ4UJWVUOWYFl01o1bsI En6JJbWtogLaTp4yqqpen96c1B/Xa9sl3JB79UTyJQB/7aTkmtWU2zEJ78hsMXm7+mrp 0Wa76j5QZqkZ/uvUSG76DGV3NRb4sssHIPQF4zrH6u89JVPOCn/+KjQoUDbIpo/GSi2g e0dYOSedbNWIYT49Qf6PgArWGRVeo5vlkEeOLKGN+CDX3nwav//ahio9m8dfd3TFwzUR YaD3lnNachfFHqPm6ojmer9BbovcZWOvwhgf0XV09wqdcYe4AYbvx1ExCCXCI2CpTVRd k+GQ== X-Gm-Message-State: APf1xPA96L9KeHm3fSdIH4L+DGiO4oyKTfMsj4rnVg/RomF84s2NpwD4 AMHOrl6BaGjScQIZSbCt6OyRu7I4xL1OJWu7e2sCpw== X-Google-Smtp-Source: AG47ELv//OjJGvCA8B3DdRZ31r/fWx1snt/W4ElkuS8sZaJqk9Da3kBHRGJ2gXviyaby0wfQLjZEJZJzHvOtPvLdtJ4= X-Received: by 10.107.2.6 with SMTP id 6mr9709248ioc.117.1519602885547; Sun, 25 Feb 2018 15:54:45 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.201.67 with HTTP; Sun, 25 Feb 2018 15:54:44 -0800 (PST) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: References: <201801310305.w0V35EU4090569@repo.freebsd.org> From: Warner Losh Date: Sun, 25 Feb 2018 16:54:44 -0700 X-Google-Sender-Auth: aECPsEhSj-ErbKHRYk43aLKUydg Message-ID: Subject: Re: svn commit: r328612 - head/lib/libc/stdlib To: Alan Somers Cc: Steve Wills , Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Feb 2018 23:54:47 -0000 Sorry for top posting... I fixed this with r328768 Author: imp Date: Fri Feb 2 05:04:43 2018 +0000 The routines defined in comparedf2 and comparesf2 are defined in libc for softfloat mips. No need to include them here. lib/libcompiler_rt/Makefile.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) John Baldwin says this may be a bogus fix, but we've come to no better one in the interim. He's not wrong to say this is bogus, but it does fix the immediate compile issue. Warner On Sun, Feb 25, 2018 at 7:52 AM, Alan Somers wrote: > I'm seeing the same error during the build of usr.sbin/nologin for > riscv.riscv64sf. Has anybody figured out a solution yet? > > On Thu, Feb 1, 2018 at 9:09 PM, Warner Losh wrote: > >> >> >> On Thu, Feb 1, 2018 at 8:34 PM, Steve Wills wrote: >> >>> This, somehow, seems to have broken the mips64 build: >>> >>> https://ci.freebsd.org/job/FreeBSD-head-mips64-build/216/consoleFull >>> >>> The previous rev works. >>> >> >> This breaks devd, of all things, with >> >> /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libgcc.a(comparedf2.o): In >> function `__gedf2': >> /usr/src/contrib/compiler-rt/lib/builtins/comparedf2.c:96: multiple >> definition of `__gedf2' >> /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libc.a(gedf2.o):/us >> r/src/lib/libc/softfloat/gedf2.c:18: first defined here >> /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libgcc.a(comparedf2.o): In >> function `__eqdf2': >> /usr/src/contrib/compiler-rt/lib/builtins/comparedf2.c:126: multiple >> definition of `__eqdf2' >> /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libc.a(eqdf2.o):/us >> r/src/lib/libc/softfloat/eqdf2.c:18: first defined here >> /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libgcc.a(comparedf2.o): In >> function `__ltdf2': >> /usr/src/contrib/compiler-rt/lib/builtins/comparedf2.c:131: multiple >> definition of `__ltdf2' >> /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libc.a(ltdf2.o):/us >> r/src/lib/libc/softfloat/ltdf2.c:18: first defined here >> /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libgcc.a(comparedf2.o): In >> function `__nedf2': >> /usr/src/contrib/compiler-rt/lib/builtins/comparedf2.c:136: multiple >> definition of `__nedf2' >> /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libc.a(nedf2.o):/us >> r/src/lib/libc/softfloat/nedf2.c:18: first defined here >> /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libgcc.a(comparedf2.o): In >> function `__gtdf2': >> /usr/src/contrib/compiler-rt/lib/builtins/comparedf2.c:141: multiple >> definition of `__gtdf2' >> /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libc.a(gtdf2.o):/us >> r/src/lib/libc/softfloat/gtdf2.c:18: first defined here >> >> undefined.... devd doesn't even use strtodl. >> >> (looks like the code to associate make output with the right commands is >> broken, since I had to dig for it. >> >> Warner >> >> >>> Steve >>> >>> >>> On 01/30/2018 22:05, Warner Losh wrote: >>> >>>> Author: imp >>>> Date: Wed Jan 31 03:05:14 2018 >>>> New Revision: 328612 >>>> URL: https://svnweb.freebsd.org/changeset/base/328612 >>>> >>>> Log: >>>> Move strtold wrapper from strtol.c to its own strtold.c. This code >>>> was written by theraven@ (David Chisnall) entirely, there's no >>>> original Berkeley code left here so just copy his copyright over. >>>> >>>> >> >