From owner-cvs-all@FreeBSD.ORG  Sat Feb  2 19:33:47 2008
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 661A116A41B;
	Sat,  2 Feb 2008 19:33:47 +0000 (UTC)
	(envelope-from ceri@submonkey.net)
Received: from shrike.submonkey.net (cpc3-cdif2-0-0-cust64.cdif.cable.ntl.com
	[81.106.128.65])
	by mx1.freebsd.org (Postfix) with ESMTP id 0058513C457;
	Sat,  2 Feb 2008 19:33:47 +0000 (UTC)
	(envelope-from ceri@submonkey.net)
Received: from ceri by shrike.submonkey.net with local (Exim 4.69 (FreeBSD))
	(envelope-from <ceri@submonkey.net>)
	id 1JLO7V-0006gM-EB; Sat, 02 Feb 2008 19:33:45 +0000
Date: Sat, 2 Feb 2008 19:33:44 +0000
From: Ceri Davies <ceri@submonkey.net>
To: Hartmut Brandt <hartmut.brandt@dlr.de>
Message-ID: <20080202193344.GI6064@submonkey.net>
References: <200802021227.m12CRcZ9008161@repoman.freebsd.org>
	<20080202145321.GH6064@submonkey.net>
	<20080202160451.GD11904@zaphod.nitro.dk> <47A49FBF.2010301@dlr.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="APvmIexg9DiduZOF"
Content-Disposition: inline
In-Reply-To: <47A49FBF.2010301@dlr.de>
X-PGP: finger ceri@FreeBSD.org
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: Ceri Davies <ceri@submonkey.net>
Cc: cvs-all@FreeBSD.org, cvs-src@FreeBSD.org, src-committers@FreeBSD.org,
	Dag-Erling Smorgrav <des@FreeBSD.org>,
	"Simon L. Nielsen" <simon@FreeBSD.org>
Subject: Re: cvs commit: src/etc/periodic/security 100.chksetuid
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 02 Feb 2008 19:33:47 -0000


--APvmIexg9DiduZOF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Feb 02, 2008 at 05:52:15PM +0100, Hartmut Brandt wrote:
> Simon L. Nielsen wrote:
>> On 2008.02.02 14:53:21 +0000, Ceri Davies wrote:
>>> On Sat, Feb 02, 2008 at 12:27:38PM +0000, Dag-Erling Smorgrav wrote:
>>>> des         2008-02-02 12:27:38 UTC
>>>>=20
>>>>   FreeBSD src repository
>>>>=20
>>>>   Modified files:
>>>>     etc/periodic/security 100.chksetuid   Log:
>>>>   Rewrite to consume significantly less memory, by using find -s inste=
ad of
>>>>   find | sort.  As a bonus, this simplifies the logic considerably.  A=
lso
>>>>   remove the bogus "overruning the args to ls" comment and the corresp=
onding
>>>>   "-n 20" argument to xargs; the whole point with xargs is precisely t=
hat it
>>>>   knows how large the argument list can safely get.
>>> Why use xargs at all?  The "-exec ls -liTd {} +" primary would do the
>>> same thing.
>>=20
>> You would end up executing ls a lot more times with the extra overhead
>> for fork() etc. per file.
>=20
> I think "-exec ... {} +" collects as much arguments before executing just=
=20
> as xargs does. This is different from "-exec ... {} ;" which execs for ea=
ch=20
> argument.

Exactly my point, yes.

Ceri
--=20
That must be wonderful!  I don't understand it at all.
                                                  -- Moliere

--APvmIexg9DiduZOF
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (FreeBSD)

iD8DBQFHpMWYocfcwTS3JF8RAgtLAKCGvjIWu/DEa+LauxQqfRTKjhyqFQCcDpTY
qdlnJlnIpaW5Wk4EwcAUFec=
=ZQDm
-----END PGP SIGNATURE-----

--APvmIexg9DiduZOF--