Date: Thu, 20 Aug 2020 17:45:55 +0000 (UTC) From: Hans Petter Selasky <hselasky@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r364433 - head/sys/dev/usb/controller Message-ID: <202008201745.07KHjtHk025810@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: hselasky Date: Thu Aug 20 17:45:54 2020 New Revision: 364433 URL: https://svnweb.freebsd.org/changeset/base/364433 Log: Fix regression after r364379. The AMD's Ryzen 3 3200g XHCI controllers apparently need the evaluate control endpoint context command, but we don't need to issue this command when the bMaxPacketSize is received after the read of the USB device descriptor, because this part should be handled automatically. PR: 248784 Tested by: emaste, hselasky MFC after: 1 week Sponsored by: Mellanox Technologies Modified: head/sys/dev/usb/controller/xhci.c Modified: head/sys/dev/usb/controller/xhci.c ============================================================================== --- head/sys/dev/usb/controller/xhci.c Thu Aug 20 17:35:47 2020 (r364432) +++ head/sys/dev/usb/controller/xhci.c Thu Aug 20 17:45:54 2020 (r364433) @@ -3904,10 +3904,8 @@ xhci_configure_reset_endpoint(struct usb_xfer *xfer) if (!(sc->sc_hw.devs[index].ep_configured & mask)) { sc->sc_hw.devs[index].ep_configured |= mask; err = xhci_cmd_configure_ep(sc, buf_inp.physaddr, 0, index); - } else if (epno != 1) { - err = xhci_cmd_evaluate_ctx(sc, buf_inp.physaddr, index); } else { - err = 0; + err = xhci_cmd_evaluate_ctx(sc, buf_inp.physaddr, index); } if (err != 0) {
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202008201745.07KHjtHk025810>