From owner-svn-ports-all@freebsd.org Tue Apr 30 19:20:03 2019 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 643E2159BADF; Tue, 30 Apr 2019 19:20:03 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DA7468ADCC; Tue, 30 Apr 2019 19:20:02 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: by mail-pl1-f180.google.com with SMTP id w20so6567282plq.3; Tue, 30 Apr 2019 12:20:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6or5Y6gevSQkrZ/MqKzMxoHoZrlUWu4GVE8+Os8KTN8=; b=i706o2xnxCwV5kWJMdnw7pb04y6wu1lMxXjN6/m/4Mjv4RfeIZonR8TwItRUmwvOOa 3kqDROcLlJdwipTAq2PaYEXxy9Ox/mpN5gZo66IZFxWHTNHtsaCjaD1VJujTWWdYYxuJ EiTQg7n9T7mzKnALq7/0hBqJhl6rWLMbKSCIrurXSthLKPplpsS9qLR8IdncUDANBNOY Yr1ez4rMo/wSyV9EDpkfTDHG5TVQ/58ArjpsAdtzvxuaQm91j1MyL7vDm1jijzs30k5R QmahsU6el/jhVxynESlubfaphy3uR9yKEgXiReGm2YbdYU8rFzeeOU/BvYYGqR5MUi98 Scnw== X-Gm-Message-State: APjAAAVylkjAJUQ5vlO3rWbCzgFYKmoK5FNEo/J5mrNMozlPbGopzAhN 0GVKEgjisJ8paZdLC+nyX+1V1KAXMVA= X-Google-Smtp-Source: APXvYqzIsQQL/JNqOz2MHjYWEK07EGdgCsmXtg9vMNzLanLaJiqAu3KIHtAWPLNfRNTUp+hOS9wWpw== X-Received: by 2002:a17:902:2927:: with SMTP id g36mr68468844plb.6.1556651996069; Tue, 30 Apr 2019 12:19:56 -0700 (PDT) Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com. [209.85.210.177]) by smtp.gmail.com with ESMTPSA id g4sm61561735pfc.75.2019.04.30.12.19.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Apr 2019 12:19:55 -0700 (PDT) Received: by mail-pf1-f177.google.com with SMTP id z28so2240827pfk.0; Tue, 30 Apr 2019 12:19:55 -0700 (PDT) X-Received: by 2002:a63:e045:: with SMTP id n5mr65268209pgj.230.1556651995651; Tue, 30 Apr 2019 12:19:55 -0700 (PDT) MIME-Version: 1.0 References: <201904301429.x3UETKUD077864@repo.freebsd.org> <20190430191519.GA91200@ThinkPad-X200.g.anongoth.pl> In-Reply-To: <20190430191519.GA91200@ThinkPad-X200.g.anongoth.pl> From: Gleb Popov Date: Tue, 30 Apr 2019 23:19:29 +0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r500497 - head/security/klee To: Piotr Kubaj Cc: svn-ports-all@freebsd.org, svn-ports-head@freebsd.org X-Rspamd-Queue-Id: DA7468ADCC X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-7.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-1.00)[-0.996,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Apr 2019 19:20:03 -0000 On Tue, Apr 30, 2019 at 11:15 PM Piotr Kubaj wrote: > Is there a point in creating a PR that you accept and then adding you to > reviewers? > > Or do you mean only doing a review? > Yes, the point is that you can do without a PR at all, since I can approve the change on the Phabricator. > On 19-04-30 18:39:02, Gleb Popov wrote: > >On Tue, Apr 30, 2019 at 6:29 PM Piotr Kubaj wrote: > > > >> Author: pkubaj > >> Date: Tue Apr 30 14:29:20 2019 > >> New Revision: 500497 > >> URL: https://svnweb.freebsd.org/changeset/ports/500497 > >> > >> Log: > >> security/klee: fix build with GCC-based architectures > >> > >> Add USES=compiler:c++14-lang to fix build on GCC architectures: > >> Make Error in lib/Basic/CMakeLists.txt: > >> Target "kleeBasic" requires the language dialect "CXX14" (with > compiler > >> extensions), but CMake does not know the compile flags to use to > >> enable it. > >> > >> PR: 237623 > >> Approved by: arrowd (maintainer), mat (mentor) > >> Differential Revision: https://reviews.freebsd.org/D20088 > >> > >> Modified: > >> head/security/klee/Makefile > >> > >> Modified: head/security/klee/Makefile > >> > >> > ============================================================================== > >> --- head/security/klee/Makefile Tue Apr 30 14:26:31 2019 > (r500496) > >> +++ head/security/klee/Makefile Tue Apr 30 14:29:20 2019 > (r500497) > >> @@ -17,7 +17,8 @@ BUILD_DEPENDS= > >> llvm-config${LLVM_DEFAULT}:devel/llvm${ > >> RUN_DEPENDS= llvm-config${LLVM_DEFAULT}:devel/llvm${LLVM_DEFAULT} \ > >> ${PYTHON_PKGNAMEPREFIX}tabulate>0:devel/py-tabulate@ > >> ${PY_FLAVOR} > >> > >> -USES= cmake localbase pkgconfig python:3.5+,run shebangfix > >> +USES= cmake compiler:c++14-lang localbase pkgconfig > >> python:3.5+,run \ > >> + shebangfix > >> USE_GITHUB= yes > >> SHEBANG_FILES= tools/klee-stats/klee-stats tools/ktest-tool/ktest-tool > >> USE_LDCONFIG= yes > >> > >> > >I have an account on our Phab, so you can add @arrowd to reviewers there. > > > >-- > >This message has been scanned for viruses and > >dangerous content by MailScanner, and is > >believed to be clean. > > >