From owner-freebsd-current Sat Mar 1 15:36:45 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B847D37B401; Sat, 1 Mar 2003 15:36:44 -0800 (PST) Received: from pit.databus.com (p70-227.acedsl.com [66.114.70.227]) by mx1.FreeBSD.org (Postfix) with ESMTP id D1BAE43FD7; Sat, 1 Mar 2003 15:36:43 -0800 (PST) (envelope-from barney@pit.databus.com) Received: from pit.databus.com (localhost [127.0.0.1]) by pit.databus.com (8.12.7/8.12.7) with ESMTP id h21NagFr064535; Sat, 1 Mar 2003 18:36:42 -0500 (EST) (envelope-from barney@pit.databus.com) Received: (from barney@localhost) by pit.databus.com (8.12.7/8.12.7/Submit) id h21Nag6N064534; Sat, 1 Mar 2003 18:36:42 -0500 (EST) (envelope-from barney) Date: Sat, 1 Mar 2003 18:36:42 -0500 From: Barney Wolff To: Jens Rehsack Cc: Juli Mallett , current@FreeBSD.ORG Subject: Re: PATCH: type errors in src-tree Message-ID: <20030301233642.GA64401@pit.databus.com> References: <3E5EA13E.9020208@liwing.de> <3E60F1CF.2030400@liwing.de> <20030301155546.A39174@FreeBSD.org> <3E612F7F.1090002@liwing.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3E612F7F.1090002@liwing.de> User-Agent: Mutt/1.4i X-Scanned-By: MIMEDefang 2.30 (www . roaringpenguin . com / mimedefang) Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, Mar 01, 2003 at 11:09:03PM +0100, Jens Rehsack wrote: > ... > >>- u_char **bufp; > >>+ caddr_t *bufp; > ... > Of course. Very often in ilmid.c the type caddr_t was used, and nearly > the same count of 'const char *'s was used. I've searched the include > files for caddr_t (core address) and found it defined as 'char *', so I > decided to used commonly caddr_t - maybe later I check which of them > could be changed into 'c_caddr_t' for being const. But You can of couse > replace all 'caddr_t' which 'char *'. Shouldn't we care about u_char vs char? On some machines it matters, and on all machines compilers tend to notice and generate warnings. -- Barney Wolff http://www.databus.com/bwresume.pdf I'm available by contract or FT, in the NYC metro area or via the 'Net. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message