From owner-freebsd-cvsweb@FreeBSD.ORG Mon Feb 23 13:55:07 2004 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7E8E416A4CE for ; Mon, 23 Feb 2004 13:55:07 -0800 (PST) Received: from cmsrelay03.mx.net (cmsrelay03.mx.net [165.212.11.112]) by mx1.FreeBSD.org (Postfix) with SMTP id 441D743D2F for ; Mon, 23 Feb 2004 13:55:07 -0800 (PST) (envelope-from noackjr@alumni.rice.edu) Received: from uadvg128.cms.usa.net (165.212.11.128) by cmsoutbound.mx.net with SMTP; 23 Feb 2004 21:55:06 -0000 Received: from optimator.noacks.org [66.136.22.254] by uadvg128.cms.usa.net (ASMTP/noackjr@usa.net) via mtad (C8.MAIN.3.13N) with ESMTP id 948iBwV4D0482M28; Mon, 23 Feb 2004 21:55:03 GMT X-USANET-Auth: 66.136.22.254 AUTH noackjr@usa.net optimator.noacks.org Received: from localhost (localhost [127.0.0.1]) by optimator.noacks.org (Postfix) with ESMTP id AE0606112 for ; Mon, 23 Feb 2004 15:55:02 -0600 (CST) Received: from optimator.noacks.org ([127.0.0.1]) by localhost (optimator.noacks.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 67415-02 for ; Mon, 23 Feb 2004 15:55:01 -0600 (CST) Received: from alumni.rice.edu (optimator [192.168.1.11]) by optimator.noacks.org (Postfix) with ESMTP id 7E6276110 for ; Mon, 23 Feb 2004 15:55:01 -0600 (CST) Message-ID: <403A76B5.4070804@alumni.rice.edu> Date: Mon, 23 Feb 2004 15:55:01 -0600 From: Jon Noack User-Agent: Mozilla Thunderbird 0.5 (Windows/20040207) X-Accept-Language: en-us, en MIME-Version: 1.0 To: freebsd-cvsweb@FreeBSD.org References: In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new at noacks.org Subject: Re: highlighting PERL code with enscript X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: noackjr@alumni.rice.edu List-Id: CVS Web maintenance mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Feb 2004 21:55:07 -0000 On 10/20/2003 4:45 AM, Stefan Moessler wrote: > i'm using cvsweb-2.9.1 with cygwin+apache2. Highlighting does not work > for filenames ending with *.pl . I think there is a problem with the > regex for filename matching of perl-programs in cvsweb.conf ($FreeBSD: > projects/cvsweb/cvsweb.conf,v 1.62 2003/10/09 20:14:11 scop Exp $). The > actual line in cvsweb.conf(596) is: > > %enscript_types = > ... > 'perl' => qr/\.p(m|(er?)l)$/io, > ... > ); This is still present in 2.9.3 (now line 567). I'm not an expert on regex, but this looks to me like it matches .pm, .pel, and .perl (ignoring case). Shouldn't the '?' be outside the parens: 'perl' => qr/\.p(m|(er)?l)$/io, This should match .pm, .pl, and .perl (ignoring case). I have verified that this fixes perl highlighting for me. Jon Noack