From owner-freebsd-net@freebsd.org Thu Feb 23 19:03:11 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4ACE6CE9A32 for ; Thu, 23 Feb 2017 19:03:11 +0000 (UTC) (envelope-from lukasz.wojcik@zoho.com) Received: from sender-pp-091.zoho.com (sender-pp-091.zoho.com [135.84.80.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 004261E5 for ; Thu, 23 Feb 2017 19:03:10 +0000 (UTC) (envelope-from lukasz.wojcik@zoho.com) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=zapps768; d=zoho.com; h=to:from:subject:message-id:date:user-agent:mime-version:content-type; b=B0/+iurvZdwN+T6U09EUZ5HbtrrzH5MBluUeTPQybP4jBMJCNpKjYjvNBjxiwCe59C87MxokN9KW jW0YpBsz9jC9Qjn45UgrxoYB8sDFoTZ47XFMv4uGFHVl97HVZMmY Received: from [192.168.0.31] (89-69-60-197.dynamic.chello.pl [89.69.60.197]) by mx.zohomail.com with SMTPS id 1487876585523496.76497674295445; Thu, 23 Feb 2017 11:03:05 -0800 (PST) To: freebsd-net@freebsd.org From: =?UTF-8?B?xYF1a2FzeiBXw7NqY2lr?= Subject: NETGRAPH's ng_cisco and IPv6 support Message-ID: <9980efee-f51c-2e48-59e1-099a609fc0a3@zoho.com> Date: Thu, 23 Feb 2017 20:03:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------5AFC86F01A2CAF91540AA2D7" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Feb 2017 19:03:11 -0000 This is a multi-part message in MIME format. --------------5AFC86F01A2CAF91540AA2D7 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Hello everyone, I've recently started to develop certain driver that uses 'ng_cisco' netgraph module for CHDLC en-/de-capsulation. When it connects with ng_cisco node via 'inet' hook, everything works fine, but there is an issue when trying to use 'inet6' node. cisco_notify() routine only sends flow control messages to nodes connected via 'inet' hook, completely ignoring those connected via 'inet6'. This poses some problem if peer node relies on link status information passed from ng_cisco. I'd therefore like to suggest/discuss a patch (attached to this email). All it does is to make ng_cisco node pass flow control messages to *both* 'inet' and 'inet6' peers. It seems to me that it is both possible and sensible to expect both mentioned hooks to be connected at the same time. I would appreciate any feedback. Best regards, -ŁW --------------5AFC86F01A2CAF91540AA2D7 Content-Type: text/plain; charset=UTF-8; name="cisco_ipv6_notify_all2.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="cisco_ipv6_notify_all2.patch" ZGlmZiAtLWdpdCBhL3N5cy9uZXRncmFwaC9uZ19jaXNjby5jIGIvc3lzL25ldGdyYXBoL25n X2Npc2NvLmMKaW5kZXggN2U2NGEwZi4uMTJlN2UwMyAxMDA2NDQKLS0tIGEvc3lzL25ldGdy YXBoL25nX2Npc2NvLmMKKysrIGIvc3lzL25ldGdyYXBoL25nX2Npc2NvLmMKQEAgLTYzNywx MCArNjM3LDIwIEBAIGNpc2NvX25vdGlmeShzY19wIHNjLCB1aW50MzJfdCBjbWQpCiAJc3Ry dWN0IG5nX21lc2cgKm1zZzsKIAlpbnQgZHVtbXlfZXJyb3IgPSAwOwogCi0JaWYgKHNjLT5p bmV0Lmhvb2sgPT0gTlVMTCkgLyogbm90aGluZyB0byBub3RpZnkgKi8KKwlpZiAoc2MtPmlu ZXQuaG9vayA9PSBOVUxMICYmIHNjLT5pbmV0Ni5ob29rID09IE5VTEwpCisJCS8qIG5vdGhp bmcgdG8gbm90aWZ5ICovCiAJCXJldHVybjsKLSAgICAgICAgICAgICAgICAKLQlOR19NS01F U1NBR0UobXNnLCBOR01fRkxPV19DT09LSUUsIGNtZCwgMCwgTV9OT1dBSVQpOwotCWlmICht c2cgIT0gTlVMTCkKLQkJTkdfU0VORF9NU0dfSE9PSyhkdW1teV9lcnJvciwgc2MtPm5vZGUs IG1zZywgc2MtPmluZXQuaG9vaywgMCk7CisKKwlpZiAoc2MtPmluZXQuaG9vayAhPSBOVUxM KSB7CisJCU5HX01LTUVTU0FHRShtc2csIE5HTV9GTE9XX0NPT0tJRSwgY21kLCAwLCBNX05P V0FJVCk7CisJCWlmIChtc2cgIT0gTlVMTCkKKwkJCU5HX1NFTkRfTVNHX0hPT0soZHVtbXlf ZXJyb3IsIHNjLT5ub2RlLCBtc2csCisJCQkgICAgc2MtPmluZXQuaG9vaywgMCk7CisJfQor CWlmIChzYy0+aW5ldDYuaG9vayAhPSBOVUxMKSB7CisJCU5HX01LTUVTU0FHRShtc2csIE5H TV9GTE9XX0NPT0tJRSwgY21kLCAwLCBNX05PV0FJVCk7CisJCWlmIChtc2cgIT0gTlVMTCkK KwkJCU5HX1NFTkRfTVNHX0hPT0soZHVtbXlfZXJyb3IsIHNjLT5ub2RlLCBtc2csCisJCQkg ICAgc2MtPmluZXQ2Lmhvb2ssIDApOworCX0KIH0K --------------5AFC86F01A2CAF91540AA2D7--