Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 1 May 2015 22:57:00 +0200
From:      Baptiste Daroussin <bapt@freebsd.org>
To:        d@delphij.net
Cc:        Sergey Kandaurov <pluknet@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r282314 - in head: include lib/libc/stdlib
Message-ID:  <20150501205700.GW13141@ivaldir.etoilebsd.net>
In-Reply-To: <5543DDA6.6080702@delphij.net>
References:  <201505011832.t41IWGSs002284@svn.freebsd.org> <CAE-mSOLBYgghng-hdbvK0_Eyn4m8RghkR3ea7E=jVNjdimYcRA@mail.gmail.com> <20150501193407.GT13141@ivaldir.etoilebsd.net> <5543DDA6.6080702@delphij.net>

next in thread | previous in thread | raw e-mail | index | archive | help

--1gsfN/+pS0/2Ta7u
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, May 01, 2015 at 01:10:14PM -0700, Xin Li wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>=20
> On 05/01/15 12:34, Baptiste Daroussin wrote:
> > On Fri, May 01, 2015 at 10:22:50PM +0300, Sergey Kandaurov wrote:
> >> On 1 May 2015 at 21:32, Baptiste Daroussin <bapt@freebsd.org>
> >> wrote:
> >>> Author: bapt Date: Fri May  1 18:32:16 2015 New Revision:
> >>> 282314 URL: https://svnweb.freebsd.org/changeset/base/282314
> >>>=20
> >>> Log: Import reallocarray(3) from OpenBSD
> >>>=20
> >>> Add a manpage for it, assign the copyright to the OpenBSD
> >>> project on it since it is mostly copy/paste from OpenBSD
> >>> manpage. style(9) fixes [..]
> >>=20
> >>> Added: head/lib/libc/stdlib/reallocarray.3=20
> >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> >>>
> >>>=20
> - --- /dev/null   00:00:00 1970   (empty, because file is newly added)
> >>> +++ head/lib/libc/stdlib/reallocarray.3 Fri May  1 18:32:16
> >>> 2015        (r282314) @@ -0,0 +1,136 @@ +.\" Copyright (c) 2015
> >>> OpenBSD +.\" All rights reserved.
> >>=20
> >> This copyright notice looks suspicious.
> >>=20
> > Well I wrote the man page but by copy/pasting code from OpenBSD
> > malloc(3) manpage which copyright should I set?
>=20
> "OpenBSD" is not a legal entity so the declaration _may_ be invalid
> (IANL).  OpenBSD developers are very careful here, and there is no
> reason we should do the opposite.

Fixed
>=20
> Normally you copy the copyright notice altogether (in this case, since
> the text are mostly new creation from Theo de Raadt, he may have the
> right to just license this portion to us; they probably didn't do it
> because the new addition to the malloc(3) manual page is too small to
> warrant additional owners) or rewrite it to make the copyright
> ownership clear.
>=20
> I'm kinda disappointed with the fact that there is no seek for public
> review (e.g. -arch@ or -standard@) on wider audience level for
> essential system libraries like libc, as others may already working on
> this in private, by the way.  But since the API is already there I
> guess it should stay.
>=20
> Two comments on the code change itself:
>=20
> a) __FreeBSD_version should be bumped and this should be documented.

Done
>=20
> b) It may be sensible to use __builtin_umul_overflow instead of
> hand-rolling the same functionality.  I think the compiler is not
> smart enough to handle that.
>=20

That I have no opinion about it, I just wanted to get the avoid the duplica=
tion
of that code anywhere in base.

Bapt

--1gsfN/+pS0/2Ta7u
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlVD6JwACgkQ8kTtMUmk6ExAyACZAXBVOSDTgEeTDHEtXDX8wBcL
vp0AoJOXFXcXrsbIFNlZR16ur6syEkvv
=JkVu
-----END PGP SIGNATURE-----

--1gsfN/+pS0/2Ta7u--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150501205700.GW13141>