From owner-svn-src-head@FreeBSD.ORG Fri May 1 20:57:05 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A90AD2D0; Fri, 1 May 2015 20:57:05 +0000 (UTC) Received: from mail-wg0-x22e.google.com (mail-wg0-x22e.google.com [IPv6:2a00:1450:400c:c00::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3CB701BC7; Fri, 1 May 2015 20:57:05 +0000 (UTC) Received: by wgso17 with SMTP id o17so100502438wgs.1; Fri, 01 May 2015 13:57:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=OjXnzgIsyP7lrSnSrqeWINZ5xqOmgAUNlQxzz8h92S8=; b=b9f9laV7kDWdOl9clD6ExjjckypIX+g6sLG+w0rPhvKKXcBTCzl982ptTt+j/BVTbw UclE1NfrURvLXL+TzibtHEg4zcywzdEQFx5sqtki85JEsoHbvnnpKmGHcwpg8m67kPZ/ Y/RCXifKwlU37HYkKNATdgL0CB88sxlvI5ykbwIFxDKuJNN+R3h3KlHknTVlxIbI+QMX DHuB+bI3HtOsF0p1i4dGi27EYK3ZbNz4Z1F8d5ZO3KXetl5g8yCW7tN3DagtEQtIXp1g SoRp6OwNUeFjrAGtZHLgGiQ2yCBM4ydzCW/0rxVRMj6cBQIpZxcOd+n/GJbm6zxrPjZh we8g== X-Received: by 10.180.37.73 with SMTP id w9mr17143728wij.7.1430513823780; Fri, 01 May 2015 13:57:03 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by mx.google.com with ESMTPSA id y7sm9047115wjw.16.2015.05.01.13.57.02 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 May 2015 13:57:02 -0700 (PDT) Sender: Baptiste Daroussin Date: Fri, 1 May 2015 22:57:00 +0200 From: Baptiste Daroussin To: d@delphij.net Cc: Sergey Kandaurov , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r282314 - in head: include lib/libc/stdlib Message-ID: <20150501205700.GW13141@ivaldir.etoilebsd.net> References: <201505011832.t41IWGSs002284@svn.freebsd.org> <20150501193407.GT13141@ivaldir.etoilebsd.net> <5543DDA6.6080702@delphij.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1gsfN/+pS0/2Ta7u" Content-Disposition: inline In-Reply-To: <5543DDA6.6080702@delphij.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 May 2015 20:57:05 -0000 --1gsfN/+pS0/2Ta7u Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 01, 2015 at 01:10:14PM -0700, Xin Li wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA512 >=20 > On 05/01/15 12:34, Baptiste Daroussin wrote: > > On Fri, May 01, 2015 at 10:22:50PM +0300, Sergey Kandaurov wrote: > >> On 1 May 2015 at 21:32, Baptiste Daroussin > >> wrote: > >>> Author: bapt Date: Fri May 1 18:32:16 2015 New Revision: > >>> 282314 URL: https://svnweb.freebsd.org/changeset/base/282314 > >>>=20 > >>> Log: Import reallocarray(3) from OpenBSD > >>>=20 > >>> Add a manpage for it, assign the copyright to the OpenBSD > >>> project on it since it is mostly copy/paste from OpenBSD > >>> manpage. style(9) fixes [..] > >>=20 > >>> Added: head/lib/libc/stdlib/reallocarray.3=20 > >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > >>> > >>>=20 > - --- /dev/null 00:00:00 1970 (empty, because file is newly added) > >>> +++ head/lib/libc/stdlib/reallocarray.3 Fri May 1 18:32:16 > >>> 2015 (r282314) @@ -0,0 +1,136 @@ +.\" Copyright (c) 2015 > >>> OpenBSD +.\" All rights reserved. > >>=20 > >> This copyright notice looks suspicious. > >>=20 > > Well I wrote the man page but by copy/pasting code from OpenBSD > > malloc(3) manpage which copyright should I set? >=20 > "OpenBSD" is not a legal entity so the declaration _may_ be invalid > (IANL). OpenBSD developers are very careful here, and there is no > reason we should do the opposite. Fixed >=20 > Normally you copy the copyright notice altogether (in this case, since > the text are mostly new creation from Theo de Raadt, he may have the > right to just license this portion to us; they probably didn't do it > because the new addition to the malloc(3) manual page is too small to > warrant additional owners) or rewrite it to make the copyright > ownership clear. >=20 > I'm kinda disappointed with the fact that there is no seek for public > review (e.g. -arch@ or -standard@) on wider audience level for > essential system libraries like libc, as others may already working on > this in private, by the way. But since the API is already there I > guess it should stay. >=20 > Two comments on the code change itself: >=20 > a) __FreeBSD_version should be bumped and this should be documented. Done >=20 > b) It may be sensible to use __builtin_umul_overflow instead of > hand-rolling the same functionality. I think the compiler is not > smart enough to handle that. >=20 That I have no opinion about it, I just wanted to get the avoid the duplica= tion of that code anywhere in base. Bapt --1gsfN/+pS0/2Ta7u Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlVD6JwACgkQ8kTtMUmk6ExAyACZAXBVOSDTgEeTDHEtXDX8wBcL vp0AoJOXFXcXrsbIFNlZR16ur6syEkvv =JkVu -----END PGP SIGNATURE----- --1gsfN/+pS0/2Ta7u--